From 74e439808e514d2dc0eb6a7bbd7b7c00b319508b Mon Sep 17 00:00:00 2001 From: David Pursehouse Date: Mon, 20 Nov 2017 08:28:19 +0900 Subject: [PATCH 1/2] AccountManager: Remove unused import Change-Id: I8159cacdecad2e6cbdaded9e322a3b29418532da --- .../java/com/google/gerrit/server/account/AccountManager.java | 1 - 1 file changed, 1 deletion(-) diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/account/AccountManager.java b/gerrit-server/src/main/java/com/google/gerrit/server/account/AccountManager.java index 89cc45bf1e..1e4640954b 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/account/AccountManager.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/account/AccountManager.java @@ -32,7 +32,6 @@ import com.google.gwtorm.server.OrmException; import com.google.gwtorm.server.ResultSet; import com.google.gwtorm.server.SchemaFactory; import com.google.inject.Inject; -import com.google.inject.Provider; import com.google.inject.Singleton; import org.slf4j.Logger; From 3222b751fa79c247a26762c4d22708aea1e91492 Mon Sep 17 00:00:00 2001 From: Dave Borowitz Date: Thu, 18 Feb 2016 21:56:04 -0500 Subject: [PATCH 2/2] TestTimeUtil: Also stub out JGit's SystemReader [redux] This is used in several places, most notably in the constructors for PersonIdent that don't provide explicit timestamps. As a result of this change, projects created in rapid succession in tests that use a test clock should not share empty commit SHA-1s. This was originally done in I6df1baa18, but was accidentally removed by the merge done in I991be7faf. Change-Id: I41445c6602ccfea349f303f6d5044bc9d56aec1d --- .../google/gerrit/testutil/TestTimeUtil.java | 52 ++++++++++++++++++- 1 file changed, 51 insertions(+), 1 deletion(-) diff --git a/gerrit-server/src/test/java/com/google/gerrit/testutil/TestTimeUtil.java b/gerrit-server/src/test/java/com/google/gerrit/testutil/TestTimeUtil.java index 4c71c573fc..eae5ed99fb 100644 --- a/gerrit-server/src/test/java/com/google/gerrit/testutil/TestTimeUtil.java +++ b/gerrit-server/src/test/java/com/google/gerrit/testutil/TestTimeUtil.java @@ -17,6 +17,10 @@ package com.google.gerrit.testutil; import static com.google.common.base.Preconditions.checkState; import static java.util.concurrent.TimeUnit.MILLISECONDS; +import org.eclipse.jgit.lib.Config; +import org.eclipse.jgit.storage.file.FileBasedConfig; +import org.eclipse.jgit.util.FS; +import org.eclipse.jgit.util.SystemReader; import org.joda.time.DateTime; import org.joda.time.DateTimeUtils; import org.joda.time.DateTimeUtils.MillisProvider; @@ -63,11 +67,57 @@ public class TestTimeUtil { return clockMs.getAndAdd(clockStepMs); } }); + + SystemReader.setInstance(null); + final SystemReader defaultReader = SystemReader.getInstance(); + SystemReader r = new SystemReader() { + @Override + public String getHostname() { + return defaultReader.getHostname(); + } + + @Override + public String getenv(String variable) { + return defaultReader.getenv(variable); + } + + @Override + public String getProperty(String key) { + return defaultReader.getProperty(key); + } + + @Override + public FileBasedConfig openUserConfig(Config parent, FS fs) { + return defaultReader.openUserConfig(parent, fs); + } + + @Override + public FileBasedConfig openSystemConfig(Config parent, FS fs) { + return defaultReader.openSystemConfig(parent, fs); + } + + @Override + public long getCurrentTime() { + return clockMs.getAndAdd(clockStepMs); + } + + @Override + public int getTimezone(long when) { + return defaultReader.getTimezone(when); + } + }; + SystemReader.setInstance(r); } - /** Reset the clock to use the actual system clock. */ + /** + * Reset the clock to use the actual system clock. + *

+ * As a side effect, resets the {@link SystemReader} to the original default + * instance. + */ public static synchronized void useSystemTime() { DateTimeUtils.setCurrentMillisSystem(); + SystemReader.setInstance(null); } private TestTimeUtil() {