opendev/gerrit
Code Issues Proposed changes

Merge changes I651c570b,I0d571918

Browse Source 
* changes:
  Switch padding to margin in header
  Fix Gerrit global scoping issue
This commit is contained in:
David Pursehouse
2018-09-20 00:53:33 +00:00
committed by Gerrit Code Review
parent e808a8df23 57abe1ac95
commit 04c987347d
4 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
polygerrit-ui/app/elements/core/gr-main-header/gr-main-header.html
View File

@@ -53,7 +53,7 @@ limitations under the License.
content: ""; content: "";
display: inline-block; display: inline-block;
height: var(--header-icon-size); height: var(--header-icon-size);
padding-right: calc(var(--header-icon-size) / 4); margin-right: calc(var(--header-icon-size) / 4);
vertical-align: text-bottom; vertical-align: text-bottom;
width: var(--header-icon-size); width: var(--header-icon-size);
} }

1
polygerrit-ui/app/elements/gr-app.html
View File

@@ -29,6 +29,7 @@ limitations under the License.
// Needed for JSCompiler to understand it's global. // Needed for JSCompiler to understand it's global.
// eslint-disable-next-line no-unused-vars, prefer-const // eslint-disable-next-line no-unused-vars, prefer-const
let Gerrit = window.Gerrit || {}; let Gerrit = window.Gerrit || {};
window.Gerrit = Gerrit;
</script> </script>
<link rel="import" href="../bower_components/polymer/polymer.html"> <link rel="import" href="../bower_components/polymer/polymer.html">

1
polygerrit-ui/app/embed/embed.html
View File

@@ -18,6 +18,7 @@ limitations under the License.
// Needed for JSCompiler to understand it's global. // Needed for JSCompiler to understand it's global.
// eslint-disable-next-line no-unused-vars, prefer-const // eslint-disable-next-line no-unused-vars, prefer-const
let Gerrit = window.Gerrit || {}; let Gerrit = window.Gerrit || {};
window.Gerrit = Gerrit;
</script> </script>
<link rel="import" href="../bower_components/polymer/polymer.html"> <link rel="import" href="../bower_components/polymer/polymer.html">
<link rel="import" href="../elements/change/gr-change-view/gr-change-view.html"> <link rel="import" href="../elements/change/gr-change-view/gr-change-view.html">

3
polygerrit-ui/app/gr-diff/gr-diff-root.html
View File

@@ -2,5 +2,6 @@
// Needed for JSCompiler to understand it's global. // Needed for JSCompiler to understand it's global.
// eslint-disable-next-line no-unused-vars, prefer-const // eslint-disable-next-line no-unused-vars, prefer-const
let Gerrit = window.Gerrit || {}; let Gerrit = window.Gerrit || {};
window.Gerrit = Gerrit;
</script> </script>
<link rel="import" href="../elements/diff/gr-diff/gr-diff.html"> <link rel="import" href="../elements/diff/gr-diff/gr-diff.html">