opendev/gerrit
Code Issues Proposed changes

Merge "Fix line-height of draft file comments"

Browse Source
This commit is contained in:
Shawn Pearce
2013-08-09 23:16:57 +00:00
committed by Gerrit Code Review
parent 5ec5ea6813 5a5cef31b5
commit 04d173b325
2 changed files with 11 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gerrit-gwtui/src/main/java/com/google/gerrit/client/diff/CommentBoxUi.css
View File

@@ -38,6 +38,7 @@
overflow: hidden;
text-overflow: ellipsis;
white-space: nowrap;
padding-bottom: 0.1em;
}
.date {
@@ -50,6 +51,7 @@
.contents {
margin-left: 28px;
padding-top: 2px;
padding-bottom: 2px;
position: relative;
}
.contents p,

18
gerrit-gwtui/src/main/java/com/google/gerrit/client/diff/DiffTable.ui.xml
View File

@@ -60,11 +60,11 @@ limitations under the License.
.b .diff .CodeMirror-linenumber {
background-color: #9f9;
}
.padding, .fileCommentCell {
.padding, .fileComment {
background-color: #eee;
}
.fileCommentCell {
overflow-x: auto;
.fileComment {
line-height: 1;
}
.a .CodeMirror-vscrollbar {
display: none !important;
@@ -105,19 +105,19 @@ limitations under the License.
<tr>
<td>
<table class='{style.table}'>
<tr ui:field='patchsetNavRow'>
<td ui:field='patchsetNavCellA' class='{style.padding}'>
<tr ui:field='patchsetNavRow' class='{style.padding}'>
<td ui:field='patchsetNavCellA'>
<d:PatchSelectBox2 ui:field='patchSelectBoxA' />
</td>
<td ui:field='patchsetNavCellB' class='{style.padding}'>
<td ui:field='patchsetNavCellB'>
<d:PatchSelectBox2 ui:field='patchSelectBoxB' />
</td>
</tr>
<tr ui:field='fileCommentRow'>
<td ui:field='fileCommentCellA' class='{style.padding}'>
<tr ui:field='fileCommentRow' class='{style.fileComment}'>
<td ui:field='fileCommentCellA'>
<d:FileCommentPanel ui:field='fileCommentPanelA' />
</td>
<td ui:field='fileCommentCellB' class='{style.padding}'>
<td ui:field='fileCommentCellB'>
<d:FileCommentPanel ui:field='fileCommentPanelB' />
</td>
</tr>