opendev/gerrit
Code Issues Proposed changes

Fix String.format(...) calls where more args are passed than used

Browse Source 
Change-Id: Ie6ddee996593b8bdddea20d8a8738a1048c54631
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
This commit is contained in:
Edwin Kempin
2013-08-22 15:15:50 +02:00
parent 1d947bf77c
commit 055d43fe5e
4 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gerrit-httpd/src/main/java/com/google/gerrit/httpd/restapi/RestApiServlet.java
View File

@@ -814,7 +814,7 @@ public class RestApiServlet extends HttpServlet {
throw new ResourceNotFoundException(projection); throw new ResourceNotFoundException(projection);
} else { } else {
throw new AmbiguousViewException(String.format( throw new AmbiguousViewException(String.format(
"Projection %s is ambiguous: ", "Projection %s is ambiguous: %s",
name, name,
Joiner.on(", ").join( Joiner.on(", ").join(
Iterables.transform(r.keySet(), new Function<String, String>() { Iterables.transform(r.keySet(), new Function<String, String>() {

2
gerrit-server/src/main/java/com/google/gerrit/server/group/ListIncludedGroups.java
View File

@@ -67,7 +67,7 @@ public class ListIncludedGroups implements RestReadView<GroupResource> {
included.add(json.format(i.getGroup())); included.add(json.format(i.getGroup()));
} }
} catch (NoSuchGroupException notFound) { } catch (NoSuchGroupException notFound) {
log.warn(String.format("Group %s no longer available, included into ", log.warn(String.format("Group %s no longer available, included into %s",
u.getIncludeUUID(), u.getIncludeUUID(),
rsrc.getGroup().getName())); rsrc.getGroup().getName()));
continue; continue;

2
gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/ShowCaches.java
View File

@@ -290,7 +290,7 @@ final class ShowCaches extends CacheCommand {
runtimeBean.getVmVendor(), runtimeBean.getVmVendor(),
runtimeBean.getVmName(), runtimeBean.getVmName(),
runtimeBean.getVmVersion()); runtimeBean.getVmVersion());
stdout.format(" on %s %s %s\n", "", stdout.format(" on %s %s %s\n",
osBean.getName(), osBean.getName(),
osBean.getVersion(), osBean.getVersion(),
osBean.getArch()); osBean.getArch());

2
gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/ShowQueue.java
View File

@@ -163,7 +163,7 @@ final class ShowQueue extends SshCommand {
} }
stdout.print(String.format("%8s %-12s %-4s %s\n", // stdout.print(String.format("%8s %-12s %-4s %s\n", //
id(task.getTaskId()), start, startTime, "", remoteName)); id(task.getTaskId()), start, startTime, remoteName));
} }
} }
stdout.print("----------------------------------------------" stdout.print("----------------------------------------------"