opendev/gerrit
Code Issues Proposed changes

Fix 'press c to comment' on first line of diff

Browse Source 
In the file list, divs are displayed as block elements, so that their
contents can be scrollable. It's impossible to fix this with a z-index.

Instead, this change shows the tooltip below rather than above in the
case that the first line is part of the selection range.

Bug: Issue 7320
Change-Id: I29a4ebc619cd0a5523fb4900abccb491cf9a5194
This commit is contained in:
Becky Siegel
2017-11-16 12:46:46 -08:00
parent 943579dcb9
commit 060763157c
6 changed files with 115 additions and 42 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
polygerrit-ui/app/elements/shared/gr-tooltip/gr-tooltip.html
View File

@@ -24,7 +24,7 @@ limitations under the License.
--gr-tooltip-arrow-size: .5em;
--gr-tooltip-arrow-center-offset: 0;
background-color: #333;
background-color: var(--tooltip-background-color, #333);
box-shadow: 0 1px 3px rgba(0, 0, 0, .3);
color: #fff;
font-size: .75rem;
@@ -52,11 +52,11 @@ limitations under the License.
width: 0;
}
.arrowPositionAbove {
border-top: var(--gr-tooltip-arrow-size) solid #333;
border-top: var(--gr-tooltip-arrow-size) solid var(--tooltip-background-color, #333);
bottom: -var(--gr-tooltip-arrow-size);
}
.arrowPositionBelow {
border-bottom: var(--gr-tooltip-arrow-size) solid #333;
border-bottom: var(--gr-tooltip-arrow-size) solid var(--tooltip-background-color, #333);
top: -var(--gr-tooltip-arrow-size);
}
</style>