opendev/gerrit
Code Issues Proposed changes

Remove dead ScanningChangeCacheImpl

Browse Source 
The ScanningChangeCacheImpl is now dead code. With VisibleRefFilter
using SearchingChangeCacheImpl directly the ScanningChangeCacheImpl
is no longer referenced by the server. This also lets us get rid of
the ChangeCache interface.

This cleanup of dead code enables further optimization of the
VisibleRefFilter -> SearchingChangeCacheImpl path.

Change-Id: I07144006358a70915ea0bf10ce04a8b826f22095
This commit is contained in:
Shawn Pearce
2016-06-18 09:34:06 -07:00
committed by Dave Borowitz
parent 7569b30f60
commit 0638cc98e0
9 changed files with 21 additions and 218 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
gerrit-server/src/test/java/com/google/gerrit/testutil/InMemoryModule.java
View File

@@ -44,11 +44,11 @@ import com.google.gerrit.server.config.GerritServerId;
import com.google.gerrit.server.config.SitePath;
import com.google.gerrit.server.config.TrackingFooters;
import com.google.gerrit.server.config.TrackingFootersProvider;
import com.google.gerrit.server.git.ChangeCacheImplModule;
import com.google.gerrit.server.git.ChangeUpdateExecutor;
import com.google.gerrit.server.git.GarbageCollection;
import com.google.gerrit.server.git.GitRepositoryManager;
import com.google.gerrit.server.git.PerThreadRequestScope;
import com.google.gerrit.server.git.SearchingChangeCacheImpl;
import com.google.gerrit.server.git.SendEmailExecutor;
import com.google.gerrit.server.index.IndexModule.IndexType;
import com.google.gerrit.server.index.change.ChangeSchemaDefinitions;
@@ -142,7 +142,7 @@ public class InMemoryModule extends FactoryModule {
});
bind(MetricMaker.class).to(DisabledMetricMaker.class);
install(cfgInjector.getInstance(GerritGlobalModule.class));
install(new ChangeCacheImplModule(false));
install(new SearchingChangeCacheImpl.Module());
factory(GarbageCollection.Factory.class);
bindScope(RequestScoped.class, PerThreadRequestScope.REQUEST);