opendev/gerrit
Code Issues Proposed changes

Rename "Open" to "Add/Open" in the inline editor

Browse Source 
Per discussion with @Ben, from a users experence its better to call
this 'Add/Open' rather than 'Open'.

Change-Id: I8db0de50da0451fa4a95c6545172134c8094c597
This commit is contained in:
Paladox none
2019-11-19 21:09:44 +00:00
parent c7c1086b4c
commit 06f2dd56fe
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
polygerrit-ui/app/elements/edit/gr-edit-constants.html
View File

@@ -22,7 +22,7 @@ limitations under the License.
// Order corresponds to order in the UI. // Order corresponds to order in the UI.
GrEditConstants.Actions = { GrEditConstants.Actions = {
OPEN: {label: 'Open', id: 'open'}, OPEN: {label: 'Add/Open', id: 'open'},
DELETE: {label: 'Delete', id: 'delete'}, DELETE: {label: 'Delete', id: 'delete'},
RENAME: {label: 'Rename', id: 'rename'}, RENAME: {label: 'Rename', id: 'rename'},
RESTORE: {label: 'Restore', id: 'restore'}, RESTORE: {label: 'Restore', id: 'restore'},

4
polygerrit-ui/app/elements/edit/gr-edit-controls/gr-edit-controls.html
View File

@@ -89,12 +89,12 @@ limitations under the License.
id="openDialog" id="openDialog"
class="invisible dialog" class="invisible dialog"
disabled$="[[!_isValidPath(_path)]]" disabled$="[[!_isValidPath(_path)]]"
confirm-label="Open" confirm-label="Confirm"
confirm-on-enter confirm-on-enter
on-confirm="_handleOpenConfirm" on-confirm="_handleOpenConfirm"
on-cancel="_handleDialogCancel"> on-cancel="_handleDialogCancel">
<div class="header" slot="header"> <div class="header" slot="header">
Open an existing or new file Add a new file or open an existing file
</div> </div>
<div class="main" slot="main"> <div class="main" slot="main">
<gr-autocomplete <gr-autocomplete