opendev/gerrit
Code Issues Proposed changes

Remove TODOs about Jimfs

Browse Source 
Arbitrary NIO FileSystem support is not on the roadmap for JGit. Leave
the blocker documented, but drop the TODO.

Change-Id: I6f2d72267ef25e28a1573ce34bd8d4fe17c5327a
This commit is contained in:
Dave Borowitz
2019-05-16 15:18:30 +02:00
parent ca0997fd53
commit 06fa5bc6f9
2 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
java/com/google/gerrit/acceptance/InMemoryTestingDatabaseModule.java
View File

@@ -55,8 +55,6 @@ class InMemoryTestingDatabaseModule extends LifecycleModule {
@Override @Override
protected void configure() { protected void configure() {
bind(Config.class).annotatedWith(GerritServerConfig.class).toInstance(cfg); bind(Config.class).annotatedWith(GerritServerConfig.class).toInstance(cfg);
// TODO(dborowitz): Use jimfs.
bind(Path.class).annotatedWith(SitePath.class).toInstance(sitePath); bind(Path.class).annotatedWith(SitePath.class).toInstance(sitePath);
if (repoManager != null) { if (repoManager != null) {

4
java/com/google/gerrit/testing/InMemoryModule.java
View File

@@ -174,8 +174,8 @@ public class InMemoryModule extends FactoryModule {
bindScope(RequestScoped.class, PerThreadRequestScope.REQUEST); bindScope(RequestScoped.class, PerThreadRequestScope.REQUEST);
// TODO(dborowitz): Use Jimfs. The biggest blocker is that JGit does not support Path-based // It would be nice to use Jimfs for the SitePath, but the biggest blocker is that JGit does not
// Configs, only FileBasedConfig. // support Path-based Configs, only FileBasedConfig.
bind(Path.class).annotatedWith(SitePath.class).toInstance(Paths.get(".")); bind(Path.class).annotatedWith(SitePath.class).toInstance(Paths.get("."));
bind(Config.class).annotatedWith(GerritServerConfig.class).toInstance(cfg); bind(Config.class).annotatedWith(GerritServerConfig.class).toInstance(cfg);
bind(GerritOptions.class).toInstance(new GerritOptions(false, false, false)); bind(GerritOptions.class).toInstance(new GerritOptions(false, false, false));