opendev/gerrit
Code Issues Proposed changes

Add step to SUBMITTING_PATCHES to ensure Change-Id

Browse Source 
Add a step to SUBMITTING_PATCHES to ensure each commit message has a
Change-Id.

Change-Id: Ib44bc519538e304dddd6332d4a99034fc56638b3
This commit is contained in:
J. Lewis Muir 2018-01-11 12:21:25 -06:00
parent f5061ee565
commit 072794767b
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
SUBMITTING_PATCHES
View File

@ -3,6 +3,7 @@ Short Version:
- Make small logical changes. - Make small logical changes.
- Provide a meaningful commit message. - Provide a meaningful commit message.
- Make sure all code is under the Apache License, 2.0. - Make sure all code is under the Apache License, 2.0.
- Make sure all commit messages have a Change-Id.
- Publish your changes for review: - Publish your changes for review:
git push https://gerrit.googlesource.com/gerrit HEAD:refs/for/master git push https://gerrit.googlesource.com/gerrit HEAD:refs/for/master
@ -67,6 +68,13 @@ Ensure you have obtained a unique HTTP password to identify yourself:
https://gerrit-review.googlesource.com/#/settings/http-password https://gerrit-review.googlesource.com/#/settings/http-password
Ensure you have installed the commit-msg hook that automatically
generates and inserts a Change-Id line during "git commit". This can
be done from the root directory of the local Git repository:
curl -Lo .git/hooks/commit-msg https://gerrit-review.googlesource.com/tools/hooks/commit-msg
chmod +x .git/hooks/commit-msg
Push your patches over HTTPS to the review server, possibly through Push your patches over HTTPS to the review server, possibly through
a remembered remote to make this easier in the future: a remembered remote to make this easier in the future: