opendev/gerrit
Code Issues Proposed changes

Merge "Add test for push with multiple approvals"

Browse Source
This commit is contained in:
Edwin Kempin
2016-02-01 09:46:16 +00:00
committed by Gerrit Code Review
parent 785bf8c74f 9e209d20fc
commit 0738efdb8f
1 changed files with 33 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
gerrit-acceptance-tests/src/test/java/com/google/gerrit/acceptance/git/AbstractPushForReview.java
View File

@@ -18,6 +18,8 @@ import static com.google.common.truth.Truth.assertThat;
import static com.google.common.truth.TruthJUnit.assume; import static com.google.common.truth.TruthJUnit.assume;
import static com.google.gerrit.acceptance.GitUtil.pushHead; import static com.google.gerrit.acceptance.GitUtil.pushHead;
import static com.google.gerrit.server.group.SystemGroupBackend.ANONYMOUS_USERS; import static com.google.gerrit.server.group.SystemGroupBackend.ANONYMOUS_USERS;
import static com.google.gerrit.server.project.Util.category;
import static com.google.gerrit.server.project.Util.value;
import static java.util.concurrent.TimeUnit.SECONDS; import static java.util.concurrent.TimeUnit.SECONDS;
import com.google.common.collect.ImmutableSet; import com.google.common.collect.ImmutableSet;
@@ -277,6 +279,37 @@ public abstract class AbstractPushForReview extends AbstractDaemonTest {
"Uploaded patch set 1: Code-Review+1."); "Uploaded patch set 1: Code-Review+1.");
} }
@Test
public void testPushWithMultipleApprovals()
throws Exception {
LabelType Q = category("Custom-Label",
value(1, "Positive"),
value(0, "No score"),
value(-1, "Negative"));
ProjectConfig config = projectCache.checkedGet(project).getConfig();
AccountGroup.UUID anon =
SystemGroupBackend.getGroup(ANONYMOUS_USERS).getUUID();
String heads = "refs/heads/*";
Util.allow(config, Permission.forLabel("Custom-Label"), -1, 1, anon, heads);
config.getLabelSections().put(Q.getName(), Q);
saveProjectConfig(project, config);
RevCommit c = commitBuilder()
.author(admin.getIdent())
.committer(admin.getIdent())
.add(PushOneCommit.FILE_NAME, PushOneCommit.FILE_CONTENT)
.message(PushOneCommit.SUBJECT)
.create();
pushHead(testRepo, "refs/for/master/%l=Code-Review+1,l=Custom-Label-1", false);
ChangeInfo ci = get(GitUtil.getChangeId(testRepo, c).get());
LabelInfo cr = ci.labels.get("Code-Review");
assertThat(cr.all).hasSize(1);
cr = ci.labels.get("Custom-Label");
assertThat(cr.all).hasSize(1);
}
@Test @Test
public void testPushNewPatchsetToRefsChanges() throws Exception { public void testPushNewPatchsetToRefsChanges() throws Exception {
PushOneCommit.Result r = pushTo("refs/for/master"); PushOneCommit.Result r = pushTo("refs/for/master");