opendev/gerrit
Code Issues Proposed changes

ReceiveCommits: Remove remnants of support for push to refs/changes/

Browse Source 
Change I99f6d400b removed support for push to refs/changes/ but left
an unused method and member variable. Remove them.

Change-Id: Ia4ba39e412ef55778aa72b2b83ecace90df51703
This commit is contained in:
David Pursehouse
2019-07-05 10:22:16 +09:00
parent 4256dde08b
commit 0754f1b295
1 changed files with 0 additions and 60 deletions
Download Patch File Download Diff File Expand all files Collapse all files

60
java/com/google/gerrit/server/git/receive/ReceiveCommits.java
View File

@@ -344,7 +344,6 @@ class ReceiveCommits {
// Immutable fields derived from constructor arguments.
private final boolean allowProjectOwnersToChangeParent;
private final boolean allowPushToRefsChanges;
private final LabelTypes labelTypes;
private final NoteMap rejectCommits;
private final PermissionBackend.ForProject permissions;
@@ -466,7 +465,6 @@ class ReceiveCommits {
this.receivePack = rp;
// Immutable fields derived from constructor arguments.
allowPushToRefsChanges = config.getBoolean("receive", "allowPushToRefsChanges", false);
repo = rp.getRepository();
project = projectState.getProject();
labelTypes = projectState.getLabelTypes();
@@ -1951,64 +1949,6 @@ class ReceiveCommits {
return receivePack.getRevWalk().parseCommit(r.getObjectId());
}
// Handle an upload to refs/changes/XX/CHANGED-NUMBER.
private void parseReplaceCommand(ReceiveCommand cmd, Change.Id changeId) {
try (TraceTimer traceTimer = newTimer("parseReplaceCommand")) {
logger.atFine().log("Parsing replace command");
if (cmd.getType() != ReceiveCommand.Type.CREATE) {
reject(cmd, "invalid usage");
return;
}
RevCommit newCommit;
try {
newCommit = receivePack.getRevWalk().parseCommit(cmd.getNewId());
logger.atFine().log("Replacing with %s", newCommit);
} catch (IOException e) {
logger.atSevere().withCause(e).log("Cannot parse %s as commit", cmd.getNewId().name());
reject(cmd, "invalid commit");
return;
}
Change changeEnt;
try {
changeEnt = notesFactory.createChecked(project.getNameKey(), changeId).getChange();
} catch (NoSuchChangeException e) {
logger.atSevere().withCause(e).log("Change not found %s", changeId);
reject(cmd, "change " + changeId + " not found");
return;
} catch (StorageException e) {
logger.atSevere().withCause(e).log("Cannot lookup existing change %s", changeId);
reject(cmd, "database error");
return;
}
if (!project.getNameKey().equals(changeEnt.getProject())) {
reject(cmd, "change " + changeId + " does not belong to project " + project.getName());
return;
}
BranchCommitValidator validator =
commitValidatorFactory.create(projectState, changeEnt.getDest(), user);
try {
BranchCommitValidator.Result validationResult =
validator.validateCommit(
receivePack.getRevWalk().getObjectReader(),
cmd,
newCommit,
false,
rejectCommits,
changeEnt);
messages.addAll(validationResult.messages());
if (validationResult.isValid()) {
logger.atFine().log("Replacing change %s", changeEnt.getId());
requestReplaceAndValidateComments(cmd, true, changeEnt, newCommit);
}
} catch (IOException e) {
reject(cmd, "I/O exception validating commit");
}
}
}
/**
* Update an existing change. If draft comments are to be published, these are validated and may
* be withheld.