opendev/gerrit
Code Issues Proposed changes

Better HTML email monospace font-size normalization

Browse Source 
The default styles of some browsers reduce the font-size of elements
with monospace fonts. Previously, this was normalized by setting the
font-size of monospaced elements in HTML emails. However, this approach
does not always result in consistent font sizes because the normal font
size is not known in general (without artificially fixing it). Instead,
abstract creation of PRE blocks into a callable private template and set
the font-family in a way that is not matched by the default styles.

Bug: Issue 4817
Change-Id: I4243a202eda471edaf420d9dc1186c4ed8484c9d
This commit is contained in:
Wyatt Allen
2016-10-26 14:54:44 -07:00
parent a2cca5be9f
commit 076363c1fd
11 changed files with 40 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gerrit-server/src/main/resources/com/google/gerrit/server/mail/DeleteVoteHtml.soy
View File

@@ -35,6 +35,6 @@
{/if}
{if $coverLetter}
<pre style="font-size:12px">{$coverLetter}</pre>
{call .Pre}{param content: $coverLetter /}{/call}
{/if}
{/template}