opendev/gerrit
Code Issues Proposed changes

HttpPluginServlet: Remove usage of deprecated IMPLEMENTATION_URL constant

Browse Source 
IMPLEMENTATION_URL is deprecated in Java 8 [1].

[1] https://docs.oracle.com/javase/8/docs/api/java/util/jar/Attributes.Name.html#IMPLEMENTATION_URL

Change-Id: Iab607c70d4f7760dc27cc13ffcac390602a4035a
This commit is contained in:
David Pursehouse 2016-05-17 14:38:00 +09:00
parent 3f7c75fd6e
commit 078ddcd789
8 changed files with 0 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
Documentation/dev-plugins.txt
View File

@ -94,7 +94,6 @@ manifest fields:
Implementation-Title: Example plugin showing examples
Implementation-Version: 1.0
Implementation-Vendor: Example, Inc.
Implementation-URL: http://example.com/opensource/plugin-foo/
====
=== ApiType

6
gerrit-httpd/src/main/java/com/google/gerrit/httpd/plugins/HttpPluginServlet.java
View File

@ -488,7 +488,6 @@ class HttpPluginServlet extends HttpServlet
String t = main.getValue(Attributes.Name.IMPLEMENTATION_TITLE);
String n = main.getValue(Attributes.Name.IMPLEMENTATION_VENDOR);
String v = main.getValue(Attributes.Name.IMPLEMENTATION_VERSION);
String u = main.getValue(Attributes.Name.IMPLEMENTATION_URL);
String a = main.getValue("Gerrit-ApiVersion");
html.append("<table class=\"plugin_info\">");
@ -507,11 +506,6 @@ class HttpPluginServlet extends HttpServlet
.append(v)
.append("</td></tr>\n");
}
if (!Strings.isNullOrEmpty(u)) {
html.append("<tr><th>URL</th><td>")
.append(String.format("<a href=\"%s\">%s</a>", u, u))
.append("</td></tr>\n");
}
if (!Strings.isNullOrEmpty(a)) {
html.append("<tr><th>API Version</th><td>")
.append(a)

3
gerrit-plugin-archetype/src/main/resources/META-INF/maven/archetype-metadata.xml
View File

@ -31,9 +31,6 @@ limitations under the License.
<requiredProperty key="Implementation-Vendor">
<defaultValue>Gerrit Code Review</defaultValue>
</requiredProperty>
<requiredProperty key="Implementation-Url">
<defaultValue>https://www.gerritcodereview.com/</defaultValue>
</requiredProperty>
<requiredProperty key="gerritApiType">
<defaultValue>plugin</defaultValue>

1
gerrit-plugin-archetype/src/main/resources/archetype-resources/pom.xml
View File

@ -50,7 +50,6 @@ limitations under the License.
#end
<Implementation-Vendor>${Implementation-Vendor}</Implementation-Vendor>
<Implementation-URL>${Implementation-Url}</Implementation-URL>
<Implementation-Title>${Gerrit-ApiType} ${project.artifactId}</Implementation-Title>
<Implementation-Version>${project.version}</Implementation-Version>

3
gerrit-plugin-gwt-archetype/src/main/resources/META-INF/maven/archetype-metadata.xml
View File

@ -21,9 +21,6 @@ limitations under the License.
<requiredProperty key="Implementation-Vendor">
<defaultValue>Gerrit Code Review</defaultValue>
</requiredProperty>
<requiredProperty key="Implementation-Url">
<defaultValue>https://www.gerritcodereview.com/</defaultValue>
</requiredProperty>
<requiredProperty key="Gwt-Version">
<defaultValue>2.7.0</defaultValue>
</requiredProperty>

1
gerrit-plugin-gwt-archetype/src/main/resources/archetype-resources/pom.xml
View File

@ -45,7 +45,6 @@ limitations under the License.
<Gerrit-Module>${package}.Module</Gerrit-Module>
<Gerrit-HttpModule>${package}.HttpModule</Gerrit-HttpModule>
<Implementation-Vendor>${Implementation-Vendor}</Implementation-Vendor>
<Implementation-URL>${Implementation-Url}</Implementation-URL>
<Implementation-Title>${Gerrit-ApiType} ${project.artifactId}</Implementation-Title>
<Implementation-Version>${project.version}</Implementation-Version>

3
gerrit-plugin-js-archetype/src/main/resources/META-INF/maven/archetype-metadata.xml
View File

@ -21,9 +21,6 @@ limitations under the License.
<requiredProperty key="Implementation-Vendor">
<defaultValue>Gerrit Code Review</defaultValue>
</requiredProperty>
<requiredProperty key="Implementation-Url">
<defaultValue>https://gerrit.googlesource.com/</defaultValue>
</requiredProperty>
<requiredProperty key="gerritApiType">
<defaultValue>js</defaultValue>

1
gerrit-plugin-js-archetype/src/main/resources/archetype-resources/pom.xml
View File

@ -44,7 +44,6 @@ limitations under the License.
<manifestEntries>
<Gerrit-PluginName>${pluginName}</Gerrit-PluginName>
<Implementation-Vendor>${Implementation-Vendor}</Implementation-Vendor>
<Implementation-URL>${Implementation-Url}</Implementation-URL>
<Implementation-Title>${Gerrit-ApiType} ${project.artifactId}</Implementation-Title>
<Implementation-Version>${project.version}</Implementation-Version>