opendev/gerrit
Code Issues Proposed changes

Move DestinationList to account package

Browse Source 
Only keep public the one method that is used outside the package.

Change-Id: I5a19a362dd77ac6bd3e129e55c50233a37aec3f1
This commit is contained in:
Dave Borowitz
2018-04-02 11:32:42 -04:00
parent aedd20f243
commit 087a14207f
3 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

162
javatests/com/google/gerrit/server/git/DestinationListTest.java
View File

@@ -1,162 +0,0 @@
// Copyright (C) 2015 The Android Open Source Project
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package com.google.gerrit.server.git;
import static com.google.common.truth.Truth.assertThat;
import static org.easymock.EasyMock.createNiceMock;
import static org.easymock.EasyMock.replay;
import com.google.gerrit.reviewdb.client.Branch;
import com.google.gerrit.reviewdb.client.Project;
import java.io.IOException;
import java.util.HashSet;
import java.util.Set;
import junit.framework.TestCase;
import org.junit.Test;
public class DestinationListTest extends TestCase {
public static final String R_FOO = "refs/heads/foo";
public static final String R_BAR = "refs/heads/bar";
public static final String P_MY = "myproject";
public static final String P_SLASH = "my/project/with/slashes";
public static final String P_COMPLEX = " a/project/with spaces and \ttabs ";
public static final String L_FOO = R_FOO + "\t" + P_MY + "\n";
public static final String L_BAR = R_BAR + "\t" + P_SLASH + "\n";
public static final String L_FOO_PAD_F = " " + R_FOO + "\t" + P_MY + "\n";
public static final String L_FOO_PAD_E = R_FOO + " \t" + P_MY + "\n";
public static final String L_COMPLEX = R_FOO + "\t" + P_COMPLEX + "\n";
public static final String L_BAD = R_FOO + "\n";
public static final String HEADER = "# Ref\tProject\n";
public static final String HEADER_PROPER = "# Ref \tProject\n";
public static final String C1 = "# A Simple Comment\n";
public static final String C2 = "# Comment with a tab\t and multi # # #\n";
public static final String F_SIMPLE = L_FOO + L_BAR;
public static final String F_PROPER = L_BAR + L_FOO; // alpha order
public static final String F_PAD_F = L_FOO_PAD_F + L_BAR;
public static final String F_PAD_E = L_FOO_PAD_E + L_BAR;
public static final String LABEL = "label";
public static final String LABEL2 = "another";
public static final Branch.NameKey B_FOO = dest(P_MY, R_FOO);
public static final Branch.NameKey B_BAR = dest(P_SLASH, R_BAR);
public static final Branch.NameKey B_COMPLEX = dest(P_COMPLEX, R_FOO);
public static final Set<Branch.NameKey> D_SIMPLE = new HashSet<>();
static {
D_SIMPLE.clear();
D_SIMPLE.add(B_FOO);
D_SIMPLE.add(B_BAR);
}
private static Branch.NameKey dest(String project, String ref) {
return new Branch.NameKey(new Project.NameKey(project), ref);
}
@Test
public void testParseSimple() throws Exception {
DestinationList dl = new DestinationList();
dl.parseLabel(LABEL, F_SIMPLE, null);
Set<Branch.NameKey> branches = dl.getDestinations(LABEL);
assertThat(branches).containsExactlyElementsIn(D_SIMPLE);
}
@Test
public void testParseWHeader() throws Exception {
DestinationList dl = new DestinationList();
dl.parseLabel(LABEL, HEADER + F_SIMPLE, null);
Set<Branch.NameKey> branches = dl.getDestinations(LABEL);
assertThat(branches).containsExactlyElementsIn(D_SIMPLE);
}
@Test
public void testParseWComments() throws Exception {
DestinationList dl = new DestinationList();
dl.parseLabel(LABEL, C1 + F_SIMPLE + C2, null);
Set<Branch.NameKey> branches = dl.getDestinations(LABEL);
assertThat(branches).containsExactlyElementsIn(D_SIMPLE);
}
@Test
public void testParseFooComment() throws Exception {
DestinationList dl = new DestinationList();
dl.parseLabel(LABEL, "#" + L_FOO + L_BAR, null);
Set<Branch.NameKey> branches = dl.getDestinations(LABEL);
assertThat(branches).doesNotContain(B_FOO);
assertThat(branches).contains(B_BAR);
}
@Test
public void testParsePaddedFronts() throws Exception {
DestinationList dl = new DestinationList();
dl.parseLabel(LABEL, F_PAD_F, null);
Set<Branch.NameKey> branches = dl.getDestinations(LABEL);
assertThat(branches).containsExactlyElementsIn(D_SIMPLE);
}
@Test
public void testParsePaddedEnds() throws Exception {
DestinationList dl = new DestinationList();
dl.parseLabel(LABEL, F_PAD_E, null);
Set<Branch.NameKey> branches = dl.getDestinations(LABEL);
assertThat(branches).containsExactlyElementsIn(D_SIMPLE);
}
@Test
public void testParseComplex() throws Exception {
DestinationList dl = new DestinationList();
dl.parseLabel(LABEL, L_COMPLEX, null);
Set<Branch.NameKey> branches = dl.getDestinations(LABEL);
assertThat(branches).contains(B_COMPLEX);
}
@Test(expected = IOException.class)
public void testParseBad() throws IOException {
ValidationError.Sink sink = createNiceMock(ValidationError.Sink.class);
replay(sink);
new DestinationList().parseLabel(LABEL, L_BAD, sink);
}
@Test
public void testParse2Labels() throws Exception {
DestinationList dl = new DestinationList();
dl.parseLabel(LABEL, F_SIMPLE, null);
Set<Branch.NameKey> branches = dl.getDestinations(LABEL);
assertThat(branches).containsExactlyElementsIn(D_SIMPLE);
dl.parseLabel(LABEL2, L_COMPLEX, null);
branches = dl.getDestinations(LABEL);
assertThat(branches).containsExactlyElementsIn(D_SIMPLE);
branches = dl.getDestinations(LABEL2);
assertThat(branches).contains(B_COMPLEX);
}
@Test
public void testAsText() throws Exception {
String text = HEADER_PROPER + "#\n" + F_PROPER;
DestinationList dl = new DestinationList();
dl.parseLabel(LABEL, F_SIMPLE, null);
String asText = dl.asText(LABEL);
assertThat(text).isEqualTo(asText);
dl.parseLabel(LABEL2, asText, null);
assertThat(text).isEqualTo(dl.asText(LABEL2));
}
}