opendev/gerrit
Code Issues Proposed changes

Merge "New review UI: Fix display of large avatar image in user popup panel" into stable-2.9

Browse Source
This commit is contained in:
Martin Fick
2014-05-20 23:13:34 +00:00
committed by Gerrit Code Review
parent 809835a62b f712cdb27c
commit 0980f9bdb4
1 changed files with 20 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
gerrit-gwtui/src/main/java/com/google/gerrit/client/AvatarImage.java
View File

@@ -80,8 +80,17 @@ public class AvatarImage extends Image implements LoadHandler {
setHeight(info.height() > 0 ? info.height() + "px" : ""); setHeight(info.height() > 0 ? info.height() + "px" : "");
setUrl(info.url()); setUrl(info.url());
popup(account, addPopup); popup(account, addPopup);
} else if (account.email() != null) {
loadAvatar(account, size, addPopup);
} }
} else if (account.email() != null) { } else if (account.email() != null) {
loadAvatar(account, size, addPopup);
} else {
setVisible(false);
}
}
private void loadAvatar(AccountInfo account, int size, boolean addPopup) {
// TODO Kill /accounts/*/avatar URL. // TODO Kill /accounts/*/avatar URL.
String u = account.email(); String u = account.email();
if (Gerrit.isSignedIn() if (Gerrit.isSignedIn()
@@ -96,9 +105,6 @@ public class AvatarImage extends Image implements LoadHandler {
setVisible(false); setVisible(false);
setUrl(api.url()); setUrl(api.url());
popup(account, addPopup); popup(account, addPopup);
} else {
setVisible(false);
}
} }
private void popup(AccountInfo account, boolean addPopup) { private void popup(AccountInfo account, boolean addPopup) {