opendev/gerrit
Code Issues Proposed changes

Fix compiler warnings about missing switch cases for AuthType

Browse Source 
As in 272d5c9 add explicit case statements to silence the
compiler warnings.

Change-Id: I37323409ea793eacd8249d4e9f477a66ef927049
This commit is contained in:
David Pursehouse
2012-12-03 11:17:34 +09:00
parent ec32548cdc
commit 09cca313d2
3 changed files with 33 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
gerrit-gwtui/src/main/java/com/google/gerrit/client/account/MyIdentitiesScreen.java
View File

@@ -72,6 +72,16 @@ public class MyIdentitiesScreen extends SettingsScreen {
add(linkIdentity); add(linkIdentity);
break; break;
} }
case CLIENT_SSL_CERT_LDAP:
case CUSTOM_EXTENSION:
case DEVELOPMENT_BECOME_ANY_ACCOUNT:
case HTTP:
case HTTP_LDAP:
case LDAP:
case LDAP_BIND:
case OPENID_SSO:
break;
} }
} }

6
gerrit-httpd/src/main/java/com/google/gerrit/httpd/GerritConfigProvider.java
View File

@@ -107,6 +107,12 @@ class GerritConfigProvider implements Provider<GerritConfig> {
config.setEditFullNameUrl(cfg.getString("auth", null, "editFullNameUrl")); config.setEditFullNameUrl(cfg.getString("auth", null, "editFullNameUrl"));
config.setHttpPasswordUrl(cfg.getString("auth", null, "httpPasswordUrl")); config.setHttpPasswordUrl(cfg.getString("auth", null, "httpPasswordUrl"));
break; break;
case CLIENT_SSL_CERT_LDAP:
case DEVELOPMENT_BECOME_ANY_ACCOUNT:
case HTTP:
case HTTP_LDAP:
break;
} }
config.setUseContributorAgreements(cfg.getBoolean("auth", config.setUseContributorAgreements(cfg.getBoolean("auth",
"contributoragreements", false)); "contributoragreements", false));

17
gerrit-pgm/src/main/java/com/google/gerrit/pgm/init/InitAuth.java
View File

@@ -54,6 +54,15 @@ class InitAuth implements InitStep {
auth.string("SSO logout URL", "logoutUrl", null); auth.string("SSO logout URL", "logoutUrl", null);
break; break;
} }
case CLIENT_SSL_CERT_LDAP:
case CUSTOM_EXTENSION:
case DEVELOPMENT_BECOME_ANY_ACCOUNT:
case LDAP:
case LDAP_BIND:
case OPENID:
case OPENID_SSO:
break;
} }
switch (auth_type) { switch (auth_type) {
@@ -80,6 +89,14 @@ class InitAuth implements InitStep {
ldap.string("Group BaseDN", "groupBase", aBase); ldap.string("Group BaseDN", "groupBase", aBase);
break; break;
} }
case CLIENT_SSL_CERT_LDAP:
case CUSTOM_EXTENSION:
case DEVELOPMENT_BECOME_ANY_ACCOUNT:
case HTTP:
case OPENID:
case OPENID_SSO:
break;
} }
if (auth.getSecure("registerEmailPrivateKey") == null) { if (auth.getSecure("registerEmailPrivateKey") == null) {