From e54139e9c1326fd0ab8ad906ac51817fa4de8bd8 Mon Sep 17 00:00:00 2001
From: Urs Wolfer <uwolfer@fwo.ch>
Date: Sun, 2 Jul 2017 16:33:04 +0200
Subject: [PATCH 1/2] Add missing exception declarations on methods in
 NotImplemented

When exception declarations are missing in NotImplemented,
classes extending NotImplemented cannot use these exceptions
in their method signatures.

Change-Id: I947483f04f2794780486eefcf3788524139bd817
---
 .../extensions/api/changes/ChangeEditApi.java | 26 +++++++++----------
 .../extensions/api/projects/ProjectApi.java   |  2 +-
 2 files changed, 14 insertions(+), 14 deletions(-)

diff --git a/gerrit-extension-api/src/main/java/com/google/gerrit/extensions/api/changes/ChangeEditApi.java b/gerrit-extension-api/src/main/java/com/google/gerrit/extensions/api/changes/ChangeEditApi.java
index 33f17e9903..9d0275ac19 100644
--- a/gerrit-extension-api/src/main/java/com/google/gerrit/extensions/api/changes/ChangeEditApi.java
+++ b/gerrit-extension-api/src/main/java/com/google/gerrit/extensions/api/changes/ChangeEditApi.java
@@ -156,67 +156,67 @@ public interface ChangeEditApi {
    */
   class NotImplemented implements ChangeEditApi {
     @Override
-    public Optional<EditInfo> get() {
+    public Optional<EditInfo> get() throws RestApiException {
       throw new NotImplementedException();
     }
 
     @Override
-    public void create() {
+    public void create() throws RestApiException {
       throw new NotImplementedException();
     }
 
     @Override
-    public void delete() {
+    public void delete() throws RestApiException {
       throw new NotImplementedException();
     }
 
     @Override
-    public void rebase() {
+    public void rebase() throws RestApiException {
       throw new NotImplementedException();
     }
 
     @Override
-    public void publish() {
+    public void publish() throws RestApiException {
       throw new NotImplementedException();
     }
 
     @Override
-    public void publish(PublishChangeEditInput publishChangeEditInput) {
+    public void publish(PublishChangeEditInput publishChangeEditInput) throws RestApiException {
       throw new NotImplementedException();
     }
 
     @Override
-    public Optional<BinaryResult> getFile(String filePath) {
+    public Optional<BinaryResult> getFile(String filePath) throws RestApiException {
       throw new NotImplementedException();
     }
 
     @Override
-    public void renameFile(String oldFilePath, String newFilePath) {
+    public void renameFile(String oldFilePath, String newFilePath) throws RestApiException {
       throw new NotImplementedException();
     }
 
     @Override
-    public void restoreFile(String filePath) {
+    public void restoreFile(String filePath) throws RestApiException {
       throw new NotImplementedException();
     }
 
     @Override
-    public void modifyFile(String filePath, RawInput newContent) {
+    public void modifyFile(String filePath, RawInput newContent) throws RestApiException {
       throw new NotImplementedException();
     }
 
     @Override
-    public void deleteFile(String filePath) {
+    public void deleteFile(String filePath) throws RestApiException {
       throw new NotImplementedException();
     }
 
     @Override
-    public String getCommitMessage() {
+    public String getCommitMessage() throws RestApiException {
       throw new NotImplementedException();
     }
 
     @Override
-    public void modifyCommitMessage(String newCommitMessage) {
+    public void modifyCommitMessage(String newCommitMessage) throws RestApiException {
       throw new NotImplementedException();
     }
   }
diff --git a/gerrit-extension-api/src/main/java/com/google/gerrit/extensions/api/projects/ProjectApi.java b/gerrit-extension-api/src/main/java/com/google/gerrit/extensions/api/projects/ProjectApi.java
index d53e096f43..a5221b996b 100644
--- a/gerrit-extension-api/src/main/java/com/google/gerrit/extensions/api/projects/ProjectApi.java
+++ b/gerrit-extension-api/src/main/java/com/google/gerrit/extensions/api/projects/ProjectApi.java
@@ -185,7 +185,7 @@ public interface ProjectApi {
     }
 
     @Override
-    public List<ProjectInfo> children() {
+    public List<ProjectInfo> children() throws RestApiException {
       throw new NotImplementedException();
     }
 

From d9d3135df96140d24819a4c2d31cd681c858e527 Mon Sep 17 00:00:00 2001
From: David Pursehouse <dpursehouse@collab.net>
Date: Mon, 3 Jul 2017 10:48:23 +0900
Subject: [PATCH 2/2] EditPreferencesBox: Format with google-java-format

Change-Id: I57769ebf80ae85f09f1a8f3f2e243e7c790ad24c
---
 .../java/com/google/gerrit/client/editor/EditPreferencesBox.java | 1 -
 1 file changed, 1 deletion(-)

diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/editor/EditPreferencesBox.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/editor/EditPreferencesBox.java
index 328c3a0d2a..6ef71e6eab 100644
--- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/editor/EditPreferencesBox.java
+++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/editor/EditPreferencesBox.java
@@ -225,7 +225,6 @@ public class EditPreferencesBox extends Composite {
     }
   }
 
-
   @UiHandler("autoCloseBrackets")
   void onCloseBrackets(ValueChangeEvent<Boolean> e) {
     prefs.autoCloseBrackets(e.getValue());