opendev/gerrit
Code Issues Proposed changes

Bazel: Move PLUGIN_DEPS_NEVERLINK declaration to plugin.bzl

Browse Source 
PLUGIN_DEPS is already correctly defined in plugin.bzl, but the
corresponding neverlik constant PLUGIN_DEPS_NEVERLINK is erroneously
defined in gwt.bzl.

This is a preparation change for removing of GWT UI, and removing of
gwt.bzl.

Change-Id: I2bd96c7217554afe5835e031f939660a365f43ac
This commit is contained in:
David Ostrovsky 2017-07-30 12:08:04 +02:00
parent 68c14fc93b
commit 0c25f8c4f6
2 changed files with 1 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
tools/bzl/gwt.bzl
View File

@ -52,10 +52,6 @@ GWT_COMPILER_ARGS_RELEASE_MODE = GWT_COMPILER_ARGS + [
"-XdisableCastChecking", "-XdisableCastChecking",
] ]
PLUGIN_DEPS_NEVERLINK = [
"//gerrit-plugin-api:lib-neverlink",
]
GWT_PLUGIN_DEPS_NEVERLINK = [ GWT_PLUGIN_DEPS_NEVERLINK = [
"//gerrit-plugin-gwtui:gwtui-api-lib-neverlink", "//gerrit-plugin-gwtui:gwtui-api-lib-neverlink",
"//lib/gwt:user-neverlink", "//lib/gwt:user-neverlink",

2
tools/bzl/plugin.bzl
View File

@ -5,12 +5,12 @@ load(
"GWT_PLUGIN_DEPS_NEVERLINK", "GWT_PLUGIN_DEPS_NEVERLINK",
"GWT_TRANSITIVE_DEPS", "GWT_TRANSITIVE_DEPS",
"GWT_COMPILER_ARGS", "GWT_COMPILER_ARGS",
"PLUGIN_DEPS_NEVERLINK",
"GWT_JVM_ARGS", "GWT_JVM_ARGS",
"gwt_binary", "gwt_binary",
) )
PLUGIN_DEPS = ["//gerrit-plugin-api:lib"] PLUGIN_DEPS = ["//gerrit-plugin-api:lib"]
PLUGIN_DEPS_NEVERLINK = ["//gerrit-plugin-api:lib-neverlink"]
PLUGIN_TEST_DEPS = [ PLUGIN_TEST_DEPS = [
"//gerrit-acceptance-framework:lib", "//gerrit-acceptance-framework:lib",