opendev/gerrit
Code Issues Proposed changes

QueryDocumentationExecutor: Remove TODO about paging doc searches

Browse Source 
It's not likely that we will have so much documentation that it
will be necessary to page the results. Just remove the TODO.

Change-Id: I972521a3c6167a2deb8716713771c2775ea18d54
This commit is contained in:
David Pursehouse
2019-10-12 20:01:16 +09:00
parent 3513f1f3a8
commit 0c72c393d1
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
java/com/google/gerrit/server/documentation/QueryDocumentationExecutor.java
View File

@@ -81,8 +81,7 @@ public class QueryDocumentationExecutor {
} }
Query query = parser.parse(q); Query query = parser.parse(q);
try { try {
// TODO(fishywang): Currently as we don't have much documentation, we just use MAX_VALUE here // We don't have much documentation, so we just use MAX_VALUE here and skip paging.
// and skipped paging. Maybe add paging later.
TopDocs results = searcher.search(query, Integer.MAX_VALUE); TopDocs results = searcher.search(query, Integer.MAX_VALUE);
ScoreDoc[] hits = results.scoreDocs; ScoreDoc[] hits = results.scoreDocs;
long totalHits = results.totalHits; long totalHits = results.totalHits;