opendev/gerrit
Code Issues Proposed changes

Fix NullPointerException in delete-vote REST API

Browse Source 
Fix the code which caused the NullPointerException.

The commit which broke this:
https://gerrit-review.googlesource.com/#/c/93482/

Change-Id: Iedda3900396cd33f7dc40acac47968f493d13e3c
This commit is contained in:
Changcheng Xiao
2017-01-12 11:39:06 +01:00
parent 6c5fa05cdd
commit 0c811c3e6e
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
gerrit-server/src/main/java/com/google/gerrit/server/change/Votes.java
View File

@@ -59,11 +59,11 @@ public class Votes implements ChildCollection<ReviewerResource, VoteResource> {
public VoteResource parse(ReviewerResource reviewer, IdString id) public VoteResource parse(ReviewerResource reviewer, IdString id)
throws ResourceNotFoundException, OrmException, AuthException, throws ResourceNotFoundException, OrmException, AuthException,
MethodNotAllowedException { MethodNotAllowedException {
if (!reviewer.getRevisionResource().isCurrent()) { if (reviewer.getRevisionResource() != null
&& !reviewer.getRevisionResource().isCurrent()) {
throw new MethodNotAllowedException( throw new MethodNotAllowedException(
"Cannot access on non-current patch set"); "Cannot access on non-current patch set");
} }
return new VoteResource(reviewer, id.get()); return new VoteResource(reviewer, id.get());
} }