opendev/gerrit
Code Issues Proposed changes

Use full name for refName RefUpdateAttribute

Browse Source 
RefUpdated events have an attribute called refName. EventFactory would
create this attribute using the short name, which is inconsistent
since all other events use full ref names. Create the event with the
full ref name.

Change-Id: I45dc114f48b801d0e5c9877c30e0526b8ecb8adb
This commit is contained in:
Janice Agustin 2015-05-15 10:17:08 -04:00
parent 7d21256dd3
commit 0d74afe186
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Documentation/json.txt
View File

@ -156,7 +156,7 @@ oldRev:: The old value of the ref, prior to the update.
newRev:: The new value the ref was updated to.
refName:: Ref name within project.
refName:: Full ref name within project.
project:: Project path in Gerrit.

2
gerrit-server/src/main/java/com/google/gerrit/server/events/EventFactory.java
View File

@ -151,7 +151,7 @@ public class EventFactory {
ru.newRev = newId != null ? newId.getName() : ObjectId.zeroId().getName();
ru.oldRev = oldId != null ? oldId.getName() : ObjectId.zeroId().getName();
ru.project = refName.getParentKey().get();
ru.refName = refName.getShortName();
ru.refName = refName.get();
return ru;
}