opendev/gerrit
Code Issues Proposed changes

Merge "Make start method in PluginLogFile thread safe"

Browse Source
This commit is contained in:
Prudhvi Akhil Alahari
2020-11-04 15:58:53 +00:00
committed by Gerrit Code Review
parent 384210c351 00e340cb43
commit 0dba35abd0
1 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
java/com/google/gerrit/server/util/PluginLogFile.java
View File

@@ -40,8 +40,13 @@ public abstract class PluginLogFile implements LifecycleListener {
public void start() { public void start() {
AsyncAppender asyncAppender = systemLog.createAsyncAppender(logName, layout, true, true); AsyncAppender asyncAppender = systemLog.createAsyncAppender(logName, layout, true, true);
Logger logger = LogManager.getLogger(logName); Logger logger = LogManager.getLogger(logName);
logger.removeAppender(logName); if (logger.getAppender(logName) == null) {
logger.addAppender(asyncAppender); synchronized (this) {
if (logger.getAppender(logName) == null) {
logger.addAppender(asyncAppender);
}
}
}
logger.setAdditivity(false); logger.setAdditivity(false);
} }