opendev/gerrit
Code Issues Proposed changes

Fix plural counts by selecting en_US as the default locale

Browse Source 
We only have translations for the messages in English, but to
make the @PluralCount code kick in right for even that language
we must set our local to some form of English and provide some
translation files for that language.

Signed-off-by: Shawn O. Pearce <sop@google.com>
This commit is contained in:
Shawn O. Pearce
2009-01-16 10:44:24 -08:00
parent cf9e4e763e
commit 0de7e5e56b
6 changed files with 9 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
appjar/src/main/java/com/google/gerrit/Gerrit.gwt.xml
View File

@@ -3,10 +3,8 @@
<inherits name='com.google.gwt.i18n.I18N'/> <inherits name='com.google.gwt.i18n.I18N'/>
<inherits name='com.google.gwtjsonrpc.GWTJSONRPC'/> <inherits name='com.google.gwtjsonrpc.GWTJSONRPC'/>
<inherits name='com.google.gwtorm.GWTORM'/> <inherits name='com.google.gwtorm.GWTORM'/>
<inherits name='com.google.gwt.user.theme.chrome.Chrome'/> <inherits name='com.google.gwt.user.theme.chrome.Chrome'/>
<!-- <inherits name='com.google.gwt.user.theme.standard.Standard'/> --> <extend-property name="locale" values="en"/>
<!-- <inherits name='com.google.gwt.user.theme.dark.Dark'/> -->
<!-- openid.AllowFrameImpl --> <!-- openid.AllowFrameImpl -->
<replace-with class="com.google.gerrit.client.openid.AllowFrameImpl"> <replace-with class="com.google.gerrit.client.openid.AllowFrameImpl">

3
appjar/src/main/java/com/google/gerrit/client/changes/ChangeMessages.properties
View File

@@ -7,10 +7,7 @@ patchSetHeader = Patch Set {0}
patchSetAction = {0} Patch Set {1} patchSetAction = {0} Patch Set {1}
repoDownload = repo download {0} {1}/{2} repoDownload = repo download {0} {1}/{2}
patchTableComments[one] = 1 comment
patchTableComments = {0} comments patchTableComments = {0} comments
patchTableDrafts[one] = 1 draft
patchTableDrafts = {0} drafts patchTableDrafts = {0} drafts
messageWrittenOn = on {0} messageWrittenOn = on {0}

5
appjar/src/main/java/com/google/gerrit/client/changes/ChangeMessages_en.properties Normal file
View File

@@ -0,0 +1,5 @@
patchTableComments[one] = 1 comment
patchTableComments = {0} comments
patchTableDrafts[one] = 1 draft
patchTableDrafts = {0} drafts

1
appjar/src/main/java/com/google/gerrit/client/patches/PatchMessages.properties
View File

@@ -1,6 +1,5 @@
patchHeaderAncestor = Ancestor {0} patchHeaderAncestor = Ancestor {0}
patchSkipRegion[one] = (... skipping 1 common line ...)
patchSkipRegion = (...skipping {0} common lines ...) patchSkipRegion = (...skipping {0} common lines ...)
draftSaved = Draft saved at {0,time,short} draftSaved = Draft saved at {0,time,short}

2
appjar/src/main/java/com/google/gerrit/client/patches/PatchMessages_en.properties Normal file
View File

@@ -0,0 +1,2 @@
patchSkipRegion[one] = (... skipping 1 common line ...)
patchSkipRegion = (...skipping {0} common lines ...)

1
appjar/src/main/java/com/google/gerrit/public/Gerrit.html
View File

@@ -1,6 +1,7 @@
<html> <html>
<head> <head>
<title>Gerrit Code Review</title> <title>Gerrit Code Review</title>
<meta name="gwt:property" content="locale=en_US" />
<script id="gerrit_gerritconfig"></script> <script id="gerrit_gerritconfig"></script>
<script type="text/javascript" language="javascript" src="com.google.gerrit.Gerrit.nocache.js"></script> <script type="text/javascript" language="javascript" src="com.google.gerrit.Gerrit.nocache.js"></script>
<style type="text/css" id="gerrit_sitecss"></style> <style type="text/css" id="gerrit_sitecss"></style>