opendev/gerrit
Code Issues Proposed changes

Rename PatchSetApproval methods

Browse Source 
Remove the "get" prefix on AutoValue getters. Also remove the "is" in
"isPostSubmit", which AutoValue treats the same as "get"; note how the
method on the Builder class was already required to be named postSubmit.

Change-Id: Ic2f6fe9b7195bcec9b021d65eb3ca6c9f74f0c45
This commit is contained in:
Dave Borowitz
2019-05-01 09:16:33 -07:00
parent bbbcc59d7e
commit 0e0c999911
46 changed files with 311 additions and 316 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
java/com/google/gerrit/server/git/MergeUtil.java
View File

@@ -522,7 +522,7 @@ public class MergeUtil {
PatchSetApproval submitAudit = null;
for (PatchSetApproval a : safeGetApprovals(notes, psId)) {
if (a.getValue() <= 0) {
if (a.value() <= 0) {
// Negative votes aren't counted.
continue;
}
@@ -530,13 +530,13 @@ public class MergeUtil {
if (a.isLegacySubmit()) {
// Submit is treated specially, below (becomes committer)
//
if (submitAudit == null || a.getGranted().compareTo(submitAudit.getGranted()) > 0) {
if (submitAudit == null || a.granted().compareTo(submitAudit.granted()) > 0) {
submitAudit = a;
}
continue;
}
final Account acc = identifiedUserFactory.create(a.getAccountId()).getAccount();
final Account acc = identifiedUserFactory.create(a.accountId()).getAccount();
final StringBuilder identbuf = new StringBuilder();
if (acc.getFullName() != null && acc.getFullName().length() > 0) {
if (identbuf.length() > 0) {
@@ -561,12 +561,12 @@ public class MergeUtil {
}
final String tag;
if (isCodeReview(a.getLabelId())) {
if (isCodeReview(a.labelId())) {
tag = "Reviewed-by";
} else if (isVerified(a.getLabelId())) {
} else if (isVerified(a.labelId())) {
tag = "Tested-by";
} else {
final LabelType lt = project.getLabelTypes().byLabel(a.getLabelId());
final LabelType lt = project.getLabelTypes().byLabel(a.labelId());
if (lt == null) {
continue;
}