opendev/gerrit
Code Issues Proposed changes

Merge "Move doRefUpdatedHook to validateForReceiveCommits"

Browse Source
This commit is contained in:
Martin Fick
2015-11-12 18:08:32 +00:00
committed by Gerrit Code Review
parent 7afd302052 535cd5e0ac
commit 0e8001305e
2 changed files with 1 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
gerrit-server/src/main/java/com/google/gerrit/server/git/ReceiveCommits.java
View File

@@ -897,19 +897,6 @@ public class ReceiveCommits {
continue;
}
HookResult result = hooks.doRefUpdateHook(project, cmd.getRefName(),
user.getAccount(), cmd.getOldId(),
cmd.getNewId());
if (result != null) {
final String message = result.toString().trim();
if (result.getExitValue() != 0) {
reject(cmd, message);
continue;
}
rp.sendMessage(message);
}
if (MagicBranch.isMagicBranch(cmd.getRefName())) {
parseMagicBranch(cmd);
continue;

1
gerrit-server/src/main/java/com/google/gerrit/server/git/validators/CommitValidators.java
View File

@@ -131,6 +131,7 @@ public class CommitValidators {
validators.add(new ConfigValidator(refControl, repo));
validators.add(new BannedCommitsValidator(rejectCommits));
validators.add(new PluginCommitValidationListener(commitValidationListeners));
validators.add(new ChangeHookValidator(refControl, hooks));
List<CommitValidationMessage> messages = new LinkedList<>();