opendev/gerrit
Code Issues Proposed changes

Prevent possible NPE in AuthorRevision.equals

Browse Source 
Add check for the given object being an instance of the
expected class.

This clears a warning from Findbugs.

Change-Id: I097f8894239f04804a0038b504eccd8e2374b07a
This commit is contained in:
David Pursehouse
2013-12-16 14:15:20 +09:00
parent d26a0a26a5
commit 0ee2e98606
1 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
gerrit-gwtui/src/main/java/com/google/gerrit/client/change/History.java
View File

@@ -210,6 +210,9 @@ class History extends FlowPanel {
@Override @Override
public boolean equals(Object o) { public boolean equals(Object o) {
if (!(o instanceof AuthorRevision)) {
return false;
}
AuthorRevision b = (AuthorRevision) o; AuthorRevision b = (AuthorRevision) o;
return author == b.author && revision == b.revision; return author == b.author && revision == b.revision;
} }