opendev/gerrit
Code Issues Proposed changes

TestSubmitType: Enable logErrors when debug logging is enabled

Browse Source 
Change-Id: Ib46367271496bb35e702b6400e988b3095c190f1
This commit is contained in:
David Pursehouse
2020-06-18 15:53:30 +09:00
parent a414e5b82d
commit 0eec00fd58
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
java/com/google/gerrit/server/restapi/change/TestSubmitType.java
View File

@@ -15,6 +15,7 @@
package com.google.gerrit.server.restapi.change; package com.google.gerrit.server.restapi.change;
import com.google.common.base.MoreObjects; import com.google.common.base.MoreObjects;
import com.google.common.flogger.FluentLogger;
import com.google.gerrit.common.data.SubmitTypeRecord; import com.google.gerrit.common.data.SubmitTypeRecord;
import com.google.gerrit.extensions.client.SubmitType; import com.google.gerrit.extensions.client.SubmitType;
import com.google.gerrit.extensions.common.TestSubmitRuleInput; import com.google.gerrit.extensions.common.TestSubmitRuleInput;
@@ -35,6 +36,8 @@ import com.google.inject.Provider;
import org.kohsuke.args4j.Option; import org.kohsuke.args4j.Option;
public class TestSubmitType implements RestModifyView<RevisionResource, TestSubmitRuleInput> { public class TestSubmitType implements RestModifyView<RevisionResource, TestSubmitRuleInput> {
private static final FluentLogger logger = FluentLogger.forEnclosingClass();
private final Provider<ReviewDb> db; private final Provider<ReviewDb> db;
private final ChangeData.Factory changeDataFactory; private final ChangeData.Factory changeDataFactory;
private final RulesCache rules; private final RulesCache rules;
@@ -68,7 +71,7 @@ public class TestSubmitType implements RestModifyView<RevisionResource, TestSubm
SubmitRuleOptions opts = SubmitRuleOptions opts =
SubmitRuleOptions.builder() SubmitRuleOptions.builder()
.logErrors(false) .logErrors(logger.atFine().isEnabled())
.skipFilters(input.filters == Filters.SKIP) .skipFilters(input.filters == Filters.SKIP)
.rule(input.rule) .rule(input.rule)
.build(); .build();