opendev/gerrit
Code Issues Proposed changes

Fix print out of warning if file of change index version is not a directory

Browse Source 
The condition to print out the warning 'exists && !f.isDirectory()'
could never be true since 'exists' was only true if 'f.isDirectory()':
  boolean exists = f.exists() && f.isDirectory()

Change-Id: I93f7b140c05e43e5af4a3083f69e913ecf8f6a84
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
This commit is contained in:
Edwin Kempin
2013-08-20 10:59:39 +02:00
parent c14aaf915d
commit 0eeee76dc6
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gerrit-lucene/src/main/java/com/google/gerrit/lucene/LuceneVersionManager.java
View File

@@ -162,7 +162,7 @@ class LuceneVersionManager implements LifecycleListener {
for (Schema<ChangeData> schema : ChangeSchemas.ALL.values()) {
File f = getDir(sitePaths, schema);
boolean exists = f.exists() && f.isDirectory();
if (exists && !f.isDirectory()) {
if (f.exists() && !f.isDirectory()) {
log.warn("Not a directory: %s", f.getAbsolutePath());
}
int v = schema.getVersion();