From 0ef04fcf7ad02c60b47e125d716ed384dc8a0fc5 Mon Sep 17 00:00:00 2001 From: Edwin Kempin Date: Mon, 11 Dec 2017 10:48:45 +0100 Subject: [PATCH] AbstractQueryChangesTest: Make dashboard constants final The field names are CONSTANT_CASE, but the fields were not static and final. Change-Id: If7b6171b11caf0249d91f52465444d7b981ea13d Signed-off-by: Edwin Kempin --- .../server/query/change/AbstractQueryChangesTest.java | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/javatests/com/google/gerrit/server/query/change/AbstractQueryChangesTest.java b/javatests/com/google/gerrit/server/query/change/AbstractQueryChangesTest.java index cfd59c01b6..49a7e3ec32 100644 --- a/javatests/com/google/gerrit/server/query/change/AbstractQueryChangesTest.java +++ b/javatests/com/google/gerrit/server/query/change/AbstractQueryChangesTest.java @@ -188,11 +188,12 @@ public abstract class AbstractQueryChangesTest extends GerritServerTests { // These queries must be kept in sync with PolyGerrit: // polygerrit-ui/app/elements/change-list/gr-dashboard-view/gr-dashboard-view.js - protected static String DASHBOARD_WORK_IN_PROGRESS_QUERY = "is:open owner:${user} is:wip"; - protected static String DASHBOARD_OUTGOING_QUERY = "is:open owner:${user} -is:wip -is:ignored"; - protected static String DASHBOARD_INCOMING_QUERY = + protected static final String DASHBOARD_WORK_IN_PROGRESS_QUERY = "is:open owner:${user} is:wip"; + protected static final String DASHBOARD_OUTGOING_QUERY = + "is:open owner:${user} -is:wip -is:ignored"; + protected static final String DASHBOARD_INCOMING_QUERY = "is:open -owner:${user} -is:wip -is:ignored (reviewer:${user} OR assignee:${user})"; - protected static String DASHBOARD_RECENTLY_CLOSED_QUERY = + protected static final String DASHBOARD_RECENTLY_CLOSED_QUERY = "is:closed -is:ignored (-is:wip OR owner:self) " + "(owner:${user} OR reviewer:${user} OR assignee:${user})";