opendev/gerrit
Code Issues Proposed changes

Fix compiler warnings in gwtexpui

Browse Source 
- Add missing serialVersionUID in serializable class.

- Remove unnecessary @SuppressWarning("unchecked") annotations.

- Add type argument to prevent "References to generic type Artifact<C>
should be parameterized".

Change-Id: I65ba9a98b44e765854ae142bf7bd2b97132a0773
This commit is contained in:
David Pursehouse 2013-04-11 10:03:16 +09:00
parent 7f53c5696f
commit 0f2e820677
2 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
gerrit-gwtexpui/src/main/java/com/google/gwtexpui/css/rebind/CssLinker.java
View File

@ -38,7 +38,6 @@ public class CssLinker extends AbstractLinker {
return "CssLinker";
}
@SuppressWarnings("unchecked")
@Override
public ArtifactSet link(final TreeLogger logger, final LinkerContext context,
final ArtifactSet artifacts) throws UnableToCompleteException {
@ -59,7 +58,7 @@ public class CssLinker extends AbstractLinker {
}
}
for (Artifact a : artifacts) {
for (Artifact<?> a : artifacts) {
if (a instanceof PublicResource) {
final PublicResource r = (PublicResource) a;
if (css.containsKey(r.getPartialPath())) {
@ -109,6 +108,7 @@ public class CssLinker extends AbstractLinker {
}
private static class CssPubRsrc extends PublicResource {
private static final long serialVersionUID = 1L;
private final PublicResource src;
CssPubRsrc(final String partialPath, final PublicResource r) {

1
gerrit-gwtexpui/src/main/java/com/google/gwtexpui/linker/rebind/ServerPlannedIFrameLinker.java
View File

@ -35,7 +35,6 @@ public class ServerPlannedIFrameLinker extends AbstractLinker {
return "ServerPlannedIFrameLinker";
}
@SuppressWarnings("unchecked")
@Override
public ArtifactSet link(final TreeLogger logger, final LinkerContext context,
final ArtifactSet artifacts) throws UnableToCompleteException {