diff --git a/polygerrit-ui/app/elements/change-list/gr-change-list-item/gr-change-list-item.ts b/polygerrit-ui/app/elements/change-list/gr-change-list-item/gr-change-list-item.ts index d70e8910a0..64342f47d0 100644 --- a/polygerrit-ui/app/elements/change-list/gr-change-list-item/gr-change-list-item.ts +++ b/polygerrit-ui/app/elements/change-list/gr-change-list-item/gr-change-list-item.ts @@ -152,15 +152,19 @@ export class GrChangeListItem extends ChangeTableMixin( if (!label || category === LabelCategory.NOT_APPLICABLE) { return 'Label not applicable'; } + const titleParts: string[] = []; if (category === LabelCategory.UNRESOLVED_COMMENTS) { const num = change?.unresolved_comment_count ?? 0; const plural = num > 1 ? 's' : ''; - return `${num} unresolved comment${plural}`; + titleParts.push(`${num} unresolved comment${plural}`); } const significantLabel = label.rejected || label.approved || label.disliked || label.recommended; - if (significantLabel && significantLabel.name) { - return `${labelName}\nby ${significantLabel.name}`; + if (significantLabel?.name) { + titleParts.push(`${labelName} by ${significantLabel.name}`); + } + if (titleParts.length > 0) { + return titleParts.join(',\n'); } return labelName; } diff --git a/polygerrit-ui/app/elements/change-list/gr-change-list-item/gr-change-list-item_test.js b/polygerrit-ui/app/elements/change-list/gr-change-list-item/gr-change-list-item_test.js index d3274f33bd..38cc7727f8 100644 --- a/polygerrit-ui/app/elements/change-list/gr-change-list-item/gr-change-list-item_test.js +++ b/polygerrit-ui/app/elements/change-list/gr-change-list-item/gr-change-list-item_test.js @@ -88,41 +88,47 @@ suite('gr-change-list-item tests', () => { 'Label not applicable'); assert.equal(element._computeLabelTitle( {labels: {Verified: {approved: {name: 'Diffy'}}}}, 'Verified'), - 'Verified\nby Diffy'); + 'Verified by Diffy'); assert.equal(element._computeLabelTitle( {labels: {Verified: {approved: {name: 'Diffy'}}}}, 'Code-Review'), 'Label not applicable'); assert.equal(element._computeLabelTitle( {labels: {Verified: {rejected: {name: 'Diffy'}}}}, 'Verified'), - 'Verified\nby Diffy'); + 'Verified by Diffy'); assert.equal(element._computeLabelTitle( {labels: {'Code-Review': {disliked: {name: 'Diffy'}, value: -1}}}, - 'Code-Review'), 'Code-Review\nby Diffy'); + 'Code-Review'), 'Code-Review by Diffy'); assert.equal(element._computeLabelTitle( {labels: {'Code-Review': {recommended: {name: 'Diffy'}, value: 1}}}, - 'Code-Review'), 'Code-Review\nby Diffy'); + 'Code-Review'), 'Code-Review by Diffy'); assert.equal(element._computeLabelTitle( {labels: {'Code-Review': {recommended: {name: 'Diffy'}, rejected: {name: 'Admin'}}}}, 'Code-Review'), - 'Code-Review\nby Admin'); + 'Code-Review by Admin'); assert.equal(element._computeLabelTitle( {labels: {'Code-Review': {approved: {name: 'Diffy'}, rejected: {name: 'Admin'}}}}, 'Code-Review'), - 'Code-Review\nby Admin'); + 'Code-Review by Admin'); assert.equal(element._computeLabelTitle( {labels: {'Code-Review': {recommended: {name: 'Diffy'}, disliked: {name: 'Admin'}, value: -1}}}, 'Code-Review'), - 'Code-Review\nby Admin'); + 'Code-Review by Admin'); assert.equal(element._computeLabelTitle( {labels: {'Code-Review': {approved: {name: 'Diffy'}, disliked: {name: 'Admin'}, value: -1}}}, 'Code-Review'), - 'Code-Review\nby Diffy'); + 'Code-Review by Diffy'); assert.equal(element._computeLabelTitle( { labels: {'Code-Review': {approved: true, value: 1}}, unresolved_comment_count: 1, }, 'Code-Review'), '1 unresolved comment'); + assert.equal(element._computeLabelTitle( + { + labels: {'Code-Review': {approved: {name: 'Diffy'}, value: 1}}, + unresolved_comment_count: 1, + }, 'Code-Review'), + '1 unresolved comment,\nCode-Review by Diffy'); assert.equal(element._computeLabelTitle( { labels: {'Code-Review': {approved: true, value: 1}},