opendev/gerrit
Code Issues Proposed changes

Add another two test cases to define ACL behavior

Browse Source 
Change-Id: I620473c10aebb67e9354cc9c659961ab92b2ddd3
This commit is contained in:
Han-Wen Nienhuys
2018-02-08 15:54:28 +01:00
committed by hanwen
parent f8c86b2e8b
commit 0f8251004a
1 changed files with 18 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
javatests/com/google/gerrit/server/permissions/RefControlTest.java
View File

@@ -670,6 +670,24 @@ public class RefControlTest {
assertCanUpdate("refs/heads/master", u); assertCanUpdate("refs/heads/master", u);
} }
@Test
public void unblockFromParentDoesNotAffectChild() {
allow(parent, PUSH, DEVS, "refs/heads/master", true);
block(local, PUSH, DEVS, "refs/heads/master");
ProjectControl u = user(local, DEVS);
assertCannotUpdate("refs/heads/master", u);
}
@Test
public void unblockFromParentDoesNotAffectChildDifferentGroups() {
allow(parent, PUSH, DEVS, "refs/heads/master", true);
block(local, PUSH, ANONYMOUS_USERS, "refs/heads/master");
ProjectControl u = user(local, DEVS);
assertCannotUpdate("refs/heads/master", u);
}
@Test @Test
public void unblockMoreSpecificRefInLocalWithExclusiveFlag_Fails() { public void unblockMoreSpecificRefInLocalWithExclusiveFlag_Fails() {
block(parent, PUSH, ANONYMOUS_USERS, "refs/heads/*"); block(parent, PUSH, ANONYMOUS_USERS, "refs/heads/*");