opendev/gerrit
Code Issues Proposed changes

Merge "CherryPick: Inline usage of ReviewDb to avoid resource warning"

Browse Source
This commit is contained in:
ekempin 2017-03-23 14:25:00 +00:00 committed by Gerrit Code Review
commit 0f839a42f8
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
gerrit-server/src/main/java/com/google/gerrit/server/change/CherryPick.java
View File

@ -66,9 +66,7 @@ public class CherryPick
throw new BadRequestException("destination must be non-empty"); throw new BadRequestException("destination must be non-empty");
} }
@SuppressWarnings("resource") if (!control.isVisible(dbProvider.get())) {
ReviewDb db = dbProvider.get();
if (!control.isVisible(db)) {
throw new AuthException("Cherry pick not permitted"); throw new AuthException("Cherry pick not permitted");
} }