Merge changes from topic 'checkstyle-cleanup'
* changes: Remove redundant modifiers from interfaces' methods Remove redundant 'final' modifier from private native methods Checkstyle config: Enable "redundant modifier" and "redundant import"
This commit is contained in:
		| @@ -32,7 +32,7 @@ public interface GerritApi { | |||||||
|    * A default implementation which allows source compatibility |    * A default implementation which allows source compatibility | ||||||
|    * when adding new methods to the interface. |    * when adding new methods to the interface. | ||||||
|    **/ |    **/ | ||||||
|   public class NotImplemented implements GerritApi { |   class NotImplemented implements GerritApi { | ||||||
|     @Override |     @Override | ||||||
|     public Accounts accounts() { |     public Accounts accounts() { | ||||||
|       throw new NotImplementedException(); |       throw new NotImplementedException(); | ||||||
|   | |||||||
| @@ -59,7 +59,7 @@ public interface AccountApi { | |||||||
|    * A default implementation which allows source compatibility |    * A default implementation which allows source compatibility | ||||||
|    * when adding new methods to the interface. |    * when adding new methods to the interface. | ||||||
|    **/ |    **/ | ||||||
|   public class NotImplemented implements AccountApi { |   class NotImplemented implements AccountApi { | ||||||
|     @Override |     @Override | ||||||
|     public AccountInfo get() throws RestApiException { |     public AccountInfo get() throws RestApiException { | ||||||
|       throw new NotImplementedException(); |       throw new NotImplementedException(); | ||||||
|   | |||||||
| @@ -75,7 +75,7 @@ public interface Accounts { | |||||||
|    * |    * | ||||||
|    * @see #suggestAccounts() |    * @see #suggestAccounts() | ||||||
|    */ |    */ | ||||||
|   public abstract class SuggestAccountsRequest { |   abstract class SuggestAccountsRequest { | ||||||
|     private String query; |     private String query; | ||||||
|     private int limit; |     private int limit; | ||||||
|  |  | ||||||
| @@ -116,7 +116,7 @@ public interface Accounts { | |||||||
|    * A default implementation which allows source compatibility |    * A default implementation which allows source compatibility | ||||||
|    * when adding new methods to the interface. |    * when adding new methods to the interface. | ||||||
|    **/ |    **/ | ||||||
|   public class NotImplemented implements Accounts { |   class NotImplemented implements Accounts { | ||||||
|     @Override |     @Override | ||||||
|     public AccountApi id(String id) throws RestApiException { |     public AccountApi id(String id) throws RestApiException { | ||||||
|       throw new NotImplementedException(); |       throw new NotImplementedException(); | ||||||
|   | |||||||
| @@ -26,7 +26,7 @@ public interface GpgKeyApi { | |||||||
|    * A default implementation which allows source compatibility |    * A default implementation which allows source compatibility | ||||||
|    * when adding new methods to the interface. |    * when adding new methods to the interface. | ||||||
|    */ |    */ | ||||||
|   public class NotImplemented implements GpgKeyApi { |   class NotImplemented implements GpgKeyApi { | ||||||
|     @Override |     @Override | ||||||
|     public GpgKeyInfo get() throws RestApiException { |     public GpgKeyInfo get() throws RestApiException { | ||||||
|       throw new NotImplementedException(); |       throw new NotImplementedException(); | ||||||
|   | |||||||
| @@ -157,7 +157,7 @@ public interface ChangeApi { | |||||||
|   ChangeInfo check() throws RestApiException; |   ChangeInfo check() throws RestApiException; | ||||||
|   ChangeInfo check(FixInput fix) throws RestApiException; |   ChangeInfo check(FixInput fix) throws RestApiException; | ||||||
|  |  | ||||||
|   public abstract class SuggestedReviewersRequest { |   abstract class SuggestedReviewersRequest { | ||||||
|     private String query; |     private String query; | ||||||
|     private int limit; |     private int limit; | ||||||
|  |  | ||||||
| @@ -186,7 +186,7 @@ public interface ChangeApi { | |||||||
|    * A default implementation which allows source compatibility |    * A default implementation which allows source compatibility | ||||||
|    * when adding new methods to the interface. |    * when adding new methods to the interface. | ||||||
|    **/ |    **/ | ||||||
|   public class NotImplemented implements ChangeApi { |   class NotImplemented implements ChangeApi { | ||||||
|     @Override |     @Override | ||||||
|     public String id() { |     public String id() { | ||||||
|       throw new NotImplementedException(); |       throw new NotImplementedException(); | ||||||
|   | |||||||
| @@ -64,7 +64,7 @@ public interface Changes { | |||||||
|   QueryRequest query(); |   QueryRequest query(); | ||||||
|   QueryRequest query(String query); |   QueryRequest query(String query); | ||||||
|  |  | ||||||
|   public abstract class QueryRequest { |   abstract class QueryRequest { | ||||||
|     private String query; |     private String query; | ||||||
|     private int limit; |     private int limit; | ||||||
|     private int start; |     private int start; | ||||||
| @@ -140,7 +140,7 @@ public interface Changes { | |||||||
|    * A default implementation which allows source compatibility |    * A default implementation which allows source compatibility | ||||||
|    * when adding new methods to the interface. |    * when adding new methods to the interface. | ||||||
|    **/ |    **/ | ||||||
|   public class NotImplemented implements Changes { |   class NotImplemented implements Changes { | ||||||
|     @Override |     @Override | ||||||
|     public ChangeApi id(int id) throws RestApiException { |     public ChangeApi id(int id) throws RestApiException { | ||||||
|       throw new NotImplementedException(); |       throw new NotImplementedException(); | ||||||
|   | |||||||
| @@ -25,7 +25,7 @@ public interface CommentApi { | |||||||
|    * A default implementation which allows source compatibility |    * A default implementation which allows source compatibility | ||||||
|    * when adding new methods to the interface. |    * when adding new methods to the interface. | ||||||
|    **/ |    **/ | ||||||
|   public class NotImplemented implements CommentApi { |   class NotImplemented implements CommentApi { | ||||||
|     @Override |     @Override | ||||||
|     public CommentInfo get() throws RestApiException { |     public CommentInfo get() throws RestApiException { | ||||||
|       throw new NotImplementedException(); |       throw new NotImplementedException(); | ||||||
|   | |||||||
| @@ -26,7 +26,7 @@ public interface DraftApi extends CommentApi { | |||||||
|    * A default implementation which allows source compatibility |    * A default implementation which allows source compatibility | ||||||
|    * when adding new methods to the interface. |    * when adding new methods to the interface. | ||||||
|    **/ |    **/ | ||||||
|   public class NotImplemented extends CommentApi.NotImplemented |   class NotImplemented extends CommentApi.NotImplemented | ||||||
|       implements DraftApi { |       implements DraftApi { | ||||||
|     @Override |     @Override | ||||||
|     public CommentInfo update(DraftInput in) throws RestApiException { |     public CommentInfo update(DraftInput in) throws RestApiException { | ||||||
|   | |||||||
| @@ -40,7 +40,7 @@ public interface FileApi { | |||||||
|    */ |    */ | ||||||
|   DiffRequest diffRequest() throws RestApiException; |   DiffRequest diffRequest() throws RestApiException; | ||||||
|  |  | ||||||
|   public abstract class DiffRequest { |   abstract class DiffRequest { | ||||||
|     private String base; |     private String base; | ||||||
|     private Integer context; |     private Integer context; | ||||||
|     private Boolean intraline; |     private Boolean intraline; | ||||||
| @@ -89,7 +89,7 @@ public interface FileApi { | |||||||
|    * A default implementation which allows source compatibility |    * A default implementation which allows source compatibility | ||||||
|    * when adding new methods to the interface. |    * when adding new methods to the interface. | ||||||
|    **/ |    **/ | ||||||
|   public class NotImplemented implements FileApi { |   class NotImplemented implements FileApi { | ||||||
|     @Override |     @Override | ||||||
|     public BinaryResult content() throws RestApiException { |     public BinaryResult content() throws RestApiException { | ||||||
|       throw new NotImplementedException(); |       throw new NotImplementedException(); | ||||||
|   | |||||||
| @@ -75,7 +75,7 @@ public interface RevisionApi { | |||||||
|    * A default implementation which allows source compatibility |    * A default implementation which allows source compatibility | ||||||
|    * when adding new methods to the interface. |    * when adding new methods to the interface. | ||||||
|    **/ |    **/ | ||||||
|   public class NotImplemented implements RevisionApi { |   class NotImplemented implements RevisionApi { | ||||||
|     @Override |     @Override | ||||||
|     public void delete() throws RestApiException { |     public void delete() throws RestApiException { | ||||||
|       throw new NotImplementedException(); |       throw new NotImplementedException(); | ||||||
|   | |||||||
| @@ -26,7 +26,7 @@ public interface Config { | |||||||
|    * A default implementation which allows source compatibility |    * A default implementation which allows source compatibility | ||||||
|    * when adding new methods to the interface. |    * when adding new methods to the interface. | ||||||
|    **/ |    **/ | ||||||
|   public class NotImplemented implements Config { |   class NotImplemented implements Config { | ||||||
|     @Override |     @Override | ||||||
|     public Server server() { |     public Server server() { | ||||||
|       throw new NotImplementedException(); |       throw new NotImplementedException(); | ||||||
|   | |||||||
| @@ -27,7 +27,7 @@ public interface Server { | |||||||
|    * A default implementation which allows source compatibility |    * A default implementation which allows source compatibility | ||||||
|    * when adding new methods to the interface. |    * when adding new methods to the interface. | ||||||
|    **/ |    **/ | ||||||
|   public class NotImplemented implements Server { |   class NotImplemented implements Server { | ||||||
|     @Override |     @Override | ||||||
|     public String getVersion() throws RestApiException { |     public String getVersion() throws RestApiException { | ||||||
|       throw new NotImplementedException(); |       throw new NotImplementedException(); | ||||||
|   | |||||||
| @@ -51,7 +51,7 @@ public interface Groups { | |||||||
|   /** @return new request for listing groups. */ |   /** @return new request for listing groups. */ | ||||||
|   ListRequest list(); |   ListRequest list(); | ||||||
|  |  | ||||||
|   public abstract class ListRequest { |   abstract class ListRequest { | ||||||
|     private final EnumSet<ListGroupsOption> options = |     private final EnumSet<ListGroupsOption> options = | ||||||
|         EnumSet.noneOf(ListGroupsOption.class); |         EnumSet.noneOf(ListGroupsOption.class); | ||||||
|     private final List<String> projects = new ArrayList<>(); |     private final List<String> projects = new ArrayList<>(); | ||||||
|   | |||||||
| @@ -34,7 +34,7 @@ public interface BranchApi { | |||||||
|    * A default implementation which allows source compatibility |    * A default implementation which allows source compatibility | ||||||
|    * when adding new methods to the interface. |    * when adding new methods to the interface. | ||||||
|    **/ |    **/ | ||||||
|   public class NotImplemented implements BranchApi { |   class NotImplemented implements BranchApi { | ||||||
|     @Override |     @Override | ||||||
|     public BranchApi create(BranchInput in) throws RestApiException { |     public BranchApi create(BranchInput in) throws RestApiException { | ||||||
|       throw new NotImplementedException(); |       throw new NotImplementedException(); | ||||||
|   | |||||||
| @@ -26,7 +26,7 @@ public interface ChildProjectApi { | |||||||
|    * A default implementation which allows source compatibility |    * A default implementation which allows source compatibility | ||||||
|    * when adding new methods to the interface. |    * when adding new methods to the interface. | ||||||
|    **/ |    **/ | ||||||
|   public class NotImplemented implements ChildProjectApi { |   class NotImplemented implements ChildProjectApi { | ||||||
|     @Override |     @Override | ||||||
|     public ProjectInfo get() throws RestApiException { |     public ProjectInfo get() throws RestApiException { | ||||||
|       throw new NotImplementedException(); |       throw new NotImplementedException(); | ||||||
|   | |||||||
| @@ -31,7 +31,7 @@ public interface ProjectApi { | |||||||
|   ListRefsRequest<BranchInfo> branches(); |   ListRefsRequest<BranchInfo> branches(); | ||||||
|   ListRefsRequest<TagInfo> tags(); |   ListRefsRequest<TagInfo> tags(); | ||||||
|  |  | ||||||
|   public abstract class ListRefsRequest<T extends RefInfo> { |   abstract class ListRefsRequest<T extends RefInfo> { | ||||||
|     protected int limit; |     protected int limit; | ||||||
|     protected int start; |     protected int start; | ||||||
|     protected String substring; |     protected String substring; | ||||||
| @@ -108,7 +108,7 @@ public interface ProjectApi { | |||||||
|    * A default implementation which allows source compatibility |    * A default implementation which allows source compatibility | ||||||
|    * when adding new methods to the interface. |    * when adding new methods to the interface. | ||||||
|    **/ |    **/ | ||||||
|   public class NotImplemented implements ProjectApi { |   class NotImplemented implements ProjectApi { | ||||||
|     @Override |     @Override | ||||||
|     public ProjectApi create() throws RestApiException { |     public ProjectApi create() throws RestApiException { | ||||||
|       throw new NotImplementedException(); |       throw new NotImplementedException(); | ||||||
|   | |||||||
| @@ -60,7 +60,7 @@ public interface Projects { | |||||||
|  |  | ||||||
|   ListRequest list(); |   ListRequest list(); | ||||||
|  |  | ||||||
|   public abstract class ListRequest { |   abstract class ListRequest { | ||||||
|     public enum FilterType { |     public enum FilterType { | ||||||
|       CODE, PARENT_CANDIDATES, PERMISSIONS, ALL |       CODE, PARENT_CANDIDATES, PERMISSIONS, ALL | ||||||
|     } |     } | ||||||
| @@ -175,7 +175,7 @@ public interface Projects { | |||||||
|    * A default implementation which allows source compatibility |    * A default implementation which allows source compatibility | ||||||
|    * when adding new methods to the interface. |    * when adding new methods to the interface. | ||||||
|    **/ |    **/ | ||||||
|   public class NotImplemented implements Projects { |   class NotImplemented implements Projects { | ||||||
|     @Override |     @Override | ||||||
|     public ProjectApi name(String name) throws RestApiException { |     public ProjectApi name(String name) throws RestApiException { | ||||||
|       throw new NotImplementedException(); |       throw new NotImplementedException(); | ||||||
|   | |||||||
| @@ -24,7 +24,7 @@ public interface TagApi { | |||||||
|    * A default implementation which allows source compatibility |    * A default implementation which allows source compatibility | ||||||
|    * when adding new methods to the interface. |    * when adding new methods to the interface. | ||||||
|    **/ |    **/ | ||||||
|   public class NotImplemented implements TagApi { |   class NotImplemented implements TagApi { | ||||||
|     @Override |     @Override | ||||||
|     public TagInfo get() throws RestApiException { |     public TagInfo get() throws RestApiException { | ||||||
|       throw new NotImplementedException(); |       throw new NotImplementedException(); | ||||||
|   | |||||||
| @@ -17,7 +17,7 @@ package com.google.gerrit.extensions.systemstatus; | |||||||
| /** Exports current server information to an extension. */ | /** Exports current server information to an extension. */ | ||||||
| public interface ServerInformation { | public interface ServerInformation { | ||||||
|   /** Current state of the server. */ |   /** Current state of the server. */ | ||||||
|   public enum State { |   enum State { | ||||||
|     /** |     /** | ||||||
|      * The server is starting up, and network connections are not yet being |      * The server is starting up, and network connections are not yet being | ||||||
|      * accepted. Plugins or extensions starting during this time are starting |      * accepted. Plugins or extensions starting during this time are starting | ||||||
|   | |||||||
| @@ -22,7 +22,7 @@ import java.util.List; | |||||||
|  |  | ||||||
| @ExtensionPoint | @ExtensionPoint | ||||||
| public interface TopMenu { | public interface TopMenu { | ||||||
|   public class MenuEntry { |   class MenuEntry { | ||||||
|     public final String name; |     public final String name; | ||||||
|     public final List<MenuItem> items; |     public final List<MenuItem> items; | ||||||
|  |  | ||||||
|   | |||||||
| @@ -32,7 +32,7 @@ public interface UiAction<R extends RestResource> extends RestView<R> { | |||||||
|   Description getDescription(R resource); |   Description getDescription(R resource); | ||||||
|  |  | ||||||
|   /** Describes an action invokable through the web interface. */ |   /** Describes an action invokable through the web interface. */ | ||||||
|   public static class Description { |   class Description { | ||||||
|     private String method; |     private String method; | ||||||
|     private String id; |     private String id; | ||||||
|     private String label; |     private String label; | ||||||
|   | |||||||
| @@ -24,7 +24,7 @@ public interface WebLink { | |||||||
|   /** |   /** | ||||||
|    * Class that holds target defaults for WebLink anchors. |    * Class that holds target defaults for WebLink anchors. | ||||||
|    */ |    */ | ||||||
|   public static class Target { |   class Target { | ||||||
|     /** |     /** | ||||||
|      * Opens the link in a new window or tab |      * Opens the link in a new window or tab | ||||||
|      */ |      */ | ||||||
|   | |||||||
| @@ -21,7 +21,7 @@ import com.google.gwt.resources.client.DataResource.DoNotEmbed; | |||||||
| import com.google.gwt.resources.client.ImageResource; | import com.google.gwt.resources.client.ImageResource; | ||||||
|  |  | ||||||
| public interface ClippyResources extends ClientBundle { | public interface ClippyResources extends ClientBundle { | ||||||
|   public static final ClippyResources I = GWT.create(ClippyResources.class); |   ClippyResources I = GWT.create(ClippyResources.class); | ||||||
|  |  | ||||||
|   @Source("clippy.css") |   @Source("clippy.css") | ||||||
|   ClippyCss css(); |   ClippyCss css(); | ||||||
|   | |||||||
| @@ -18,7 +18,7 @@ import com.google.gwt.core.client.GWT; | |||||||
| import com.google.gwt.i18n.client.Constants; | import com.google.gwt.i18n.client.Constants; | ||||||
|  |  | ||||||
| interface CopyableLabelText extends Constants { | interface CopyableLabelText extends Constants { | ||||||
|   final CopyableLabelText I = GWT.create(CopyableLabelText.class); |   CopyableLabelText I = GWT.create(CopyableLabelText.class); | ||||||
|  |  | ||||||
|   String tooltip(); |   String tooltip(); | ||||||
|   String copied(); |   String copied(); | ||||||
|   | |||||||
| @@ -18,7 +18,7 @@ import com.google.gwt.core.client.GWT; | |||||||
| import com.google.gwt.i18n.client.Constants; | import com.google.gwt.i18n.client.Constants; | ||||||
|  |  | ||||||
| public interface KeyConstants extends Constants { | public interface KeyConstants extends Constants { | ||||||
|   public static final KeyConstants I = GWT.create(KeyConstants.class); |   KeyConstants I = GWT.create(KeyConstants.class); | ||||||
|  |  | ||||||
|   String applicationSection(); |   String applicationSection(); | ||||||
|   String showHelp(); |   String showHelp(); | ||||||
|   | |||||||
| @@ -18,7 +18,7 @@ import com.google.gwt.core.client.GWT; | |||||||
| import com.google.gwt.resources.client.ClientBundle; | import com.google.gwt.resources.client.ClientBundle; | ||||||
|  |  | ||||||
| public interface KeyResources extends ClientBundle { | public interface KeyResources extends ClientBundle { | ||||||
|   public static final KeyResources I = GWT.create(KeyResources.class); |   KeyResources I = GWT.create(KeyResources.class); | ||||||
|  |  | ||||||
|   @Source("key.css") |   @Source("key.css") | ||||||
|   KeyCss css(); |   KeyCss css(); | ||||||
|   | |||||||
| @@ -18,7 +18,7 @@ import com.google.gwt.core.client.GWT; | |||||||
| import com.google.gwt.resources.client.ClientBundle; | import com.google.gwt.resources.client.ClientBundle; | ||||||
|  |  | ||||||
| public interface ProgressResources extends ClientBundle { | public interface ProgressResources extends ClientBundle { | ||||||
|   public static final ProgressResources I = GWT.create(ProgressResources.class); |   ProgressResources I = GWT.create(ProgressResources.class); | ||||||
|  |  | ||||||
|   @Source("progress.css") |   @Source("progress.css") | ||||||
|   ProgressCss css(); |   ProgressCss css(); | ||||||
|   | |||||||
| @@ -23,7 +23,7 @@ import com.google.gwt.user.client.ui.UIObject; | |||||||
| /** Displays custom tooltip message below an element. */ | /** Displays custom tooltip message below an element. */ | ||||||
| public class Tooltip { | public class Tooltip { | ||||||
|   interface Resources extends ClientBundle { |   interface Resources extends ClientBundle { | ||||||
|     final Resources I = GWT.create(Resources.class); |     Resources I = GWT.create(Resources.class); | ||||||
|  |  | ||||||
|     @Source("tooltip.css") |     @Source("tooltip.css") | ||||||
|     Css css(); |     Css css(); | ||||||
|   | |||||||
| @@ -18,7 +18,7 @@ import com.google.gwt.core.client.GWT; | |||||||
| import com.google.gwt.i18n.client.Constants; | import com.google.gwt.i18n.client.Constants; | ||||||
|  |  | ||||||
| public interface CommonConstants extends Constants { | public interface CommonConstants extends Constants { | ||||||
|   public static final CommonConstants C = GWT.create(CommonConstants.class); |   CommonConstants C = GWT.create(CommonConstants.class); | ||||||
|  |  | ||||||
|   String inTheFuture(); |   String inTheFuture(); | ||||||
|   String month(); |   String month(); | ||||||
|   | |||||||
| @@ -18,7 +18,7 @@ import com.google.gwt.core.client.GWT; | |||||||
| import com.google.gwt.i18n.client.Messages; | import com.google.gwt.i18n.client.Messages; | ||||||
|  |  | ||||||
| public interface CommonMessages extends Messages { | public interface CommonMessages extends Messages { | ||||||
|   public static final CommonMessages M = GWT.create(CommonMessages.class); |   CommonMessages M = GWT.create(CommonMessages.class); | ||||||
|  |  | ||||||
|   String secondsAgo(long seconds); |   String secondsAgo(long seconds); | ||||||
|   String minutesAgo(long minutes); |   String minutesAgo(long minutes); | ||||||
|   | |||||||
| @@ -40,9 +40,9 @@ public class AccountInfo extends JavaScriptObject { | |||||||
|     return ts; |     return ts; | ||||||
|   } |   } | ||||||
|  |  | ||||||
|   private final native String registeredOnRaw() /*-{ return this.registered_on; }-*/; |   private native String registeredOnRaw() /*-{ return this.registered_on; }-*/; | ||||||
|   private final native Timestamp _getRegisteredOn() /*-{ return this._cts; }-*/; |   private native Timestamp _getRegisteredOn() /*-{ return this._cts; }-*/; | ||||||
|   private final native void _setRegisteredOn(Timestamp ts) /*-{ this._cts = ts; }-*/; |   private native void _setRegisteredOn(Timestamp ts) /*-{ this._cts = ts; }-*/; | ||||||
|  |  | ||||||
|   /** |   /** | ||||||
|    * @return true if the server supplied avatar information about this account. |    * @return true if the server supplied avatar information about this account. | ||||||
| @@ -64,7 +64,7 @@ public class AccountInfo extends JavaScriptObject { | |||||||
|     return null; |     return null; | ||||||
|   } |   } | ||||||
|  |  | ||||||
|   private final native JsArray<AvatarInfo> avatars() |   private native JsArray<AvatarInfo> avatars() | ||||||
|   /*-{ return this.avatars }-*/; |   /*-{ return this.avatars }-*/; | ||||||
|  |  | ||||||
|   public final native void name(String n) /*-{ this.name = n }-*/; |   public final native void name(String n) /*-{ this.name = n }-*/; | ||||||
|   | |||||||
| @@ -90,8 +90,8 @@ public class AuthInfo extends JavaScriptObject { | |||||||
|   public final native String editFullNameUrl() /*-{ return this.edit_full_name_url; }-*/; |   public final native String editFullNameUrl() /*-{ return this.edit_full_name_url; }-*/; | ||||||
|   public final native String httpPasswordUrl() /*-{ return this.http_password_url; }-*/; |   public final native String httpPasswordUrl() /*-{ return this.http_password_url; }-*/; | ||||||
|   public final native boolean isGitBasicAuth() /*-{ return this.is_git_basic_auth || false; }-*/; |   public final native boolean isGitBasicAuth() /*-{ return this.is_git_basic_auth || false; }-*/; | ||||||
|   private final native String authTypeRaw() /*-{ return this.auth_type; }-*/; |   private native String authTypeRaw() /*-{ return this.auth_type; }-*/; | ||||||
|   private final native JsArrayString _editableAccountFields() |   private native JsArrayString _editableAccountFields() | ||||||
|   /*-{ return this.editable_account_fields; }-*/; |   /*-{ return this.editable_account_fields; }-*/; | ||||||
|  |  | ||||||
|   protected AuthInfo() { |   protected AuthInfo() { | ||||||
|   | |||||||
| @@ -71,8 +71,8 @@ public class ChangeInfo extends JavaScriptObject { | |||||||
|     return revList.get(revList.length() - 1).isEdit(); |     return revList.get(revList.length() - 1).isEdit(); | ||||||
|   } |   } | ||||||
|  |  | ||||||
|   private final native Timestamp _getCts() /*-{ return this._cts; }-*/; |   private native Timestamp _getCts() /*-{ return this._cts; }-*/; | ||||||
|   private final native void _setCts(Timestamp ts) /*-{ this._cts = ts; }-*/; |   private native void _setCts(Timestamp ts) /*-{ this._cts = ts; }-*/; | ||||||
|  |  | ||||||
|   public final Timestamp updated() { |   public final Timestamp updated() { | ||||||
|     return JavaSqlTimestamp_JsonSerializer.parseTimestamp(updatedRaw()); |     return JavaSqlTimestamp_JsonSerializer.parseTimestamp(updatedRaw()); | ||||||
| @@ -112,12 +112,12 @@ public class ChangeInfo extends JavaScriptObject { | |||||||
|   public final native boolean mergeable() /*-{ return this.mergeable ? true : false; }-*/; |   public final native boolean mergeable() /*-{ return this.mergeable ? true : false; }-*/; | ||||||
|   public final native int insertions() /*-{ return this.insertions; }-*/; |   public final native int insertions() /*-{ return this.insertions; }-*/; | ||||||
|   public final native int deletions() /*-{ return this.deletions; }-*/; |   public final native int deletions() /*-{ return this.deletions; }-*/; | ||||||
|   private final native String statusRaw() /*-{ return this.status; }-*/; |   private native String statusRaw() /*-{ return this.status; }-*/; | ||||||
|   public final native String subject() /*-{ return this.subject; }-*/; |   public final native String subject() /*-{ return this.subject; }-*/; | ||||||
|   public final native AccountInfo owner() /*-{ return this.owner; }-*/; |   public final native AccountInfo owner() /*-{ return this.owner; }-*/; | ||||||
|   private final native String createdRaw() /*-{ return this.created; }-*/; |   private native String createdRaw() /*-{ return this.created; }-*/; | ||||||
|   private final native String updatedRaw() /*-{ return this.updated; }-*/; |   private native String updatedRaw() /*-{ return this.updated; }-*/; | ||||||
|   private final native String submittedRaw() /*-{ return this.submitted; }-*/; |   private native String submittedRaw() /*-{ return this.submitted; }-*/; | ||||||
|   public final native boolean starred() /*-{ return this.starred ? true : false; }-*/; |   public final native boolean starred() /*-{ return this.starred ? true : false; }-*/; | ||||||
|   public final native boolean reviewed() /*-{ return this.reviewed ? true : false; }-*/; |   public final native boolean reviewed() /*-{ return this.reviewed ? true : false; }-*/; | ||||||
|   public final native NativeMap<LabelInfo> allLabels() /*-{ return this.labels; }-*/; |   public final native NativeMap<LabelInfo> allLabels() /*-{ return this.labels; }-*/; | ||||||
| @@ -142,7 +142,7 @@ public class ChangeInfo extends JavaScriptObject { | |||||||
|   public final native JsArray<AccountInfo> removableReviewers() |   public final native JsArray<AccountInfo> removableReviewers() | ||||||
|   /*-{ return this.removable_reviewers; }-*/; |   /*-{ return this.removable_reviewers; }-*/; | ||||||
|  |  | ||||||
|   private final native NativeMap<JsArray<AccountInfo>> _reviewers() |   private native NativeMap<JsArray<AccountInfo>> _reviewers() | ||||||
|   /*-{ return this.reviewers; }-*/; |   /*-{ return this.reviewers; }-*/; | ||||||
|   public final Map<ReviewerState, List<AccountInfo>> reviewers() { |   public final Map<ReviewerState, List<AccountInfo>> reviewers() { | ||||||
|     NativeMap<JsArray<AccountInfo>> reviewers = _reviewers(); |     NativeMap<JsArray<AccountInfo>> reviewers = _reviewers(); | ||||||
| @@ -173,14 +173,14 @@ public class ChangeInfo extends JavaScriptObject { | |||||||
|     } |     } | ||||||
|     return SubmitType.valueOf(submitType); |     return SubmitType.valueOf(submitType); | ||||||
|   } |   } | ||||||
|   private final native String _submitType() /*-{ return this.submit_type; }-*/; |   private native String _submitType() /*-{ return this.submit_type; }-*/; | ||||||
|  |  | ||||||
|   public final boolean submittable() { |   public final boolean submittable() { | ||||||
|     init(); |     init(); | ||||||
|     return _submittable(); |     return _submittable(); | ||||||
|   } |   } | ||||||
|  |  | ||||||
|   private final native boolean _submittable() |   private native boolean _submittable() | ||||||
|   /*-{ return this.submittable ? true : false; }-*/; |   /*-{ return this.submittable ? true : false; }-*/; | ||||||
|  |  | ||||||
|   /** |   /** | ||||||
| @@ -259,7 +259,7 @@ public class ChangeInfo extends JavaScriptObject { | |||||||
|       return null; |       return null; | ||||||
|     } |     } | ||||||
|  |  | ||||||
|     private final native NativeMap<NativeString> _values() /*-{ return this.values; }-*/; |     private native NativeMap<NativeString> _values() /*-{ return this.values; }-*/; | ||||||
|     public final Set<String> values() { |     public final Set<String> values() { | ||||||
|       return Natives.keys(_values()); |       return Natives.keys(_values()); | ||||||
|     } |     } | ||||||
| @@ -334,7 +334,7 @@ public class ChangeInfo extends JavaScriptObject { | |||||||
|       revisionInfo.takeFromEdit(edit); |       revisionInfo.takeFromEdit(edit); | ||||||
|       return revisionInfo; |       return revisionInfo; | ||||||
|     } |     } | ||||||
|     private final native void takeFromEdit(EditInfo edit) /*-{ |     private native void takeFromEdit(EditInfo edit) /*-{ | ||||||
|       this._number = 0; |       this._number = 0; | ||||||
|       this.name = edit.name; |       this.name = edit.name; | ||||||
|       this.commit = edit.commit; |       this.commit = edit.commit; | ||||||
| @@ -435,7 +435,7 @@ public class ChangeInfo extends JavaScriptObject { | |||||||
|   public static class GitPerson extends JavaScriptObject { |   public static class GitPerson extends JavaScriptObject { | ||||||
|     public final native String name() /*-{ return this.name; }-*/; |     public final native String name() /*-{ return this.name; }-*/; | ||||||
|     public final native String email() /*-{ return this.email; }-*/; |     public final native String email() /*-{ return this.email; }-*/; | ||||||
|     private final native String dateRaw() /*-{ return this.date; }-*/; |     private native String dateRaw() /*-{ return this.date; }-*/; | ||||||
|  |  | ||||||
|     public final Timestamp date() { |     public final Timestamp date() { | ||||||
|       return JavaSqlTimestamp_JsonSerializer.parseTimestamp(dateRaw()); |       return JavaSqlTimestamp_JsonSerializer.parseTimestamp(dateRaw()); | ||||||
| @@ -449,7 +449,7 @@ public class ChangeInfo extends JavaScriptObject { | |||||||
|     public final native AccountInfo author() /*-{ return this.author; }-*/; |     public final native AccountInfo author() /*-{ return this.author; }-*/; | ||||||
|     public final native String message() /*-{ return this.message; }-*/; |     public final native String message() /*-{ return this.message; }-*/; | ||||||
|     public final native int _revisionNumber() /*-{ return this._revision_number || 0; }-*/; |     public final native int _revisionNumber() /*-{ return this._revision_number || 0; }-*/; | ||||||
|     private final native String dateRaw() /*-{ return this.date; }-*/; |     private native String dateRaw() /*-{ return this.date; }-*/; | ||||||
|  |  | ||||||
|     public final Timestamp date() { |     public final Timestamp date() { | ||||||
|       return JavaSqlTimestamp_JsonSerializer.parseTimestamp(dateRaw()); |       return JavaSqlTimestamp_JsonSerializer.parseTimestamp(dateRaw()); | ||||||
| @@ -475,7 +475,7 @@ public class ChangeInfo extends JavaScriptObject { | |||||||
|     public final native JsArrayString branches() /*-{ return this.branches; }-*/; |     public final native JsArrayString branches() /*-{ return this.branches; }-*/; | ||||||
|     public final native JsArrayString tags() /*-{ return this.tags; }-*/; |     public final native JsArrayString tags() /*-{ return this.tags; }-*/; | ||||||
|     public final native JsArrayString external(String n) /*-{ return this.external[n]; }-*/; |     public final native JsArrayString external(String n) /*-{ return this.external[n]; }-*/; | ||||||
|     private final native NativeMap<JsArrayString> external() /*-{ return this.external; }-*/; |     private native NativeMap<JsArrayString> external() /*-{ return this.external; }-*/; | ||||||
|  |  | ||||||
|     protected IncludedInInfo() { |     protected IncludedInInfo() { | ||||||
|     } |     } | ||||||
|   | |||||||
| @@ -39,8 +39,8 @@ public class DownloadInfo extends JavaScriptObject { | |||||||
|   } |   } | ||||||
|  |  | ||||||
|   public final native DownloadSchemeInfo scheme(String n) /*-{ return this.schemes[n]; }-*/; |   public final native DownloadSchemeInfo scheme(String n) /*-{ return this.schemes[n]; }-*/; | ||||||
|   private final native NativeMap<DownloadSchemeInfo> _schemes() /*-{ return this.schemes; }-*/; |   private native NativeMap<DownloadSchemeInfo> _schemes() /*-{ return this.schemes; }-*/; | ||||||
|   private final native JsArrayString _archives() /*-{ return this.archives; }-*/; |   private native JsArrayString _archives() /*-{ return this.archives; }-*/; | ||||||
|  |  | ||||||
|   protected DownloadInfo() { |   protected DownloadInfo() { | ||||||
|   } |   } | ||||||
| @@ -96,8 +96,8 @@ public class DownloadInfo extends JavaScriptObject { | |||||||
|     public final native boolean isAuthSupported() /*-{ return this.is_auth_supported || false; }-*/; |     public final native boolean isAuthSupported() /*-{ return this.is_auth_supported || false; }-*/; | ||||||
|     public final native String command(String n) /*-{ return this.commands[n]; }-*/; |     public final native String command(String n) /*-{ return this.commands[n]; }-*/; | ||||||
|     public final native String cloneCommand(String n) /*-{ return this.clone_commands[n]; }-*/; |     public final native String cloneCommand(String n) /*-{ return this.clone_commands[n]; }-*/; | ||||||
|     private final native NativeMap<NativeString> _commands() /*-{ return this.commands; }-*/; |     private native NativeMap<NativeString> _commands() /*-{ return this.commands; }-*/; | ||||||
|     private final native NativeMap<NativeString> _cloneCommands() /*-{ return this.clone_commands; }-*/; |     private native NativeMap<NativeString> _cloneCommands() /*-{ return this.clone_commands; }-*/; | ||||||
|  |  | ||||||
|     protected DownloadSchemeInfo() { |     protected DownloadSchemeInfo() { | ||||||
|     } |     } | ||||||
|   | |||||||
| @@ -37,12 +37,12 @@ public class FileInfo extends JavaScriptObject { | |||||||
|   public final long size() { |   public final long size() { | ||||||
|     return (long)_size(); |     return (long)_size(); | ||||||
|   } |   } | ||||||
|   private final native double _size() /*-{ return this.size || 0; }-*/; |   private native double _size() /*-{ return this.size || 0; }-*/; | ||||||
|  |  | ||||||
|   public final long sizeDelta() { |   public final long sizeDelta() { | ||||||
|     return (long)_sizeDelta(); |     return (long)_sizeDelta(); | ||||||
|   } |   } | ||||||
|   private final native double _sizeDelta() /*-{ return this.size_delta || 0; }-*/; |   private native double _sizeDelta() /*-{ return this.size_delta || 0; }-*/; | ||||||
|  |  | ||||||
|   public final native int _row() /*-{ return this._row }-*/; |   public final native int _row() /*-{ return this._row }-*/; | ||||||
|   public final native void _row(int r) /*-{ this._row = r }-*/; |   public final native void _row(int r) /*-{ this._row = r }-*/; | ||||||
|   | |||||||
| @@ -65,7 +65,7 @@ public class GeneralPreferences extends JavaScriptObject { | |||||||
|         ? changesPerPage |         ? changesPerPage | ||||||
|         : GeneralPreferencesInfo.DEFAULT_PAGESIZE; |         : GeneralPreferencesInfo.DEFAULT_PAGESIZE; | ||||||
|   } |   } | ||||||
|   private final native short get(String n, int d) |   private native short get(String n, int d) | ||||||
|   /*-{ return this.hasOwnProperty(n) ? this[n] : d }-*/; |   /*-{ return this.hasOwnProperty(n) ? this[n] : d }-*/; | ||||||
|  |  | ||||||
|   public final native boolean showSiteHeader() |   public final native boolean showSiteHeader() | ||||||
| @@ -81,21 +81,21 @@ public class GeneralPreferences extends JavaScriptObject { | |||||||
|     String s = downloadCommandRaw(); |     String s = downloadCommandRaw(); | ||||||
|     return s != null ? DownloadCommand.valueOf(s) : null; |     return s != null ? DownloadCommand.valueOf(s) : null; | ||||||
|   } |   } | ||||||
|   private final native String downloadCommandRaw() |   private native String downloadCommandRaw() | ||||||
|   /*-{ return this.download_command }-*/; |   /*-{ return this.download_command }-*/; | ||||||
|  |  | ||||||
|   public final DateFormat dateFormat() { |   public final DateFormat dateFormat() { | ||||||
|     String s = dateFormatRaw(); |     String s = dateFormatRaw(); | ||||||
|     return s != null ? DateFormat.valueOf(s) : null; |     return s != null ? DateFormat.valueOf(s) : null; | ||||||
|   } |   } | ||||||
|   private final native String dateFormatRaw() |   private native String dateFormatRaw() | ||||||
|   /*-{ return this.date_format }-*/; |   /*-{ return this.date_format }-*/; | ||||||
|  |  | ||||||
|   public final TimeFormat timeFormat() { |   public final TimeFormat timeFormat() { | ||||||
|     String s = timeFormatRaw(); |     String s = timeFormatRaw(); | ||||||
|     return s != null ? TimeFormat.valueOf(s) : null; |     return s != null ? TimeFormat.valueOf(s) : null; | ||||||
|   } |   } | ||||||
|   private final native String timeFormatRaw() |   private native String timeFormatRaw() | ||||||
|   /*-{ return this.time_format }-*/; |   /*-{ return this.time_format }-*/; | ||||||
|  |  | ||||||
|   public final native boolean relativeDateInChangeTable() |   public final native boolean relativeDateInChangeTable() | ||||||
| @@ -117,14 +117,14 @@ public class GeneralPreferences extends JavaScriptObject { | |||||||
|     String s = reviewCategeoryStrategyRaw(); |     String s = reviewCategeoryStrategyRaw(); | ||||||
|     return s != null ? ReviewCategoryStrategy.valueOf(s) : ReviewCategoryStrategy.NONE; |     return s != null ? ReviewCategoryStrategy.valueOf(s) : ReviewCategoryStrategy.NONE; | ||||||
|   } |   } | ||||||
|   private final native String reviewCategeoryStrategyRaw() |   private native String reviewCategeoryStrategyRaw() | ||||||
|   /*-{ return this.review_category_strategy }-*/; |   /*-{ return this.review_category_strategy }-*/; | ||||||
|  |  | ||||||
|   public final DiffView diffView() { |   public final DiffView diffView() { | ||||||
|     String s = diffViewRaw(); |     String s = diffViewRaw(); | ||||||
|     return s != null ? DiffView.valueOf(s) : null; |     return s != null ? DiffView.valueOf(s) : null; | ||||||
|   } |   } | ||||||
|   private final native String diffViewRaw() |   private native String diffViewRaw() | ||||||
|   /*-{ return this.diff_view }-*/; |   /*-{ return this.diff_view }-*/; | ||||||
|  |  | ||||||
|   public final EmailStrategy emailStrategy() { |   public final EmailStrategy emailStrategy() { | ||||||
| @@ -132,7 +132,7 @@ public class GeneralPreferences extends JavaScriptObject { | |||||||
|     return s != null ? EmailStrategy.valueOf(s) : null; |     return s != null ? EmailStrategy.valueOf(s) : null; | ||||||
|   } |   } | ||||||
|  |  | ||||||
|   private final native String emailStrategyRaw() |   private native String emailStrategyRaw() | ||||||
|   /*-{ return this.email_strategy }-*/; |   /*-{ return this.email_strategy }-*/; | ||||||
|  |  | ||||||
|   public final native JsArray<TopMenuItem> my() |   public final native JsArray<TopMenuItem> my() | ||||||
| @@ -159,13 +159,13 @@ public class GeneralPreferences extends JavaScriptObject { | |||||||
|   public final void dateFormat(DateFormat f) { |   public final void dateFormat(DateFormat f) { | ||||||
|     dateFormatRaw(f != null ? f.toString() : null); |     dateFormatRaw(f != null ? f.toString() : null); | ||||||
|   } |   } | ||||||
|   private final native void dateFormatRaw(String f) |   private native void dateFormatRaw(String f) | ||||||
|   /*-{ this.date_format = f }-*/; |   /*-{ this.date_format = f }-*/; | ||||||
|  |  | ||||||
|   public final void timeFormat(TimeFormat f) { |   public final void timeFormat(TimeFormat f) { | ||||||
|     timeFormatRaw(f != null ? f.toString() : null); |     timeFormatRaw(f != null ? f.toString() : null); | ||||||
|   } |   } | ||||||
|   private final native void timeFormatRaw(String f) |   private native void timeFormatRaw(String f) | ||||||
|   /*-{ this.time_format = f }-*/; |   /*-{ this.time_format = f }-*/; | ||||||
|  |  | ||||||
|   public final native void relativeDateInChangeTable(boolean d) |   public final native void relativeDateInChangeTable(boolean d) | ||||||
| @@ -186,19 +186,19 @@ public class GeneralPreferences extends JavaScriptObject { | |||||||
|   public final void reviewCategoryStrategy(ReviewCategoryStrategy s) { |   public final void reviewCategoryStrategy(ReviewCategoryStrategy s) { | ||||||
|     reviewCategoryStrategyRaw(s != null ? s.toString() : null); |     reviewCategoryStrategyRaw(s != null ? s.toString() : null); | ||||||
|   } |   } | ||||||
|   private final native void reviewCategoryStrategyRaw(String s) |   private native void reviewCategoryStrategyRaw(String s) | ||||||
|   /*-{ this.review_category_strategy = s }-*/; |   /*-{ this.review_category_strategy = s }-*/; | ||||||
|  |  | ||||||
|   public final void diffView(DiffView d) { |   public final void diffView(DiffView d) { | ||||||
|     diffViewRaw(d != null ? d.toString() : null); |     diffViewRaw(d != null ? d.toString() : null); | ||||||
|   } |   } | ||||||
|   private final native void diffViewRaw(String d) |   private native void diffViewRaw(String d) | ||||||
|   /*-{ this.diff_view = d }-*/; |   /*-{ this.diff_view = d }-*/; | ||||||
|  |  | ||||||
|   public final void emailStrategy(EmailStrategy s) { |   public final void emailStrategy(EmailStrategy s) { | ||||||
|     emailStrategyRaw(s != null ? s.toString() : null); |     emailStrategyRaw(s != null ? s.toString() : null); | ||||||
|   } |   } | ||||||
|   private final native void emailStrategyRaw(String s) |   private native void emailStrategyRaw(String s) | ||||||
|   /*-{ this.email_strategy = s }-*/; |   /*-{ this.email_strategy = s }-*/; | ||||||
|  |  | ||||||
|   public final void setMyMenus(List<TopMenuItem> myMenus) { |   public final void setMyMenus(List<TopMenuItem> myMenus) { | ||||||
| @@ -218,8 +218,8 @@ public class GeneralPreferences extends JavaScriptObject { | |||||||
|     return urlAliases; |     return urlAliases; | ||||||
|   } |   } | ||||||
|  |  | ||||||
|   private final native String urlAliasToken(String m) /*-{ return this.url_aliases[m]; }-*/; |   private native String urlAliasToken(String m) /*-{ return this.url_aliases[m]; }-*/; | ||||||
|   private final native NativeMap<NativeString> _urlAliases() /*-{ return this.url_aliases; }-*/; |   private native NativeMap<NativeString> _urlAliases() /*-{ return this.url_aliases; }-*/; | ||||||
|  |  | ||||||
|   public final void setUrlAliases(Map<String, String> urlAliases) { |   public final void setUrlAliases(Map<String, String> urlAliases) { | ||||||
|     initUrlAliases(); |     initUrlAliases(); | ||||||
| @@ -227,8 +227,8 @@ public class GeneralPreferences extends JavaScriptObject { | |||||||
|       putUrlAlias(e.getKey(), e.getValue()); |       putUrlAlias(e.getKey(), e.getValue()); | ||||||
|     } |     } | ||||||
|   } |   } | ||||||
|   private final native void putUrlAlias(String m, String t) /*-{ this.url_aliases[m] = t; }-*/; |   private native void putUrlAlias(String m, String t) /*-{ this.url_aliases[m] = t; }-*/; | ||||||
|   private final native void initUrlAliases() /*-{ this.url_aliases = {}; }-*/; |   private native void initUrlAliases() /*-{ this.url_aliases = {}; }-*/; | ||||||
|  |  | ||||||
|   protected GeneralPreferences() { |   protected GeneralPreferences() { | ||||||
|   } |   } | ||||||
|   | |||||||
| @@ -27,7 +27,7 @@ public class GpgKeyInfo extends JavaScriptObject { | |||||||
|   public final native JsArrayString userIds() /*-{ return this.user_ids; }-*/; |   public final native JsArrayString userIds() /*-{ return this.user_ids; }-*/; | ||||||
|   public final native String key() /*-{ return this.key; }-*/; |   public final native String key() /*-{ return this.key; }-*/; | ||||||
|  |  | ||||||
|   private final native String statusRaw() /*-{ return this.status; }-*/; |   private native String statusRaw() /*-{ return this.status; }-*/; | ||||||
|   public final Status status() { |   public final Status status() { | ||||||
|     String s = statusRaw(); |     String s = statusRaw(); | ||||||
|     if (s == null) { |     if (s == null) { | ||||||
|   | |||||||
| @@ -43,7 +43,7 @@ public class ServerInfo extends JavaScriptObject { | |||||||
|   } |   } | ||||||
|  |  | ||||||
|   public final native String urlAliasToken(String n) /*-{ return this.url_aliases[n]; }-*/; |   public final native String urlAliasToken(String n) /*-{ return this.url_aliases[n]; }-*/; | ||||||
|   private final native NativeMap<NativeString> _urlAliases() /*-{ return this.url_aliases; }-*/; |   private native NativeMap<NativeString> _urlAliases() /*-{ return this.url_aliases; }-*/; | ||||||
|  |  | ||||||
|  |  | ||||||
|   public final boolean hasSshd() { |   public final boolean hasSshd() { | ||||||
|   | |||||||
| @@ -22,7 +22,7 @@ public final class NativeString extends JavaScriptObject { | |||||||
|   public static final JavaScriptObject TYPE = init(); |   public static final JavaScriptObject TYPE = init(); | ||||||
|  |  | ||||||
|   // Used from core and plugins |   // Used from core and plugins | ||||||
|   private static final native JavaScriptObject init() /*-{ |   private static native JavaScriptObject init() /*-{ | ||||||
|     if ($wnd.Gerrit === undefined || $wnd.Gerrit.JsonString === undefined) { |     if ($wnd.Gerrit === undefined || $wnd.Gerrit.JsonString === undefined) { | ||||||
|       return function(s){this.s=s}; |       return function(s){this.s=s}; | ||||||
|     } else { |     } else { | ||||||
| @@ -34,7 +34,7 @@ public final class NativeString extends JavaScriptObject { | |||||||
|     return wrap0(TYPE, s); |     return wrap0(TYPE, s); | ||||||
|   } |   } | ||||||
|  |  | ||||||
|   private static final native NativeString wrap0(JavaScriptObject T, String s) |   private static native NativeString wrap0(JavaScriptObject T, String s) | ||||||
|   /*-{ return new T(s) }-*/; |   /*-{ return new T(s) }-*/; | ||||||
|  |  | ||||||
|   public final native String asString() /*-{ return this.s; }-*/; |   public final native String asString() /*-{ return this.s; }-*/; | ||||||
| @@ -58,7 +58,7 @@ public final class NativeString extends JavaScriptObject { | |||||||
|     return is(TYPE, o); |     return is(TYPE, o); | ||||||
|   } |   } | ||||||
|  |  | ||||||
|   private static final native boolean is(JavaScriptObject T, JavaScriptObject o) |   private static native boolean is(JavaScriptObject T, JavaScriptObject o) | ||||||
|   /*-{ return o instanceof T }-*/; |   /*-{ return o instanceof T }-*/; | ||||||
|  |  | ||||||
|   protected NativeString() { |   protected NativeString() { | ||||||
|   | |||||||
| @@ -158,11 +158,11 @@ public class DiffPreferences extends JavaScriptObject { | |||||||
|   public final native boolean skipDeleted() /*-{ return this.skip_deleted || false }-*/; |   public final native boolean skipDeleted() /*-{ return this.skip_deleted || false }-*/; | ||||||
|   public final native boolean matchBrackets() /*-{ return this.match_brackets || false }-*/; |   public final native boolean matchBrackets() /*-{ return this.match_brackets || false }-*/; | ||||||
|  |  | ||||||
|   private final native void setThemeRaw(String i) /*-{ this.theme = i }-*/; |   private native void setThemeRaw(String i) /*-{ this.theme = i }-*/; | ||||||
|   private final native void setIgnoreWhitespaceRaw(String i) /*-{ this.ignore_whitespace = i }-*/; |   private native void setIgnoreWhitespaceRaw(String i) /*-{ this.ignore_whitespace = i }-*/; | ||||||
|   private final native String ignoreWhitespaceRaw() /*-{ return this.ignore_whitespace }-*/; |   private native String ignoreWhitespaceRaw() /*-{ return this.ignore_whitespace }-*/; | ||||||
|   private final native String themeRaw() /*-{ return this.theme }-*/; |   private native String themeRaw() /*-{ return this.theme }-*/; | ||||||
|   private final native int get(String n, int d) /*-{ return this.hasOwnProperty(n) ? this[n] : d }-*/; |   private native int get(String n, int d) /*-{ return this.hasOwnProperty(n) ? this[n] : d }-*/; | ||||||
|  |  | ||||||
|   protected DiffPreferences() { |   protected DiffPreferences() { | ||||||
|   } |   } | ||||||
|   | |||||||
| @@ -56,12 +56,12 @@ public class EditPreferences extends JavaScriptObject { | |||||||
|   public final void theme(Theme i) { |   public final void theme(Theme i) { | ||||||
|     setThemeRaw(i != null ? i.toString() : Theme.DEFAULT.toString()); |     setThemeRaw(i != null ? i.toString() : Theme.DEFAULT.toString()); | ||||||
|   } |   } | ||||||
|   private final native void setThemeRaw(String i) /*-{ this.theme = i }-*/; |   private native void setThemeRaw(String i) /*-{ this.theme = i }-*/; | ||||||
|  |  | ||||||
|   public final void keyMapType(KeyMapType i) { |   public final void keyMapType(KeyMapType i) { | ||||||
|     setkeyMapTypeRaw(i != null ? i.toString() : KeyMapType.DEFAULT.toString()); |     setkeyMapTypeRaw(i != null ? i.toString() : KeyMapType.DEFAULT.toString()); | ||||||
|   } |   } | ||||||
|   private final native void setkeyMapTypeRaw(String i) /*-{ this.key_map_type = i }-*/; |   private native void setkeyMapTypeRaw(String i) /*-{ this.key_map_type = i }-*/; | ||||||
|  |  | ||||||
|   public final native void tabSize(int t) /*-{ this.tab_size = t }-*/; |   public final native void tabSize(int t) /*-{ this.tab_size = t }-*/; | ||||||
|   public final native void lineLength(int c) /*-{ this.line_length = c }-*/; |   public final native void lineLength(int c) /*-{ this.line_length = c }-*/; | ||||||
| @@ -78,13 +78,13 @@ public class EditPreferences extends JavaScriptObject { | |||||||
|     String s = themeRaw(); |     String s = themeRaw(); | ||||||
|     return s != null ? Theme.valueOf(s) : Theme.DEFAULT; |     return s != null ? Theme.valueOf(s) : Theme.DEFAULT; | ||||||
|   } |   } | ||||||
|   private final native String themeRaw() /*-{ return this.theme }-*/; |   private native String themeRaw() /*-{ return this.theme }-*/; | ||||||
|  |  | ||||||
|   public final KeyMapType keyMapType() { |   public final KeyMapType keyMapType() { | ||||||
|     String s = keyMapTypeRaw(); |     String s = keyMapTypeRaw(); | ||||||
|     return s != null ? KeyMapType.valueOf(s) : KeyMapType.DEFAULT; |     return s != null ? KeyMapType.valueOf(s) : KeyMapType.DEFAULT; | ||||||
|   } |   } | ||||||
|   private final native String keyMapTypeRaw() /*-{ return this.key_map_type }-*/; |   private native String keyMapTypeRaw() /*-{ return this.key_map_type }-*/; | ||||||
|  |  | ||||||
|   public final int tabSize() { |   public final int tabSize() { | ||||||
|     return get("tab_size", 8); |     return get("tab_size", 8); | ||||||
| @@ -105,7 +105,7 @@ public class EditPreferences extends JavaScriptObject { | |||||||
|   public final native boolean hideLineNumbers() /*-{ return this.hide_line_numbers || false }-*/; |   public final native boolean hideLineNumbers() /*-{ return this.hide_line_numbers || false }-*/; | ||||||
|   public final native boolean matchBrackets() /*-{ return this.match_brackets || false }-*/; |   public final native boolean matchBrackets() /*-{ return this.match_brackets || false }-*/; | ||||||
|   public final native boolean autoCloseBrackets() /*-{ return this.auto_close_brackets || false }-*/; |   public final native boolean autoCloseBrackets() /*-{ return this.auto_close_brackets || false }-*/; | ||||||
|   private final native int get(String n, int d) /*-{ return this.hasOwnProperty(n) ? this[n] : d }-*/; |   private native int get(String n, int d) /*-{ return this.hasOwnProperty(n) ? this[n] : d }-*/; | ||||||
|  |  | ||||||
|   protected EditPreferences() { |   protected EditPreferences() { | ||||||
|   } |   } | ||||||
|   | |||||||
| @@ -19,7 +19,7 @@ import com.google.gwt.resources.client.ClientBundle; | |||||||
| import com.google.gwt.resources.client.ImageResource; | import com.google.gwt.resources.client.ImageResource; | ||||||
|  |  | ||||||
| public interface AdminResources extends ClientBundle { | public interface AdminResources extends ClientBundle { | ||||||
|   public static final AdminResources I = GWT.create(AdminResources.class); |   AdminResources I = GWT.create(AdminResources.class); | ||||||
|  |  | ||||||
|   @Source("admin.css") |   @Source("admin.css") | ||||||
|   AdminCss css(); |   AdminCss css(); | ||||||
|   | |||||||
| @@ -55,11 +55,11 @@ public class ChangeGlue { | |||||||
|     } |     } | ||||||
|   } |   } | ||||||
|  |  | ||||||
|   private static final native JavaScriptObject get(String id) /*-{ |   private static native JavaScriptObject get(String id) /*-{ | ||||||
|     return $wnd.Gerrit.change_actions[id]; |     return $wnd.Gerrit.change_actions[id]; | ||||||
|   }-*/; |   }-*/; | ||||||
|  |  | ||||||
|   private static final native boolean invoke(JavaScriptObject h, |   private static native boolean invoke(JavaScriptObject h, | ||||||
|       ChangeInfo a, RevisionInfo r) |       ChangeInfo a, RevisionInfo r) | ||||||
|   /*-{ return h(a,r) }-*/; |   /*-{ return h(a,r) }-*/; | ||||||
|  |  | ||||||
|   | |||||||
| @@ -45,7 +45,7 @@ public class EditGlue { | |||||||
|     } |     } | ||||||
|   } |   } | ||||||
|  |  | ||||||
|   private static final native JavaScriptObject get(String id) /*-{ |   private static native JavaScriptObject get(String id) /*-{ | ||||||
|     return $wnd.Gerrit.edit_actions[id]; |     return $wnd.Gerrit.edit_actions[id]; | ||||||
|   }-*/; |   }-*/; | ||||||
|  |  | ||||||
|   | |||||||
| @@ -130,14 +130,14 @@ public class ExtensionPanel extends FlowPanel { | |||||||
|     final native void putBoolean(String k, boolean v) /*-{ this.p[k] = v; }-*/; |     final native void putBoolean(String k, boolean v) /*-{ this.p[k] = v; }-*/; | ||||||
|     final native void putObject(String k, JavaScriptObject v) /*-{ this.p[k] = v; }-*/; |     final native void putObject(String k, JavaScriptObject v) /*-{ this.p[k] = v; }-*/; | ||||||
|  |  | ||||||
|     private static final native Context create( |     private static native Context create( | ||||||
|         JavaScriptObject T, |         JavaScriptObject T, | ||||||
|         Definition d, |         Definition d, | ||||||
|         Element e) |         Element e) | ||||||
|     /*-{ return new T(d,e) }-*/; |     /*-{ return new T(d,e) }-*/; | ||||||
|  |  | ||||||
|     private static final JavaScriptObject TYPE = init(); |     private static final JavaScriptObject TYPE = init(); | ||||||
|     private static final native JavaScriptObject init() /*-{ |     private static native JavaScriptObject init() /*-{ | ||||||
|       var T = function(d,e) { |       var T = function(d,e) { | ||||||
|         this._d = d; |         this._d = d; | ||||||
|         this._u = []; |         this._u = []; | ||||||
|   | |||||||
| @@ -109,7 +109,7 @@ public class ExtensionScreen extends Screen { | |||||||
|     final native void onLoad() /*-{ this._d.onLoad(this) }-*/; |     final native void onLoad() /*-{ this._d.onLoad(this) }-*/; | ||||||
|     final native JsArray<JavaScriptObject> unload() /*-{ return this._u }-*/; |     final native JsArray<JavaScriptObject> unload() /*-{ return this._u }-*/; | ||||||
|  |  | ||||||
|     private static final native Context create( |     private static native Context create( | ||||||
|         JavaScriptObject T, |         JavaScriptObject T, | ||||||
|         Definition d, |         Definition d, | ||||||
|         ExtensionScreen s, |         ExtensionScreen s, | ||||||
| @@ -118,7 +118,7 @@ public class ExtensionScreen extends Screen { | |||||||
|     /*-{ return new T(d,s,e,m) }-*/; |     /*-{ return new T(d,s,e,m) }-*/; | ||||||
|  |  | ||||||
|     private static final JavaScriptObject TYPE = init(); |     private static final JavaScriptObject TYPE = init(); | ||||||
|     private static final native JavaScriptObject init() /*-{ |     private static native JavaScriptObject init() /*-{ | ||||||
|       var T = function(d,s,e,m) { |       var T = function(d,s,e,m) { | ||||||
|         this._d = d; |         this._d = d; | ||||||
|         this._s = s; |         this._s = s; | ||||||
|   | |||||||
| @@ -91,7 +91,7 @@ public class ExtensionSettingsScreen extends SettingsScreen { | |||||||
|       return Natives.keys(settingsScreens()); |       return Natives.keys(settingsScreens()); | ||||||
|     } |     } | ||||||
|  |  | ||||||
|     private static final native NativeMap<NativeString> settingsScreens() |     private static native NativeMap<NativeString> settingsScreens() | ||||||
|     /*-{ return $wnd.Gerrit.settingsScreens; }-*/; |     /*-{ return $wnd.Gerrit.settingsScreens; }-*/; | ||||||
|  |  | ||||||
|     public final native String getPath() /*-{ return this.path; }-*/; |     public final native String getPath() /*-{ return this.path; }-*/; | ||||||
| @@ -114,7 +114,7 @@ public class ExtensionSettingsScreen extends SettingsScreen { | |||||||
|     final native void onLoad() /*-{ this._d.onLoad(this) }-*/; |     final native void onLoad() /*-{ this._d.onLoad(this) }-*/; | ||||||
|     final native JsArray<JavaScriptObject> unload() /*-{ return this._u }-*/; |     final native JsArray<JavaScriptObject> unload() /*-{ return this._u }-*/; | ||||||
|  |  | ||||||
|     private static final native Context create( |     private static native Context create( | ||||||
|         JavaScriptObject T, |         JavaScriptObject T, | ||||||
|         Definition d, |         Definition d, | ||||||
|         ExtensionSettingsScreen s, |         ExtensionSettingsScreen s, | ||||||
| @@ -122,7 +122,7 @@ public class ExtensionSettingsScreen extends SettingsScreen { | |||||||
|     /*-{ return new T(d,s,e) }-*/; |     /*-{ return new T(d,s,e) }-*/; | ||||||
|  |  | ||||||
|     private static final JavaScriptObject TYPE = init(); |     private static final JavaScriptObject TYPE = init(); | ||||||
|     private static final native JavaScriptObject init() /*-{ |     private static native JavaScriptObject init() /*-{ | ||||||
|       var T = function(d,s,e) { |       var T = function(d,s,e) { | ||||||
|         this._d = d; |         this._d = d; | ||||||
|         this._s = s; |         this._s = s; | ||||||
|   | |||||||
| @@ -76,7 +76,7 @@ class PluginName { | |||||||
|   protected static final native JavaScriptException makeException() |   protected static final native JavaScriptException makeException() | ||||||
|   /*-{ try { null.a() } catch (e) { return e } }-*/; |   /*-{ try { null.a() } catch (e) { return e } }-*/; | ||||||
|  |  | ||||||
|   private static final native boolean hasStack(JavaScriptException e) |   private static native boolean hasStack(JavaScriptException e) | ||||||
|   /*-{ return !!e.stack }-*/; |   /*-{ return !!e.stack }-*/; | ||||||
|  |  | ||||||
|   /** Extracts URL from the stack frame. */ |   /** Extracts URL from the stack frame. */ | ||||||
| @@ -103,7 +103,7 @@ class PluginName { | |||||||
|       return UNKNOWN; |       return UNKNOWN; | ||||||
|     } |     } | ||||||
|  |  | ||||||
|     private static final native JsArrayString getStack(JavaScriptException e) |     private static native JsArrayString getStack(JavaScriptException e) | ||||||
|     /*-{ return e.stack ? e.stack.split('\n') : [] }-*/; |     /*-{ return e.stack ? e.stack.split('\n') : [] }-*/; | ||||||
|   } |   } | ||||||
| } | } | ||||||
|   | |||||||
| @@ -61,11 +61,11 @@ public class ProjectGlue { | |||||||
|     } |     } | ||||||
|   } |   } | ||||||
|  |  | ||||||
|   private static final native JavaScriptObject projectAction(String id) /*-{ |   private static native JavaScriptObject projectAction(String id) /*-{ | ||||||
|     return $wnd.Gerrit.project_actions[id]; |     return $wnd.Gerrit.project_actions[id]; | ||||||
|   }-*/; |   }-*/; | ||||||
|  |  | ||||||
|   private static final native JavaScriptObject branchAction(String id) /*-{ |   private static native JavaScriptObject branchAction(String id) /*-{ | ||||||
|     return $wnd.Gerrit.branch_actions[id]; |     return $wnd.Gerrit.branch_actions[id]; | ||||||
|   }-*/; |   }-*/; | ||||||
|  |  | ||||||
|   | |||||||
| @@ -46,7 +46,7 @@ public class RevisionGlue { | |||||||
|     } |     } | ||||||
|   } |   } | ||||||
|  |  | ||||||
|   private static final native JavaScriptObject get(String id) /*-{ |   private static native JavaScriptObject get(String id) /*-{ | ||||||
|     return $wnd.Gerrit.revision_actions[id]; |     return $wnd.Gerrit.revision_actions[id]; | ||||||
|   }-*/; |   }-*/; | ||||||
|  |  | ||||||
|   | |||||||
| @@ -115,7 +115,7 @@ public class FileTable extends FlowPanel { | |||||||
|     init(DELETE, RESTORE, REVIEWED, OPEN); |     init(DELETE, RESTORE, REVIEWED, OPEN); | ||||||
|   } |   } | ||||||
|  |  | ||||||
|   private static final native void init(String d, String t, String r, String o) /*-{ |   private static native void init(String d, String t, String r, String o) /*-{ | ||||||
|     $wnd[d] = $entry(function(e,i) { |     $wnd[d] = $entry(function(e,i) { | ||||||
|       @com.google.gerrit.client.change.FileTable::onDelete(Lcom/google/gwt/dom/client/NativeEvent;I)(e,i) |       @com.google.gerrit.client.change.FileTable::onDelete(Lcom/google/gwt/dom/client/NativeEvent;I)(e,i) | ||||||
|     }); |     }); | ||||||
|   | |||||||
| @@ -62,7 +62,7 @@ public class Hashtags extends Composite { | |||||||
|     init(REMOVE); |     init(REMOVE); | ||||||
|   } |   } | ||||||
|  |  | ||||||
|   private static final native void init(String r) /*-{ |   private static native void init(String r) /*-{ | ||||||
|     $wnd[r] = $entry(function(e) { |     $wnd[r] = $entry(function(e) { | ||||||
|       @com.google.gerrit.client.change.Hashtags::onRemove(Lcom/google/gwt/dom/client/NativeEvent;)(e) |       @com.google.gerrit.client.change.Hashtags::onRemove(Lcom/google/gwt/dom/client/NativeEvent;)(e) | ||||||
|     }); |     }); | ||||||
|   | |||||||
| @@ -59,7 +59,7 @@ class Labels extends Grid { | |||||||
|     init(REMOVE_REVIEWER, REMOVE_VOTE); |     init(REMOVE_REVIEWER, REMOVE_VOTE); | ||||||
|   } |   } | ||||||
|  |  | ||||||
|   private static final native void init(String r, String v) /*-{ |   private static native void init(String r, String v) /*-{ | ||||||
|     $wnd[r] = $entry(function(e) { |     $wnd[r] = $entry(function(e) { | ||||||
|       @com.google.gerrit.client.change.Labels::onRemoveReviewer(Lcom/google/gwt/dom/client/NativeEvent;)(e) |       @com.google.gerrit.client.change.Labels::onRemoveReviewer(Lcom/google/gwt/dom/client/NativeEvent;)(e) | ||||||
|     }); |     }); | ||||||
|   | |||||||
| @@ -63,7 +63,7 @@ class PatchSetsBox extends Composite { | |||||||
|     init(OPEN); |     init(OPEN); | ||||||
|   } |   } | ||||||
|  |  | ||||||
|   private static final native void init(String o) /*-{ |   private static native void init(String o) /*-{ | ||||||
|     $wnd[o] = $entry(function(e,i) { |     $wnd[o] = $entry(function(e,i) { | ||||||
|       return @com.google.gerrit.client.change.PatchSetsBox::onOpen(Lcom/google/gwt/dom/client/NativeEvent;I)(e,i); |       return @com.google.gerrit.client.change.PatchSetsBox::onOpen(Lcom/google/gwt/dom/client/NativeEvent;I)(e,i); | ||||||
|     }); |     }); | ||||||
|   | |||||||
| @@ -385,7 +385,7 @@ public class RelatedChanges extends TabPanel { | |||||||
|       String s = statusRaw(); |       String s = statusRaw(); | ||||||
|       return s != null ? Change.Status.valueOf(s) : null; |       return s != null ? Change.Status.valueOf(s) : null; | ||||||
|     } |     } | ||||||
|     private final native String statusRaw() /*-{ return this.status; }-*/; |     private native String statusRaw() /*-{ return this.status; }-*/; | ||||||
|  |  | ||||||
|     final native void setId(String i) |     final native void setId(String i) | ||||||
|     /*-{ if(i)this.change_id=i; }-*/; |     /*-{ if(i)this.change_id=i; }-*/; | ||||||
|   | |||||||
| @@ -67,7 +67,7 @@ class RelatedChangesTab implements IsWidget { | |||||||
|   private static final SafeHtml POINTER_HTML = |   private static final SafeHtml POINTER_HTML = | ||||||
|       AbstractImagePrototype.create(Gerrit.RESOURCES.arrowRight()).getSafeHtml(); |       AbstractImagePrototype.create(Gerrit.RESOURCES.arrowRight()).getSafeHtml(); | ||||||
|  |  | ||||||
|   private static final native String init(String o) /*-{ |   private static native String init(String o) /*-{ | ||||||
|     $wnd[o] = $entry(@com.google.gerrit.client.change.RelatedChangesTab::onOpen( |     $wnd[o] = $entry(@com.google.gerrit.client.change.RelatedChangesTab::onOpen( | ||||||
|       Lcom/google/gwt/dom/client/NativeEvent;Lcom/google/gwt/dom/client/Element;)); |       Lcom/google/gwt/dom/client/NativeEvent;Lcom/google/gwt/dom/client/Element;)); | ||||||
|     return o + '(event,this)'; |     return o + '(event,this)'; | ||||||
| @@ -599,7 +599,7 @@ class RelatedChangesTab implements IsWidget { | |||||||
|     } |     } | ||||||
|   } |   } | ||||||
|  |  | ||||||
|   private static final native Node createDocumentFragment() /*-{ |   private static native Node createDocumentFragment() /*-{ | ||||||
|     return $doc.createDocumentFragment(); |     return $doc.createDocumentFragment(); | ||||||
|   }-*/; |   }-*/; | ||||||
| } | } | ||||||
|   | |||||||
| @@ -19,9 +19,9 @@ import com.google.gwt.resources.client.ClientBundle; | |||||||
| import com.google.gwt.resources.client.CssResource; | import com.google.gwt.resources.client.CssResource; | ||||||
|  |  | ||||||
| public interface Resources extends ClientBundle { | public interface Resources extends ClientBundle { | ||||||
|   public static final Resources I = GWT.create(Resources.class); |   Resources I = GWT.create(Resources.class); | ||||||
|   final ChangeConstants C = GWT.create(ChangeConstants.class); |   ChangeConstants C = GWT.create(ChangeConstants.class); | ||||||
|   final ChangeMessages M = GWT.create(ChangeMessages.class); |   ChangeMessages M = GWT.create(ChangeMessages.class); | ||||||
|  |  | ||||||
|   @Source("common.css") Style style(); |   @Source("common.css") Style style(); | ||||||
|  |  | ||||||
|   | |||||||
| @@ -293,7 +293,7 @@ public class Reviewers extends Composite { | |||||||
|       return Natives.keys(_approvals()); |       return Natives.keys(_approvals()); | ||||||
|     } |     } | ||||||
|     final native String approval(String l) /*-{ return this.approvals[l]; }-*/; |     final native String approval(String l) /*-{ return this.approvals[l]; }-*/; | ||||||
|     private final native NativeMap<NativeString> _approvals() /*-{ return this.approvals; }-*/; |     private native NativeMap<NativeString> _approvals() /*-{ return this.approvals; }-*/; | ||||||
|  |  | ||||||
|     protected ReviewerInfo() { |     protected ReviewerInfo() { | ||||||
|     } |     } | ||||||
|   | |||||||
| @@ -77,7 +77,7 @@ public class CommentInfo extends JavaScriptObject { | |||||||
|   public final void side(Side side) { |   public final void side(Side side) { | ||||||
|     sideRaw(side.toString()); |     sideRaw(side.toString()); | ||||||
|   } |   } | ||||||
|   private final native void sideRaw(String s) /*-{ this.side = s }-*/; |   private native void sideRaw(String s) /*-{ this.side = s }-*/; | ||||||
|  |  | ||||||
|   public final native String path() /*-{ return this.path }-*/; |   public final native String path() /*-{ return this.path }-*/; | ||||||
|   public final native String id() /*-{ return this.id }-*/; |   public final native String id() /*-{ return this.id }-*/; | ||||||
| @@ -90,7 +90,7 @@ public class CommentInfo extends JavaScriptObject { | |||||||
|         ? Side.valueOf(s) |         ? Side.valueOf(s) | ||||||
|         : Side.REVISION; |         : Side.REVISION; | ||||||
|   } |   } | ||||||
|   private final native String sideRaw() /*-{ return this.side }-*/; |   private native String sideRaw() /*-{ return this.side }-*/; | ||||||
|  |  | ||||||
|   public final Timestamp updated() { |   public final Timestamp updated() { | ||||||
|     Timestamp r = updatedTimestamp(); |     Timestamp r = updatedTimestamp(); | ||||||
| @@ -103,9 +103,9 @@ public class CommentInfo extends JavaScriptObject { | |||||||
|     } |     } | ||||||
|     return r; |     return r; | ||||||
|   } |   } | ||||||
|   private final native String updatedRaw() /*-{ return this.updated }-*/; |   private native String updatedRaw() /*-{ return this.updated }-*/; | ||||||
|   private final native Timestamp updatedTimestamp() /*-{ return this._ts }-*/; |   private native Timestamp updatedTimestamp() /*-{ return this._ts }-*/; | ||||||
|   private final native void updatedTimestamp(Timestamp t) /*-{ this._ts = t }-*/; |   private native void updatedTimestamp(Timestamp t) /*-{ this._ts = t }-*/; | ||||||
|  |  | ||||||
|   public final native AccountInfo author() /*-{ return this.author }-*/; |   public final native AccountInfo author() /*-{ return this.author }-*/; | ||||||
|   public final native int line() /*-{ return this.line || 0 }-*/; |   public final native int line() /*-{ return this.line || 0 }-*/; | ||||||
|   | |||||||
| @@ -42,14 +42,14 @@ public class ReviewInput extends JavaScriptObject { | |||||||
|   public final void notify(NotifyHandling e) { |   public final void notify(NotifyHandling e) { | ||||||
|     _notify(e.name()); |     _notify(e.name()); | ||||||
|   } |   } | ||||||
|   private final native void _notify(String n) /*-{ this.notify=n; }-*/; |   private native void _notify(String n) /*-{ this.notify=n; }-*/; | ||||||
|  |  | ||||||
|   public final void drafts(DraftHandling e) { |   public final void drafts(DraftHandling e) { | ||||||
|     _drafts(e.name()); |     _drafts(e.name()); | ||||||
|   } |   } | ||||||
|   private final native void _drafts(String n) /*-{ this.drafts=n; }-*/; |   private native void _drafts(String n) /*-{ this.drafts=n; }-*/; | ||||||
|  |  | ||||||
|   private final native void init() /*-{ |   private native void init() /*-{ | ||||||
|     this.labels = {}; |     this.labels = {}; | ||||||
|     this.strict_labels = true; |     this.strict_labels = true; | ||||||
|   }-*/; |   }-*/; | ||||||
|   | |||||||
| @@ -22,7 +22,7 @@ public class SubmitInfo extends JavaScriptObject { | |||||||
|     return Change.Status.valueOf(statusRaw()); |     return Change.Status.valueOf(statusRaw()); | ||||||
|   } |   } | ||||||
|  |  | ||||||
|   private final native String statusRaw() /*-{ return this.status; }-*/; |   private native String statusRaw() /*-{ return this.status; }-*/; | ||||||
|  |  | ||||||
|   protected SubmitInfo() { |   protected SubmitInfo() { | ||||||
|   } |   } | ||||||
|   | |||||||
| @@ -43,7 +43,7 @@ public class CommentRange extends JavaScriptObject { | |||||||
|   public final native int endLine() /*-{ return this.end_line; }-*/; |   public final native int endLine() /*-{ return this.end_line; }-*/; | ||||||
|   public final native int endCharacter() /*-{ return this.end_character; }-*/; |   public final native int endCharacter() /*-{ return this.end_character; }-*/; | ||||||
|  |  | ||||||
|   private final native void set(int sl, int sc, int el, int ec) /*-{ |   private native void set(int sl, int sc, int el, int ec) /*-{ | ||||||
|     this.start_line = sl; |     this.start_line = sl; | ||||||
|     this.start_character = sc; |     this.start_character = sc; | ||||||
|     this.end_line = el; |     this.end_line = el; | ||||||
|   | |||||||
| @@ -66,7 +66,7 @@ public class DiffInfo extends JavaScriptObject { | |||||||
|   public final ChangeType changeType() { |   public final ChangeType changeType() { | ||||||
|     return ChangeType.valueOf(changeTypeRaw()); |     return ChangeType.valueOf(changeTypeRaw()); | ||||||
|   } |   } | ||||||
|   private final native String changeTypeRaw() |   private native String changeTypeRaw() | ||||||
|   /*-{ return this.change_type }-*/; |   /*-{ return this.change_type }-*/; | ||||||
|  |  | ||||||
|   public final IntraLineStatus intralineStatus() { |   public final IntraLineStatus intralineStatus() { | ||||||
| @@ -75,7 +75,7 @@ public class DiffInfo extends JavaScriptObject { | |||||||
|         ? IntraLineStatus.valueOf(s) |         ? IntraLineStatus.valueOf(s) | ||||||
|         : IntraLineStatus.OFF; |         : IntraLineStatus.OFF; | ||||||
|   } |   } | ||||||
|   private final native String intralineStatusRaw() |   private native String intralineStatusRaw() | ||||||
|   /*-{ return this.intraline_status }-*/; |   /*-{ return this.intraline_status }-*/; | ||||||
|  |  | ||||||
|   public final boolean hasSkip() { |   public final boolean hasSkip() { | ||||||
|   | |||||||
| @@ -20,7 +20,7 @@ import com.google.gwt.resources.client.ImageResource; | |||||||
|  |  | ||||||
| /** Resources used by diff. */ | /** Resources used by diff. */ | ||||||
| interface Resources extends ClientBundle { | interface Resources extends ClientBundle { | ||||||
|   final Resources I = GWT.create(Resources.class); |   Resources I = GWT.create(Resources.class); | ||||||
|  |  | ||||||
|   @Source("CommentBox.css") CommentBox.Style style(); |   @Source("CommentBox.css") CommentBox.Style style(); | ||||||
|   @Source("Scrollbar.css") Scrollbar.Style scrollbarStyle(); |   @Source("Scrollbar.css") Scrollbar.Style scrollbarStyle(); | ||||||
|   | |||||||
| @@ -45,7 +45,7 @@ class SideBySideChunkManager extends ChunkManager { | |||||||
|   private static double guessedLineHeightPx = 15; |   private static double guessedLineHeightPx = 15; | ||||||
|   private static final JavaScriptObject focusA = initOnClick(A); |   private static final JavaScriptObject focusA = initOnClick(A); | ||||||
|   private static final JavaScriptObject focusB = initOnClick(B); |   private static final JavaScriptObject focusB = initOnClick(B); | ||||||
|   private static final native JavaScriptObject initOnClick(DisplaySide s) /*-{ |   private static native JavaScriptObject initOnClick(DisplaySide s) /*-{ | ||||||
|     return $entry(function(e){ |     return $entry(function(e){ | ||||||
|       @com.google.gerrit.client.diff.SideBySideChunkManager::focus( |       @com.google.gerrit.client.diff.SideBySideChunkManager::focus( | ||||||
|         Lcom/google/gwt/dom/client/NativeEvent; |         Lcom/google/gwt/dom/client/NativeEvent; | ||||||
|   | |||||||
| @@ -38,7 +38,7 @@ import java.util.List; | |||||||
| /** Colors modified regions for {@link Unified}. */ | /** Colors modified regions for {@link Unified}. */ | ||||||
| class UnifiedChunkManager extends ChunkManager { | class UnifiedChunkManager extends ChunkManager { | ||||||
|   private static final JavaScriptObject focus = initOnClick(); |   private static final JavaScriptObject focus = initOnClick(); | ||||||
|   private static final native JavaScriptObject initOnClick() /*-{ |   private static native JavaScriptObject initOnClick() /*-{ | ||||||
|     return $entry(function(e){ |     return $entry(function(e){ | ||||||
|       @com.google.gerrit.client.diff.UnifiedChunkManager::focus( |       @com.google.gerrit.client.diff.UnifiedChunkManager::focus( | ||||||
|         Lcom/google/gwt/dom/client/NativeEvent;)(e) |         Lcom/google/gwt/dom/client/NativeEvent;)(e) | ||||||
|   | |||||||
| @@ -18,7 +18,7 @@ import com.google.gwt.core.client.GWT; | |||||||
| import com.google.gwt.i18n.client.Constants; | import com.google.gwt.i18n.client.Constants; | ||||||
|  |  | ||||||
| interface EditConstants extends Constants { | interface EditConstants extends Constants { | ||||||
|   final EditConstants I = GWT.create(EditConstants.class); |   EditConstants I = GWT.create(EditConstants.class); | ||||||
|  |  | ||||||
|   String closeUnsavedChanges(); |   String closeUnsavedChanges(); | ||||||
|   String cancelUnsavedChanges(); |   String cancelUnsavedChanges(); | ||||||
|   | |||||||
| @@ -37,8 +37,8 @@ public class GroupAuditEventInfo extends JavaScriptObject { | |||||||
|   public final native AccountInfo memberAsUser() /*-{ return this.member; }-*/; |   public final native AccountInfo memberAsUser() /*-{ return this.member; }-*/; | ||||||
|   public final native GroupInfo memberAsGroup() /*-{ return this.member; }-*/; |   public final native GroupInfo memberAsGroup() /*-{ return this.member; }-*/; | ||||||
|  |  | ||||||
|   private final native String dateRaw() /*-{ return this.date; }-*/; |   private native String dateRaw() /*-{ return this.date; }-*/; | ||||||
|   private final native String typeRaw() /*-{ return this.type; }-*/; |   private native String typeRaw() /*-{ return this.type; }-*/; | ||||||
|  |  | ||||||
|   protected GroupAuditEventInfo() { |   protected GroupAuditEventInfo() { | ||||||
|   } |   } | ||||||
|   | |||||||
| @@ -33,9 +33,9 @@ public class GroupInfo extends GroupBaseInfo { | |||||||
|   public final native JsArray<AccountInfo> members() /*-{ return this.members; }-*/; |   public final native JsArray<AccountInfo> members() /*-{ return this.members; }-*/; | ||||||
|   public final native JsArray<GroupInfo> includes() /*-{ return this.includes; }-*/; |   public final native JsArray<GroupInfo> includes() /*-{ return this.includes; }-*/; | ||||||
|  |  | ||||||
|   private final native int group_id() /*-{ return this.group_id; }-*/; |   private native int group_id() /*-{ return this.group_id; }-*/; | ||||||
|   private final native String owner_id() /*-{ return this.owner_id; }-*/; |   private native String owner_id() /*-{ return this.owner_id; }-*/; | ||||||
|   private final native void owner_id(String o) /*-{ if(o)this.owner_id=o; }-*/; |   private native void owner_id(String o) /*-{ if(o)this.owner_id=o; }-*/; | ||||||
|  |  | ||||||
|   public final AccountGroup.UUID getOwnerUUID() { |   public final AccountGroup.UUID getOwnerUUID() { | ||||||
|     String owner = owner_id(); |     String owner = owner_id(); | ||||||
|   | |||||||
| @@ -69,7 +69,7 @@ public class ConfigInfo extends JavaScriptObject { | |||||||
|   public final native NativeMap<ActionInfo> actions() |   public final native NativeMap<ActionInfo> actions() | ||||||
|   /*-{ return this.actions; }-*/; |   /*-{ return this.actions; }-*/; | ||||||
|  |  | ||||||
|   private final native String submitTypeRaw() |   private native String submitTypeRaw() | ||||||
|   /*-{ return this.submit_type }-*/; |   /*-{ return this.submit_type }-*/; | ||||||
|  |  | ||||||
|   public final ProjectState state() { |   public final ProjectState state() { | ||||||
| @@ -78,13 +78,13 @@ public class ConfigInfo extends JavaScriptObject { | |||||||
|     } |     } | ||||||
|     return ProjectState.valueOf(stateRaw()); |     return ProjectState.valueOf(stateRaw()); | ||||||
|   } |   } | ||||||
|   private final native String stateRaw() |   private native String stateRaw() | ||||||
|   /*-{ return this.state }-*/; |   /*-{ return this.state }-*/; | ||||||
|  |  | ||||||
|   public final native MaxObjectSizeLimitInfo maxObjectSizeLimit() |   public final native MaxObjectSizeLimitInfo maxObjectSizeLimit() | ||||||
|   /*-{ return this.max_object_size_limit; }-*/; |   /*-{ return this.max_object_size_limit; }-*/; | ||||||
|  |  | ||||||
|   private final native NativeMap<CommentLinkInfo> commentlinks0() |   private native NativeMap<CommentLinkInfo> commentlinks0() | ||||||
|   /*-{ return this.commentlinks; }-*/; |   /*-{ return this.commentlinks; }-*/; | ||||||
|   final List<FindReplace> commentlinks() { |   final List<FindReplace> commentlinks() { | ||||||
|     JsArray<CommentLinkInfo> cls = commentlinks0().values(); |     JsArray<CommentLinkInfo> cls = commentlinks0().values(); | ||||||
| @@ -143,7 +143,7 @@ public class ConfigInfo extends JavaScriptObject { | |||||||
|     public final InheritableBoolean configuredValue() { |     public final InheritableBoolean configuredValue() { | ||||||
|       return InheritableBoolean.valueOf(configuredValueRaw()); |       return InheritableBoolean.valueOf(configuredValueRaw()); | ||||||
|     } |     } | ||||||
|     private final native String configuredValueRaw() |     private native String configuredValueRaw() | ||||||
|     /*-{ return this.configured_value }-*/; |     /*-{ return this.configured_value }-*/; | ||||||
|  |  | ||||||
|     public final void setConfiguredValue(InheritableBoolean v) { |     public final void setConfiguredValue(InheritableBoolean v) { | ||||||
|   | |||||||
| @@ -228,43 +228,43 @@ public class ProjectApi { | |||||||
|     final void setUseContributorAgreements(InheritableBoolean v) { |     final void setUseContributorAgreements(InheritableBoolean v) { | ||||||
|       setUseContributorAgreementsRaw(v.name()); |       setUseContributorAgreementsRaw(v.name()); | ||||||
|     } |     } | ||||||
|     private final native void setUseContributorAgreementsRaw(String v) |     private native void setUseContributorAgreementsRaw(String v) | ||||||
|     /*-{ if(v)this.use_contributor_agreements=v; }-*/; |     /*-{ if(v)this.use_contributor_agreements=v; }-*/; | ||||||
|  |  | ||||||
|     final void setUseContentMerge(InheritableBoolean v) { |     final void setUseContentMerge(InheritableBoolean v) { | ||||||
|       setUseContentMergeRaw(v.name()); |       setUseContentMergeRaw(v.name()); | ||||||
|     } |     } | ||||||
|     private final native void setUseContentMergeRaw(String v) |     private native void setUseContentMergeRaw(String v) | ||||||
|     /*-{ if(v)this.use_content_merge=v; }-*/; |     /*-{ if(v)this.use_content_merge=v; }-*/; | ||||||
|  |  | ||||||
|     final void setUseSignedOffBy(InheritableBoolean v) { |     final void setUseSignedOffBy(InheritableBoolean v) { | ||||||
|       setUseSignedOffByRaw(v.name()); |       setUseSignedOffByRaw(v.name()); | ||||||
|     } |     } | ||||||
|     private final native void setUseSignedOffByRaw(String v) |     private native void setUseSignedOffByRaw(String v) | ||||||
|     /*-{ if(v)this.use_signed_off_by=v; }-*/; |     /*-{ if(v)this.use_signed_off_by=v; }-*/; | ||||||
|  |  | ||||||
|     final void setRequireChangeId(InheritableBoolean v) { |     final void setRequireChangeId(InheritableBoolean v) { | ||||||
|       setRequireChangeIdRaw(v.name()); |       setRequireChangeIdRaw(v.name()); | ||||||
|     } |     } | ||||||
|     private final native void setRequireChangeIdRaw(String v) |     private native void setRequireChangeIdRaw(String v) | ||||||
|     /*-{ if(v)this.require_change_id=v; }-*/; |     /*-{ if(v)this.require_change_id=v; }-*/; | ||||||
|  |  | ||||||
|     final void setCreateNewChangeForAllNotInTarget(InheritableBoolean v) { |     final void setCreateNewChangeForAllNotInTarget(InheritableBoolean v) { | ||||||
|       setCreateNewChangeForAllNotInTargetRaw(v.name()); |       setCreateNewChangeForAllNotInTargetRaw(v.name()); | ||||||
|     } |     } | ||||||
|     private final native void setCreateNewChangeForAllNotInTargetRaw(String v) |     private native void setCreateNewChangeForAllNotInTargetRaw(String v) | ||||||
|     /*-{ if(v)this.create_new_change_for_all_not_in_target=v; }-*/; |     /*-{ if(v)this.create_new_change_for_all_not_in_target=v; }-*/; | ||||||
|  |  | ||||||
|     final void setEnableSignedPush(InheritableBoolean v) { |     final void setEnableSignedPush(InheritableBoolean v) { | ||||||
|       setEnableSignedPushRaw(v.name()); |       setEnableSignedPushRaw(v.name()); | ||||||
|     } |     } | ||||||
|     private final native void setEnableSignedPushRaw(String v) |     private native void setEnableSignedPushRaw(String v) | ||||||
|     /*-{ if(v)this.enable_signed_push=v; }-*/; |     /*-{ if(v)this.enable_signed_push=v; }-*/; | ||||||
|  |  | ||||||
|     final void setRequireSignedPush(InheritableBoolean v) { |     final void setRequireSignedPush(InheritableBoolean v) { | ||||||
|       setRequireSignedPushRaw(v.name()); |       setRequireSignedPushRaw(v.name()); | ||||||
|     } |     } | ||||||
|     private final native void setRequireSignedPushRaw(String v) |     private native void setRequireSignedPushRaw(String v) | ||||||
|     /*-{ if(v)this.require_signed_push=v; }-*/; |     /*-{ if(v)this.require_signed_push=v; }-*/; | ||||||
|  |  | ||||||
|     final native void setMaxObjectSizeLimit(String l) |     final native void setMaxObjectSizeLimit(String l) | ||||||
| @@ -273,13 +273,13 @@ public class ProjectApi { | |||||||
|     final void setSubmitType(SubmitType t) { |     final void setSubmitType(SubmitType t) { | ||||||
|       setSubmitTypeRaw(t.name()); |       setSubmitTypeRaw(t.name()); | ||||||
|     } |     } | ||||||
|     private final native void setSubmitTypeRaw(String t) |     private native void setSubmitTypeRaw(String t) | ||||||
|     /*-{ if(t)this.submit_type=t; }-*/; |     /*-{ if(t)this.submit_type=t; }-*/; | ||||||
|  |  | ||||||
|     final void setState(ProjectState s) { |     final void setState(ProjectState s) { | ||||||
|       setStateRaw(s.name()); |       setStateRaw(s.name()); | ||||||
|     } |     } | ||||||
|     private final native void setStateRaw(String s) |     private native void setStateRaw(String s) | ||||||
|     /*-{ if(s)this.state=s; }-*/; |     /*-{ if(s)this.state=s; }-*/; | ||||||
|  |  | ||||||
|     final void setPluginConfigValues(Map<String, Map<String, ConfigParameterValue>> pluginConfigValues) { |     final void setPluginConfigValues(Map<String, Map<String, ConfigParameterValue>> pluginConfigValues) { | ||||||
| @@ -295,7 +295,7 @@ public class ProjectApi { | |||||||
|         setPluginConfigValuesRaw(configValues); |         setPluginConfigValuesRaw(configValues); | ||||||
|       } |       } | ||||||
|     } |     } | ||||||
|     private final native void setPluginConfigValuesRaw(NativeMap<ConfigParameterValueMap> v) |     private native void setPluginConfigValuesRaw(NativeMap<ConfigParameterValueMap> v) | ||||||
|     /*-{ this.plugin_config_values=v; }-*/; |     /*-{ this.plugin_config_values=v; }-*/; | ||||||
|   } |   } | ||||||
|  |  | ||||||
|   | |||||||
| @@ -36,7 +36,7 @@ public class ProjectInfo | |||||||
|     return ProjectState.valueOf(getStringState()); |     return ProjectState.valueOf(getStringState()); | ||||||
|   } |   } | ||||||
|  |  | ||||||
|   private final native String getStringState() /*-{ return this.state; }-*/; |   private native String getStringState() /*-{ return this.state; }-*/; | ||||||
|  |  | ||||||
|   @Override |   @Override | ||||||
|   public final String getDisplayString() { |   public final String getDisplayString() { | ||||||
|   | |||||||
| @@ -18,7 +18,7 @@ import com.google.gwt.core.client.GWT; | |||||||
| import com.google.gwt.i18n.client.Constants; | import com.google.gwt.i18n.client.Constants; | ||||||
|  |  | ||||||
| public interface RpcConstants extends Constants { | public interface RpcConstants extends Constants { | ||||||
|   public static final RpcConstants C = GWT.create(RpcConstants.class); |   RpcConstants C = GWT.create(RpcConstants.class); | ||||||
|  |  | ||||||
|   String errorServerUnavailable(); |   String errorServerUnavailable(); | ||||||
|   String errorRemoteJsonException(); |   String errorRemoteJsonException(); | ||||||
|   | |||||||
| @@ -222,9 +222,9 @@ public abstract class FancyFlexTable<RowItem> extends Composite { | |||||||
|   protected static class MyFlexTable extends FlexTable { |   protected static class MyFlexTable extends FlexTable { | ||||||
|   } |   } | ||||||
|  |  | ||||||
|   private static final native <ItemType> void setRowItem(Element td, ItemType c) |   private static native <ItemType> void setRowItem(Element td, ItemType c) | ||||||
|   /*-{ td['__gerritRowItem'] = c; }-*/; |   /*-{ td['__gerritRowItem'] = c; }-*/; | ||||||
|  |  | ||||||
|   private static final native <ItemType> ItemType getRowItem(Element td) |   private static native <ItemType> ItemType getRowItem(Element td) | ||||||
|   /*-{ return td['__gerritRowItem']; }-*/; |   /*-{ return td['__gerritRowItem']; }-*/; | ||||||
| } | } | ||||||
|   | |||||||
| @@ -138,7 +138,7 @@ public class CodeMirror extends JavaScriptObject { | |||||||
|     addLineClassNative(line, where.value(), className); |     addLineClassNative(line, where.value(), className); | ||||||
|   } |   } | ||||||
|  |  | ||||||
|   private final native void addLineClassNative(int line, String where, |   private native void addLineClassNative(int line, String where, | ||||||
|       String lineClass) /*-{ |       String lineClass) /*-{ | ||||||
|     this.addLineClass(line, where, lineClass) |     this.addLineClass(line, where, lineClass) | ||||||
|   }-*/; |   }-*/; | ||||||
| @@ -148,7 +148,7 @@ public class CodeMirror extends JavaScriptObject { | |||||||
|     addLineClassNative(line, where.value(), className); |     addLineClassNative(line, where.value(), className); | ||||||
|   } |   } | ||||||
|  |  | ||||||
|   private final native void addLineClassNative(LineHandle line, String where, |   private native void addLineClassNative(LineHandle line, String where, | ||||||
|       String lineClass) /*-{ |       String lineClass) /*-{ | ||||||
|     this.addLineClass(line, where, lineClass) |     this.addLineClass(line, where, lineClass) | ||||||
|   }-*/; |   }-*/; | ||||||
| @@ -158,7 +158,7 @@ public class CodeMirror extends JavaScriptObject { | |||||||
|     removeLineClassNative(line, where.value(), className); |     removeLineClassNative(line, where.value(), className); | ||||||
|   } |   } | ||||||
|  |  | ||||||
|   private final native void removeLineClassNative(int line, String where, |   private native void removeLineClassNative(int line, String where, | ||||||
|       String lineClass) /*-{ |       String lineClass) /*-{ | ||||||
|     this.removeLineClass(line, where, lineClass) |     this.removeLineClass(line, where, lineClass) | ||||||
|   }-*/; |   }-*/; | ||||||
| @@ -168,7 +168,7 @@ public class CodeMirror extends JavaScriptObject { | |||||||
|     removeLineClassNative(line, where.value(), className); |     removeLineClassNative(line, where.value(), className); | ||||||
|   } |   } | ||||||
|  |  | ||||||
|   private final native void removeLineClassNative(LineHandle line, String where, |   private native void removeLineClassNative(LineHandle line, String where, | ||||||
|       String lineClass) /*-{ |       String lineClass) /*-{ | ||||||
|     this.removeLineClass(line, where, lineClass) |     this.removeLineClass(line, where, lineClass) | ||||||
|   }-*/; |   }-*/; | ||||||
|   | |||||||
| @@ -30,7 +30,7 @@ import java.util.Objects; | |||||||
| /** Additional features added to CodeMirror by Gerrit Code Review. */ | /** Additional features added to CodeMirror by Gerrit Code Review. */ | ||||||
| public class Extras { | public class Extras { | ||||||
|   static final native Extras get(CodeMirror c) /*-{ return c.gerritExtras }-*/; |   static final native Extras get(CodeMirror c) /*-{ return c.gerritExtras }-*/; | ||||||
|   private static final native void set(CodeMirror c, Extras e) |   private static native void set(CodeMirror c, Extras e) | ||||||
|   /*-{ c.gerritExtras = e }-*/; |   /*-{ c.gerritExtras = e }-*/; | ||||||
|  |  | ||||||
|   static void attach(CodeMirror c) { |   static void attach(CodeMirror c) { | ||||||
|   | |||||||
| @@ -21,7 +21,7 @@ import com.google.gwt.resources.client.DataResource.DoNotEmbed; | |||||||
| import com.google.gwt.resources.client.ExternalTextResource; | import com.google.gwt.resources.client.ExternalTextResource; | ||||||
|  |  | ||||||
| interface Lib extends ClientBundle { | interface Lib extends ClientBundle { | ||||||
|   final Lib I = GWT.create(Lib.class); |   Lib I = GWT.create(Lib.class); | ||||||
|  |  | ||||||
|   @Source("cm.css") |   @Source("cm.css") | ||||||
|   ExternalTextResource css(); |   ExternalTextResource css(); | ||||||
|   | |||||||
| @@ -258,7 +258,7 @@ public class ModeInfo extends JavaScriptObject { | |||||||
|   public final native JsArrayString mimes() |   public final native JsArrayString mimes() | ||||||
|   /*-{ return this.mimes || [this.mime] }-*/; |   /*-{ return this.mimes || [this.mime] }-*/; | ||||||
|  |  | ||||||
|   private final native JsArrayString ext() |   private native JsArrayString ext() | ||||||
|   /*-{ return this.ext || [] }-*/; |   /*-{ return this.ext || [] }-*/; | ||||||
|  |  | ||||||
|   protected ModeInfo() { |   protected ModeInfo() { | ||||||
|   | |||||||
| @@ -20,7 +20,7 @@ import com.google.gwt.resources.client.DataResource; | |||||||
| import com.google.gwt.resources.client.DataResource.DoNotEmbed; | import com.google.gwt.resources.client.DataResource.DoNotEmbed; | ||||||
|  |  | ||||||
| public interface Modes extends ClientBundle { | public interface Modes extends ClientBundle { | ||||||
|   public static final Modes I = GWT.create(Modes.class); |   Modes I = GWT.create(Modes.class); | ||||||
|  |  | ||||||
|   @Source("apl.js") @DoNotEmbed DataResource apl(); |   @Source("apl.js") @DoNotEmbed DataResource apl(); | ||||||
|   @Source("asciiarmor.js") @DoNotEmbed DataResource asciiarmor(); |   @Source("asciiarmor.js") @DoNotEmbed DataResource asciiarmor(); | ||||||
|   | |||||||
| @@ -19,7 +19,7 @@ import com.google.gwt.resources.client.ClientBundle; | |||||||
| import com.google.gwt.resources.client.ExternalTextResource; | import com.google.gwt.resources.client.ExternalTextResource; | ||||||
|  |  | ||||||
| public interface Themes extends ClientBundle { | public interface Themes extends ClientBundle { | ||||||
|   public static final Themes I = GWT.create(Themes.class); |   Themes I = GWT.create(Themes.class); | ||||||
|  |  | ||||||
|   @Source("eclipse.css") ExternalTextResource eclipse(); |   @Source("eclipse.css") ExternalTextResource eclipse(); | ||||||
|   @Source("elegant.css") ExternalTextResource elegant(); |   @Source("elegant.css") ExternalTextResource elegant(); | ||||||
|   | |||||||
| @@ -94,7 +94,7 @@ public final class Plugin extends JavaScriptObject { | |||||||
|     screen(token, wrap(entry)); |     screen(token, wrap(entry)); | ||||||
|   } |   } | ||||||
|  |  | ||||||
|   private final native void screen(String t, JavaScriptObject e) |   private native void screen(String t, JavaScriptObject e) | ||||||
|   /*-{ this.screen(t, e) }-*/; |   /*-{ this.screen(t, e) }-*/; | ||||||
|  |  | ||||||
|   /** |   /** | ||||||
| @@ -109,7 +109,7 @@ public final class Plugin extends JavaScriptObject { | |||||||
|     screenRegex(regex, wrap(entry)); |     screenRegex(regex, wrap(entry)); | ||||||
|   } |   } | ||||||
|  |  | ||||||
|   private final native void screenRegex(String p, JavaScriptObject e) |   private native void screenRegex(String p, JavaScriptObject e) | ||||||
|   /*-{ this.screen(new $wnd.RegExp(p), e) }-*/; |   /*-{ this.screen(new $wnd.RegExp(p), e) }-*/; | ||||||
|  |  | ||||||
|   /** |   /** | ||||||
| @@ -122,7 +122,7 @@ public final class Plugin extends JavaScriptObject { | |||||||
|     settingsScreen(token, menu, wrap(entry)); |     settingsScreen(token, menu, wrap(entry)); | ||||||
|   } |   } | ||||||
|  |  | ||||||
|   private final native void settingsScreen(String t, String m, JavaScriptObject e) |   private native void settingsScreen(String t, String m, JavaScriptObject e) | ||||||
|   /*-{ this.settingsScreen(t, m, e) }-*/; |   /*-{ this.settingsScreen(t, m, e) }-*/; | ||||||
|  |  | ||||||
|   /** |   /** | ||||||
| @@ -136,7 +136,7 @@ public final class Plugin extends JavaScriptObject { | |||||||
|     panel(extensionPoint.name(), wrap(entry)); |     panel(extensionPoint.name(), wrap(entry)); | ||||||
|   } |   } | ||||||
|  |  | ||||||
|   private final native void panel(String i, JavaScriptObject e) |   private native void panel(String i, JavaScriptObject e) | ||||||
|   /*-{ this.panel(i, e) }-*/; |   /*-{ this.panel(i, e) }-*/; | ||||||
|  |  | ||||||
|   protected Plugin() { |   protected Plugin() { | ||||||
| @@ -144,17 +144,17 @@ public final class Plugin extends JavaScriptObject { | |||||||
|  |  | ||||||
|   native void _initialized() /*-{ this._success = true }-*/; |   native void _initialized() /*-{ this._success = true }-*/; | ||||||
|   native void _loaded() /*-{ this._loadedGwt() }-*/; |   native void _loaded() /*-{ this._loadedGwt() }-*/; | ||||||
|   private static final native Plugin install(String u) |   private static native Plugin install(String u) | ||||||
|   /*-{ return $wnd.Gerrit.installGwt(u) }-*/; |   /*-{ return $wnd.Gerrit.installGwt(u) }-*/; | ||||||
|  |  | ||||||
|   private static final native JavaScriptObject wrap(Screen.EntryPoint b) /*-{ |   private static native JavaScriptObject wrap(Screen.EntryPoint b) /*-{ | ||||||
|     return $entry(function(c){ |     return $entry(function(c){ | ||||||
|       b.@com.google.gerrit.plugin.client.screen.Screen.EntryPoint::onLoad(Lcom/google/gerrit/plugin/client/screen/Screen;)( |       b.@com.google.gerrit.plugin.client.screen.Screen.EntryPoint::onLoad(Lcom/google/gerrit/plugin/client/screen/Screen;)( | ||||||
|         @com.google.gerrit.plugin.client.screen.Screen::new(Lcom/google/gerrit/plugin/client/screen/Screen$Context;)(c)); |         @com.google.gerrit.plugin.client.screen.Screen::new(Lcom/google/gerrit/plugin/client/screen/Screen$Context;)(c)); | ||||||
|     }); |     }); | ||||||
|   }-*/; |   }-*/; | ||||||
|  |  | ||||||
|   private static final native JavaScriptObject wrap(Panel.EntryPoint b) /*-{ |   private static native JavaScriptObject wrap(Panel.EntryPoint b) /*-{ | ||||||
|     return $entry(function(c){ |     return $entry(function(c){ | ||||||
|       b.@com.google.gerrit.plugin.client.extension.Panel.EntryPoint::onLoad(Lcom/google/gerrit/plugin/client/extension/Panel;)( |       b.@com.google.gerrit.plugin.client.extension.Panel.EntryPoint::onLoad(Lcom/google/gerrit/plugin/client/extension/Panel;)( | ||||||
|         @com.google.gerrit.plugin.client.extension.Panel::new(Lcom/google/gerrit/plugin/client/extension/Panel$Context;)(c)); |         @com.google.gerrit.plugin.client.extension.Panel::new(Lcom/google/gerrit/plugin/client/extension/Panel$Context;)(c)); | ||||||
|   | |||||||
| @@ -23,7 +23,7 @@ public interface EmailExpander { | |||||||
|  |  | ||||||
|   String expand(String user); |   String expand(String user); | ||||||
|  |  | ||||||
|   public static class None implements EmailExpander { |   class None implements EmailExpander { | ||||||
|     public static final None INSTANCE = new None(); |     public static final None INSTANCE = new None(); | ||||||
|  |  | ||||||
|     public static boolean canHandle(final String fmt) { |     public static boolean canHandle(final String fmt) { | ||||||
| @@ -44,7 +44,7 @@ public interface EmailExpander { | |||||||
|     } |     } | ||||||
|   } |   } | ||||||
|  |  | ||||||
|   public static class Simple implements EmailExpander { |   class Simple implements EmailExpander { | ||||||
|     private static final String PLACEHOLDER = "{0}"; |     private static final String PLACEHOLDER = "{0}"; | ||||||
|  |  | ||||||
|     public static boolean canHandle(final String fmt) { |     public static boolean canHandle(final String fmt) { | ||||||
|   | |||||||
| @@ -24,7 +24,7 @@ import java.util.Set; | |||||||
|  * the presence of a user in a particular group. |  * the presence of a user in a particular group. | ||||||
|  */ |  */ | ||||||
| public interface GroupMembership { | public interface GroupMembership { | ||||||
|   public static final GroupMembership EMPTY = |   GroupMembership EMPTY = | ||||||
|       new ListGroupMembership(Collections.<AccountGroup.UUID>emptySet()); |       new ListGroupMembership(Collections.<AccountGroup.UUID>emptySet()); | ||||||
|  |  | ||||||
|   /** |   /** | ||||||
|   | |||||||
| @@ -32,6 +32,6 @@ public interface AccountExternalIdCreator { | |||||||
|    * |    * | ||||||
|    * @return a list of external identifiers, or an empty list. |    * @return a list of external identifiers, or an empty list. | ||||||
|    */ |    */ | ||||||
|   public List<AccountExternalId> create(Account.Id id, String username, |   List<AccountExternalId> create(Account.Id id, String username, | ||||||
|       String email); |       String email); | ||||||
| } | } | ||||||
|   | |||||||
| @@ -18,7 +18,7 @@ public interface PersistentCache { | |||||||
|  |  | ||||||
|   DiskStats diskStats(); |   DiskStats diskStats(); | ||||||
|  |  | ||||||
|   public static class DiskStats { |   class DiskStats { | ||||||
|     private final long size; |     private final long size; | ||||||
|     private final long space; |     private final long space; | ||||||
|     private final long hitCount; |     private final long hitCount; | ||||||
|   | |||||||
| @@ -23,7 +23,7 @@ import org.eclipse.jgit.lib.Repository; | |||||||
|  |  | ||||||
| /** Cache for mergeability of commits into destination branches. */ | /** Cache for mergeability of commits into destination branches. */ | ||||||
| public interface MergeabilityCache { | public interface MergeabilityCache { | ||||||
|   public static class NotImplemented implements MergeabilityCache { |   class NotImplemented implements MergeabilityCache { | ||||||
|     @Override |     @Override | ||||||
|     public boolean get(ObjectId commit, Ref intoRef, SubmitType submitType, |     public boolean get(ObjectId commit, Ref intoRef, SubmitType submitType, | ||||||
|         String mergeStrategy, Branch.NameKey dest, Repository repo) { |         String mergeStrategy, Branch.NameKey dest, Repository repo) { | ||||||
|   | |||||||
| @@ -15,7 +15,7 @@ | |||||||
| package com.google.gerrit.server.git; | package com.google.gerrit.server.git; | ||||||
|  |  | ||||||
| public interface QueueProvider { | public interface QueueProvider { | ||||||
|   public static enum QueueType { |   enum QueueType { | ||||||
|     INTERACTIVE, BATCH |     INTERACTIVE, BATCH | ||||||
|   } |   } | ||||||
|  |  | ||||||
|   | |||||||
| @@ -39,7 +39,7 @@ public interface EmailTokenVerifier { | |||||||
|   ParsedToken decode(String tokenString) throws InvalidTokenException; |   ParsedToken decode(String tokenString) throws InvalidTokenException; | ||||||
|  |  | ||||||
|   /** Exception thrown when a token does not parse correctly. */ |   /** Exception thrown when a token does not parse correctly. */ | ||||||
|   public static class InvalidTokenException extends Exception { |   class InvalidTokenException extends Exception { | ||||||
|     private static final long serialVersionUID = 1L; |     private static final long serialVersionUID = 1L; | ||||||
|  |  | ||||||
|     public InvalidTokenException() { |     public InvalidTokenException() { | ||||||
| @@ -52,7 +52,7 @@ public interface EmailTokenVerifier { | |||||||
|   } |   } | ||||||
|  |  | ||||||
|   /** Pair returned from decode to provide the data used during encode. */ |   /** Pair returned from decode to provide the data used during encode. */ | ||||||
|   public static class ParsedToken { |   class ParsedToken { | ||||||
|     private final Account.Id accountId; |     private final Account.Id accountId; | ||||||
|     private final String emailAddress; |     private final String emailAddress; | ||||||
|  |  | ||||||
|   | |||||||
| @@ -74,7 +74,7 @@ public interface PluginContentScanner { | |||||||
|    * provided by a plugin to extend an existing |    * provided by a plugin to extend an existing | ||||||
|    * extension point in Gerrit. |    * extension point in Gerrit. | ||||||
|    */ |    */ | ||||||
|   public static class ExtensionMetaData { |   class ExtensionMetaData { | ||||||
|     public final String className; |     public final String className; | ||||||
|     public final String annotationValue; |     public final String annotationValue; | ||||||
|  |  | ||||||
|   | |||||||
| @@ -37,7 +37,7 @@ public interface ServerPluginProvider { | |||||||
|   /** |   /** | ||||||
|    * Descriptor of the Plugin that ServerPluginProvider has to load. |    * Descriptor of the Plugin that ServerPluginProvider has to load. | ||||||
|    */ |    */ | ||||||
|   public class PluginDescription { |   class PluginDescription { | ||||||
|     public final PluginUser user; |     public final PluginUser user; | ||||||
|     public final String canonicalUrl; |     public final String canonicalUrl; | ||||||
|     public final Path dataDir; |     public final Path dataDir; | ||||||
|   | |||||||
| @@ -29,7 +29,7 @@ public interface OutgoingEmailValidationListener { | |||||||
|   /** |   /** | ||||||
|    * Arguments supplied to validateOutgoingEmail. |    * Arguments supplied to validateOutgoingEmail. | ||||||
|    */ |    */ | ||||||
|   public static class Args { |   class Args { | ||||||
|     // in arguments |     // in arguments | ||||||
|     public String messageClass; |     public String messageClass; | ||||||
|  |  | ||||||
|   | |||||||
| @@ -27,7 +27,7 @@ import java.lang.annotation.Target; | |||||||
| @Target({ElementType.TYPE}) | @Target({ElementType.TYPE}) | ||||||
| @Retention(RUNTIME) | @Retention(RUNTIME) | ||||||
| public @interface CommandMetaData { | public @interface CommandMetaData { | ||||||
|   public enum Mode { |   enum Mode { | ||||||
|     MASTER, MASTER_OR_SLAVE; |     MASTER, MASTER_OR_SLAVE; | ||||||
|     public boolean isSupported(boolean slaveMode) { |     public boolean isSupported(boolean slaveMode) { | ||||||
|       return this == MASTER_OR_SLAVE || !slaveMode; |       return this == MASTER_OR_SLAVE || !slaveMode; | ||||||
|   | |||||||
| @@ -93,6 +93,8 @@ edited to remove noisy warnings. | |||||||
|       <property name="tokens" value="BAND, BOR, BSR, BXOR, DIV, EQUAL, GE, GT, LAND, LE, LITERAL_INSTANCEOF, LOR, LT, MINUS, MOD, NOT_EQUAL, PLUS, QUESTION, SL, SR, STAR "/> |       <property name="tokens" value="BAND, BOR, BSR, BXOR, DIV, EQUAL, GE, GT, LAND, LE, LITERAL_INSTANCEOF, LOR, LT, MINUS, MOD, NOT_EQUAL, PLUS, QUESTION, SL, SR, STAR "/> | ||||||
|       <metadata name="net.sf.eclipsecs.core.lastEnabledSeverity" value="inherit"/> |       <metadata name="net.sf.eclipsecs.core.lastEnabledSeverity" value="inherit"/> | ||||||
|     </module> |     </module> | ||||||
|  |     <module name="RedundantImport"/> | ||||||
|  |     <module name="RedundantModifier"/> | ||||||
|   </module> |   </module> | ||||||
|   <module name="FileTabCharacter"> |   <module name="FileTabCharacter"> | ||||||
|     <property name="severity" value="ignore"/> |     <property name="severity" value="ignore"/> | ||||||
|   | |||||||
		Reference in New Issue
	
	Block a user
	 David Pursehouse
					David Pursehouse