From 1014b5afa83dd93edd3bd486721dd609b2b547ec Mon Sep 17 00:00:00 2001 From: David Pursehouse Date: Thu, 27 Jun 2019 16:51:26 +0900 Subject: [PATCH] ReceiveCommits: Don't instantiate BranchCommitValidator repeatedly Change-Id: Ifd842896a369af9d7ffe04885d62e8d2c203faaa --- java/com/google/gerrit/server/git/receive/ReceiveCommits.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/java/com/google/gerrit/server/git/receive/ReceiveCommits.java b/java/com/google/gerrit/server/git/receive/ReceiveCommits.java index b98cabcd95..2fc2205189 100644 --- a/java/com/google/gerrit/server/git/receive/ReceiveCommits.java +++ b/java/com/google/gerrit/server/git/receive/ReceiveCommits.java @@ -3033,6 +3033,7 @@ class ReceiveCommits { } } + BranchCommitValidator validator = commitValidatorFactory.create(projectState, branch, user); RevWalk walk = receivePack.getRevWalk(); walk.reset(); walk.sort(RevSort.NONE); @@ -3059,7 +3060,6 @@ class ReceiveCommits { continue; } - BranchCommitValidator validator = commitValidatorFactory.create(projectState, branch, user); if (!validator.validCommit( walk.getObjectReader(), cmd, c, false, messages, rejectCommits, null, skipValidation)) { break;