diff --git a/java/com/google/gerrit/httpd/auth/openid/OpenIdServiceImpl.java b/java/com/google/gerrit/httpd/auth/openid/OpenIdServiceImpl.java index 86ed398196..fd42e82b67 100644 --- a/java/com/google/gerrit/httpd/auth/openid/OpenIdServiceImpl.java +++ b/java/com/google/gerrit/httpd/auth/openid/OpenIdServiceImpl.java @@ -487,10 +487,15 @@ class OpenIdServiceImpl { final StringBuilder rdr = new StringBuilder(); rdr.append(urlProvider.get(req)); + String nextToken = Url.decode(token); if (isNew && !token.startsWith(PageLinks.REGISTER + "/")) { rdr.append('#' + PageLinks.REGISTER); + if (nextToken.startsWith("#")) { + // Need to strip the leading # off the token to fix registration page redirect + nextToken = nextToken.substring(1); + } } - rdr.append(Url.decode(token)); + rdr.append(nextToken); rsp.sendRedirect(rdr.toString()); } diff --git a/java/com/google/gerrit/lucene/LuceneVersionManager.java b/java/com/google/gerrit/lucene/LuceneVersionManager.java index c7c802f07a..ce92432789 100644 --- a/java/com/google/gerrit/lucene/LuceneVersionManager.java +++ b/java/com/google/gerrit/lucene/LuceneVersionManager.java @@ -78,7 +78,7 @@ public class LuceneVersionManager extends VersionManager { Path p = getDir(sitePaths, def.getName(), schema); boolean isDir = Files.isDirectory(p); if (Files.exists(p) && !isDir) { - log.warn("Not a directory: %s", p.toAbsolutePath()); + log.warn("Not a directory: {}", p.toAbsolutePath()); } int v = schema.getVersion(); versions.put(v, new Version<>(schema, v, isDir, cfg.getReady(def.getName(), v)));