opendev/gerrit
Code Issues Proposed changes

Make the file path for the replacement of a robot comment explicit

Browse Source 
Up to now, the file path was implicitly limited to the file on which
the robot comment was placed. This restriction will be relaxed in the
future. In order to not break systems which use the fix suggestions at
that (later) point in time, the mandatory field 'path' is introduced
with this change.

Change-Id: I73875b97bf844dee927720765046161bbd888c02
This commit is contained in:
Alice Kober-Sotzek
2016-12-19 14:53:40 +01:00
parent 81f334a77f
commit 110f60f082
7 changed files with 106 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
gerrit-reviewdb/src/main/java/com/google/gerrit/reviewdb/client/FixReplacement.java
View File

@@ -15,10 +15,12 @@
package com.google.gerrit.reviewdb.client;
public class FixReplacement {
public String path;
public Comment.Range range;
public String replacement;
public FixReplacement(Comment.Range range, String replacement) {
public FixReplacement(String path, Comment.Range range, String replacement) {
this.path = path;
this.range = range;
this.replacement = replacement;
}
@@ -26,7 +28,8 @@ public class FixReplacement {
@Override
public String toString() {
return "FixReplacement{" +
"range=" + range +
"path='" + path + '\'' +
", range=" + range +
", replacement='" + replacement + '\'' +
'}';
}