opendev/gerrit
Code Issues Proposed changes

Fix dynamic registration of libraries

Browse Source 
Bouncy Castle was not properly registering after downloading because
LibraryDownloader was attempting to add a single Path.  Since Path
is Iterable, the overload never worked.  Switching all instances of
loadJARs() to use Arrays.asList() explicitly resolves this problem.

This appears to have been introduced by the refactor in I4c9902f13e.

Change-Id: Ic773ff01914ce806e3ff6961179e191c2d32a729
This commit is contained in:
Doug Kelly
2015-10-19 13:19:31 -05:00
parent b0019cdcbb
commit 11362e0959
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
gerrit-common/src/main/java/com/google/gerrit/common/IoUtil.java
View File

@@ -26,6 +26,7 @@ import java.net.URL;
import java.net.URLClassLoader;
import java.nio.file.Path;
import java.util.Arrays;
import java.util.Collections;
import java.util.Set;
public final class IoUtil {
@@ -86,8 +87,8 @@ public final class IoUtil {
}
}
public static void loadJARs(Path... jars) {
loadJARs(Arrays.asList(jars));
public static void loadJARs(Path jar) {
loadJARs(Collections.singleton(jar));
}
private static UnsupportedOperationException noAddURL(String m, Throwable why) {