opendev/gerrit
Code Issues Proposed changes

OutgoingEmail: Reduce visibility of methods

Browse Source 
Methods only used by derived classes may be reduced to protected
visibility.

Change-Id: Icad3f849c9e2bf8c8d2d1ecd681560a06a037fd3
This commit is contained in:
David Pursehouse
2018-06-20 12:33:55 +09:00
parent f2b2481a0d
commit 11a98d0c92
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
gerrit-server/src/main/java/com/google/gerrit/server/mail/send/OutgoingEmail.java
View File

@@ -362,7 +362,7 @@ public abstract class OutgoingEmail {
* @param accountId user to fetch.
* @return name/email of account; Anonymous Coward if unset or the server identity if null.
*/
public String getNameEmailFor(@Nullable Account.Id accountId) {
protected String getNameEmailFor(@Nullable Account.Id accountId) {
if (accountId == null) {
return String.format(
"%s <%s>", args.gerritPersonIdent.getName(), args.gerritPersonIdent.getEmailAddress());
@@ -379,7 +379,7 @@ public abstract class OutgoingEmail {
* @return name/email of account, username, or null if unset.
*/
@Nullable
public String getUserNameEmailFor(@Nullable Account.Id accountId) {
protected String getUserNameEmailFor(@Nullable Account.Id accountId) {
if (accountId == null) {
return null;
}