opendev/gerrit
Code Issues Proposed changes

Don't display Download link for /COMMIT_MSG

Browse Source 
The commit message file is special, it doesn't actually exist and
cannot be downloaded. Don't offer the download link in the side by
side viewer.

Bug: issue 1352
Change-Id: Ie31afa570d1b84b62daf13b64cae6490657a8870
This commit is contained in:
Shawn O. Pearce
2012-04-24 09:12:41 -07:00
parent 1eee2c9d8f
commit 11e9cac281
1 changed files with 15 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
gerrit-gwtui/src/main/java/com/google/gerrit/client/patches/SideBySideTable.java
View File

@@ -262,6 +262,8 @@ public class SideBySideTable extends AbstractPatchContentTable {
}
private void appendHeader(PatchScript script, final SafeHtmlBuilder m) {
boolean isCommitMessage = Patch.COMMIT_MSG.equals(script.getNewName());
m.openTr();
m.openTd();
@@ -283,12 +285,14 @@ public class SideBySideTable extends AbstractPatchContentTable {
} else {
m.append(PatchUtil.C.patchHeaderOld());
}
m.br();
if (0 < script.getA().size()) {
if (idSideA == null) {
downloadLink(m, patchKey, "1");
} else {
downloadLink(m, new Patch.Key(idSideA, patchKey.get()), "0");
if (!isCommitMessage) {
m.br();
if (0 < script.getA().size()) {
if (idSideA == null) {
downloadLink(m, patchKey, "1");
} else {
downloadLink(m, new Patch.Key(idSideA, patchKey.get()), "0");
}
}
}
m.closeTd();
@@ -297,9 +301,11 @@ public class SideBySideTable extends AbstractPatchContentTable {
m.setStyleName(Gerrit.RESOURCES.css().fileColumnHeader());
m.setAttribute("width", "50%");
m.append(PatchUtil.C.patchHeaderNew());
m.br();
if (0 < script.getB().size()) {
downloadLink(m, new Patch.Key(idSideB, patchKey.get()), "0");
if (!isCommitMessage) {
m.br();
if (0 < script.getB().size()) {
downloadLink(m, new Patch.Key(idSideB, patchKey.get()), "0");
}
}
m.closeTd();