opendev/gerrit
Code Issues Proposed changes

AccountCreator: Better error message on invalid group

Browse Source 
Change-Id: I44465c9c3867c64ccdf430d0a1ed75982daa005b
This commit is contained in:
Dave Borowitz
2016-10-06 12:48:31 -04:00
parent d76ac5a619
commit 1254f3018f
1 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gerrit-acceptance-framework/src/test/java/com/google/gerrit/acceptance/AccountCreator.java
View File

@@ -14,6 +14,7 @@
package com.google.gerrit.acceptance; package com.google.gerrit.acceptance;
import static com.google.common.base.Preconditions.checkArgument;
import static com.google.common.base.Preconditions.checkNotNull; import static com.google.common.base.Preconditions.checkNotNull;
import static java.nio.charset.StandardCharsets.US_ASCII; import static java.nio.charset.StandardCharsets.US_ASCII;
@@ -104,6 +105,7 @@ public class AccountCreator {
for (String n : groups) { for (String n : groups) {
AccountGroup.NameKey k = new AccountGroup.NameKey(n); AccountGroup.NameKey k = new AccountGroup.NameKey(n);
AccountGroup g = groupCache.get(k); AccountGroup g = groupCache.get(k);
checkArgument(g != null, "group not found: %s", n);
AccountGroupMember m = AccountGroupMember m =
new AccountGroupMember(new AccountGroupMember.Key(id, g.getId())); new AccountGroupMember(new AccountGroupMember.Key(id, g.getId()));
db.accountGroupMembers().insert(Collections.singleton(m)); db.accountGroupMembers().insert(Collections.singleton(m));