opendev/gerrit
Code Issues Proposed changes

Eliminate "invalid member type qualification" warnings

Browse Source 
These warnings are spurious in that the member types are correctly
qualified within the appropriate scope, but Eclipse reports them
to be consistent with javadoc[1], which has a long-standing bug.
Unfortunately, they also cannot be turned off.

For references to common Gerrit key/id types (e.g. Account.Id), just
use @code, as the @link isn't providing much value. For references
where the link might be more useful, use the fully-qualified type.

[1] https://bugs.eclipse.org/bugs/show_bug.cgi?id=371420

Change-Id: I0baca75c20e69c51d3bf251aa818460d30e3d631
This commit is contained in:
Dave Borowitz 2013-12-09 12:19:17 -08:00 committed by Shawn Pearce
parent 826a7b6dda
commit 12e79a4edd
4 changed files with 12 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
gerrit-common/src/main/java/com/google/gerrit/common/data/AccountInfoCache.java
View File

@ -20,7 +20,7 @@ import java.util.Collections;
import java.util.HashMap;
import java.util.Map;
/** In-memory table of {@link AccountInfo}, indexed by {@link Account.Id}. */
/** In-memory table of {@link AccountInfo}, indexed by {@code Account.Id}. */
public class AccountInfoCache {
private static final AccountInfoCache EMPTY;
static {

2
gerrit-common/src/main/java/com/google/gerrit/common/data/GroupInfoCache.java
View File

@ -20,7 +20,7 @@ import java.util.Collections;
import java.util.HashMap;
import java.util.Map;
/** In-memory table of {@link GroupInfo}, indexed by {@link AccountGroup.Id}. */
/** In-memory table of {@link GroupInfo}, indexed by {@code AccountGroup.Id}. */
public class GroupInfoCache {
private static final GroupInfoCache EMPTY;
static {

13
gerrit-gwtexpui/src/main/java/com/google/gwtexpui/safehtml/client/HighlightSuggestOracle.java
View File

@ -23,8 +23,10 @@ import java.util.ArrayList;
* <p>
* Suggestions supplied by the implementation of
* {@link #onRequestSuggestions(Request, Callback)} are modified to wrap all
* occurrences of the {@link SuggestOracle.Request#getQuery()} substring in HTML
* {@code &lt;strong&gt;} tags, so they can be emphasized to the user.
* occurrences of the
* {@link com.google.gwt.user.client.ui.SuggestOracle.Request#getQuery()}
* substring in HTML {@code &lt;strong&gt;} tags, so they can be emphasized to
* the user.
*/
public abstract class HighlightSuggestOracle extends SuggestOracle {
private static String escape(String ds) {
@ -57,9 +59,10 @@ public abstract class HighlightSuggestOracle extends SuggestOracle {
}
/**
* @return true if {@link SuggestOracle.Suggestion#getDisplayString()} returns
* HTML; false if the text must be escaped before evaluating in an
* HTML like context.
* @return true if
* {@link com.google.gwt.user.client.ui.SuggestOracle.Suggestion#getDisplayString()}
* returns HTML; false if the text must be escaped before evaluating
* in an HTML like context.
*/
protected boolean isHTML() {
return false;

4
gerrit-server/src/test/java/com/google/gerrit/server/git/SubmoduleOpTest.java
View File

@ -828,7 +828,7 @@ public class SubmoduleOpTest extends LocalDiskRepositoryTestCase {
* </p>
*
* @param gitModulesFileContent The .gitmodules file content.
* @param mergedBranch The {@link Branch.NameKey} instance representing the
* @param mergedBranch The {@code Branch.NameKey} instance representing the
* project/branch the commit was merged.
* @param extractedSubscriptions The subscription rows extracted from
* gitmodules file.
@ -854,7 +854,7 @@ public class SubmoduleOpTest extends LocalDiskRepositoryTestCase {
* </p>
*
* @param gitModulesFileContent The .gitmodules file content.
* @param mergedBranch The {@link Branch.NameKey} instance representing the
* @param mergedBranch The {@code Branch.NameKey} instance representing the
* project/branch the commit was merged.
* @param extractedSubscriptions The subscription rows extracted from
* gitmodules file.