opendev/gerrit
Code Issues Proposed changes

Merge "Small cleanup in gr-change-list-item"

Browse Source
This commit is contained in:
Dave Borowitz 2016-01-05 18:33:55 +00:00 committed by Gerrit Code Review
commit 130f6eb6e8
1 changed files with 10 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
polygerrit-ui/app/elements/gr-change-list-item.html
View File

@ -161,11 +161,11 @@ limitations under the License.
if (codeReview.approved) {
return '✓';
}
if (codeReview.value == 1) {
return '+1';
if (codeReview.value > 0) {
return '+' + codeReview.value;
}
if (codeReview.value == -1) {
return '-1';
if (codeReview.value < 0) {
return codeReview.value;
}
return '';
},
@ -189,9 +189,12 @@ limitations under the License.
},
_computeOwnerTitle: function(owner) {
if (!owner) { return ''; }
// TODO: Is this safe from XSS attacks?
return owner.name + ' <' + owner.email + '>';
if (!owner || !owner.name) { return ''; }
var result = util.escapeHTML(owner.name);
if (owner.email) {
result += ' <' + util.escapeHTML(owner.email) + '>';
}
return result;
},
_computeProjectURL: function(project) {