opendev/gerrit
Code Issues Proposed changes

Revert "Add submit_action to ChangeInfo"

Browse Source 
This reverts commit 0efb17e053.
This is already available on a revision as /submit_type.
Clients that need the data should fetch it from there.

Change-Id: Ia6ba213117c4a5c2a09d1129ab741871dfd31a22
This commit is contained in:
Shawn Pearce
2013-07-12 19:01:47 +00:00
parent 0efb17e053
commit 13641f4f46
3 changed files with 0 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
gerrit-server/src/main/java/com/google/gerrit/server/change/ChangeJson.java
View File

@@ -45,7 +45,6 @@ import com.google.gerrit.common.data.LabelValue;
import com.google.gerrit.common.data.Permission;
import com.google.gerrit.common.data.PermissionRange;
import com.google.gerrit.common.data.SubmitRecord;
import com.google.gerrit.common.data.SubmitTypeRecord;
import com.google.gerrit.extensions.restapi.Url;
import com.google.gerrit.reviewdb.client.Account;
import com.google.gerrit.reviewdb.client.Change;
@@ -277,15 +276,6 @@ public class ChangeJson {
}
}
}
if (in.getStatus().isOpen()
&& has(ListChangesOption.DETAILED_LABELS)
&& out.current_revision != null) {
SubmitTypeRecord r = cd.changeControl().getSubmitTypeRecord(
db.get(), cd.currentPatchSet(db), cd);
if (r.status == SubmitTypeRecord.Status.OK) {
out.submit_action = r.type.name();
}
}
}
lastControl = null;
@@ -851,7 +841,6 @@ public class ChangeJson {
public String changeId;
public String subject;
Change.Status status;
String submit_action;
Timestamp created;
Timestamp updated;
Boolean starred;