opendev/gerrit
Code Issues Proposed changes

Allow to use GWTORM Key classes in plugins

Browse Source 
To implement dedicated databases in plugin based on GWTORM, keys are
needed. Currently they can only be used from classes located in the
same package.  Changing the modifiers to public allow the plugin to
reuse them, without keep using the same package name as in Gerrit core.

Change-Id: I5f321aa89dbb9b71945c4bc53151e3d5a26cce74
This commit is contained in:
David Ostrovsky
2015-11-13 14:25:17 -08:00
committed by David Pursehouse
parent 4a3b5baec2
commit 13b4b5082d
3 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gerrit-reviewdb/src/main/java/com/google/gerrit/reviewdb/client/Change.java
View File

@@ -106,7 +106,7 @@ public final class Change {
private static final long serialVersionUID = 1L; private static final long serialVersionUID = 1L;
@Column(id = 1) @Column(id = 1)
protected int id; public int id;
protected Id() { protected Id() {
} }

4
gerrit-reviewdb/src/main/java/com/google/gerrit/reviewdb/client/LabelId.java
View File

@@ -23,9 +23,9 @@ public class LabelId extends StringKey<com.google.gwtorm.client.Key<?>> {
public static final LabelId SUBMIT = new LabelId("SUBM"); public static final LabelId SUBMIT = new LabelId("SUBM");
@Column(id = 1) @Column(id = 1)
protected String id; public String id;
protected LabelId() { public LabelId() {
} }
public LabelId(final String n) { public LabelId(final String n) {

6
gerrit-reviewdb/src/main/java/com/google/gerrit/reviewdb/client/PatchSet.java
View File

@@ -32,12 +32,12 @@ public final class PatchSet {
private static final long serialVersionUID = 1L; private static final long serialVersionUID = 1L;
@Column(id = 1) @Column(id = 1)
protected Change.Id changeId; public Change.Id changeId;
@Column(id = 2) @Column(id = 2)
protected int patchSetId; public int patchSetId;
protected Id() { public Id() {
changeId = new Change.Id(); changeId = new Change.Id();
} }