opendev/gerrit
Code Issues Proposed changes

Merge "Show checks table upon clicking state chip"

Browse Source
This commit is contained in:
Ben Rohlfs
2019-07-02 16:28:22 +00:00
committed by Gerrit Code Review
parent c5a5cb3887 8a4f8a8c24
commit 13f75f1459
2 changed files with 12 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
polygerrit-ui/app/elements/change/gr-change-view/gr-change-view.html
View File

@@ -366,6 +366,7 @@ limitations under the License.
<div <div
id="mainContent" id="mainContent"
class="container" class="container"
on-show-checks-table="_handleShowChecksTable"
hidden$="{{_loading}}"> hidden$="{{_loading}}">
<div class$="[[_computeHeaderClass(_editMode)]]"> <div class$="[[_computeHeaderClass(_editMode)]]">
<div class="headerTitle"> <div class="headerTitle">

11
polygerrit-ui/app/elements/change/gr-change-view/gr-change-view.js
View File

@@ -417,6 +417,17 @@
this._dynamicTabContentEndpoints[selectedIndex - 1]; this._dynamicTabContentEndpoints[selectedIndex - 1];
}, },
_handleShowChecksTable(e) {
const idx = this._dynamicTabContentEndpoints.indexOf(e.detail.tab);
if (idx === -1) {
console.warn(e.detail.tab + ' tab not found');
return;
}
this.$$('#primaryTabs').selected = idx + 1;
this.$$('#primaryTabs').scrollIntoView();
this._handleFileTabChange();
},
_handleEditCommitMessage(e) { _handleEditCommitMessage(e) {
this._editingCommitMessage = true; this._editingCommitMessage = true;
this.$.commitMessageEditor.focusTextarea(); this.$.commitMessageEditor.focusTextarea();