opendev/gerrit
Code Issues Proposed changes

ReceiveCommits: Use result change from ChangeInserter

Browse Source 
The Change instance modified by ChangeInserter is no longer the same
instance as the one passed into the factory. The result from
getChange() is the one that has the change subject set from the new
patch set commit message, so this is the one we need to use in
ReceiveCommits.

Change-Id: Ie38b73d8979efdc02935fbe488141598b852ecf6
This commit is contained in:
Dave Borowitz 2015-12-22 16:57:41 -05:00
parent 4837ccb9fa
commit 1494cfc1af
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
gerrit-server/src/main/java/com/google/gerrit/server/git/ReceiveCommits.java
View File

@ -1716,9 +1716,9 @@ public class ReceiveCommits {
private class CreateRequest {
final RevCommit commit;
final Change change;
final ReceiveCommand cmd;
final ChangeInserter ins;
Change change;
boolean created;
Collection<String> groups;
@ -1808,6 +1808,7 @@ public class ReceiveCommits {
bu.execute();
}
created = true;
change = ins.getChange();
if (magicBranch != null && magicBranch.submit) {
submit(projectControl.controlFor(change), ps);