diff --git a/polygerrit-ui/app/behaviors/gr-change-table-behavior/gr-change-table-behavior.html b/polygerrit-ui/app/behaviors/gr-change-table-behavior/gr-change-table-behavior.html index aee9d7c137..ca955b36f8 100644 --- a/polygerrit-ui/app/behaviors/gr-change-table-behavior/gr-change-table-behavior.html +++ b/polygerrit-ui/app/behaviors/gr-change-table-behavior/gr-change-table-behavior.html @@ -19,22 +19,28 @@ limitations under the License. /** @polymerBehavior Gerrit.ChangeTableBehavior */ var ChangeTableBehavior = { - CHANGE_TABLE_COLUMNS: [ - 'Subject', - 'Status', - 'Owner', - 'Project', - 'Branch', - 'Updated', - 'Size', - ], + properties: { + columnNames: { + type: Array, + value: [ + 'Subject', + 'Status', + 'Owner', + 'Project', + 'Branch', + 'Updated', + 'Size', + ], + readOnly: true, + } + }, /** * Returns the complement to the given column array * @param {Array} columns */ getComplementColumns: function(columns) { - return this.CHANGE_TABLE_COLUMNS.filter(function(column) { + return this.columnNames.filter(function(column) { return columns.indexOf(column) === -1; }); }, diff --git a/polygerrit-ui/app/elements/change-list/gr-change-list-item/gr-change-list-item_test.html b/polygerrit-ui/app/elements/change-list/gr-change-list-item/gr-change-list-item_test.html index 3df613fa9e..68656436c6 100644 --- a/polygerrit-ui/app/elements/change-list/gr-change-list-item/gr-change-list-item_test.html +++ b/polygerrit-ui/app/elements/change-list/gr-change-list-item/gr-change-list-item_test.html @@ -151,7 +151,7 @@ limitations under the License. flushAsynchronousOperations(); - element.CHANGE_TABLE_COLUMNS.forEach(function(column) { + element.columnNames.forEach(function(column) { var elementClass = '.' + column.toLowerCase(); assert.isFalse(element.$$(elementClass).hidden); }); @@ -170,7 +170,7 @@ limitations under the License. flushAsynchronousOperations(); - element.CHANGE_TABLE_COLUMNS.forEach(function(column) { + element.columnNames.forEach(function(column) { var elementClass = '.' + column.toLowerCase(); assert.isFalse(element.$$(elementClass).hidden); }); @@ -188,7 +188,7 @@ limitations under the License. flushAsynchronousOperations(); - element.CHANGE_TABLE_COLUMNS.forEach(function(column) { + element.columnNames.forEach(function(column) { var elementClass = '.' + column.toLowerCase(); if (column === 'Project') { assert.isTrue(element.$$(elementClass).hidden); diff --git a/polygerrit-ui/app/elements/change-list/gr-change-list/gr-change-list.js b/polygerrit-ui/app/elements/change-list/gr-change-list/gr-change-list.js index 9f943dc4f1..425ea76623 100644 --- a/polygerrit-ui/app/elements/change-list/gr-change-list/gr-change-list.js +++ b/polygerrit-ui/app/elements/change-list/gr-change-list/gr-change-list.js @@ -111,18 +111,18 @@ _loadPreferences: function() { return this._getLoggedIn().then(function(loggedIn) { - this.changeTableColumns = this.CHANGE_TABLE_COLUMNS; + this.changeTableColumns = this.columnNames; if (!loggedIn) { this.showNumber = false; - this.visibleChangeTableColumns = this.CHANGE_TABLE_COLUMNS; + this.visibleChangeTableColumns = this.columnNames; return; } return this._getPreferences().then(function(preferences) { this.showNumber = !!(preferences && preferences.legacycid_in_change_table); this.visibleChangeTableColumns = preferences.change_table.length > 0 ? - preferences.change_table : this.CHANGE_TABLE_COLUMNS; + preferences.change_table : this.columnNames; }.bind(this)); }.bind(this)); }, diff --git a/polygerrit-ui/app/elements/change-list/gr-change-list/gr-change-list_test.html b/polygerrit-ui/app/elements/change-list/gr-change-list/gr-change-list_test.html index 7b0eeb9343..29b875729f 100644 --- a/polygerrit-ui/app/elements/change-list/gr-change-list/gr-change-list_test.html +++ b/polygerrit-ui/app/elements/change-list/gr-change-list/gr-change-list_test.html @@ -266,7 +266,7 @@ limitations under the License. }); test('all columns visible', function() { - element.CHANGE_TABLE_COLUMNS.forEach(function(column) { + element.columnNames.forEach(function(column) { var elementClass = '.' + element._lowerCase(column); assert.isFalse(element.$$(elementClass).hidden); }); diff --git a/polygerrit-ui/app/elements/settings/gr-change-table-editor/gr-change-table-editor.html b/polygerrit-ui/app/elements/settings/gr-change-table-editor/gr-change-table-editor.html index 2deb291133..e2488f429c 100644 --- a/polygerrit-ui/app/elements/settings/gr-change-table-editor/gr-change-table-editor.html +++ b/polygerrit-ui/app/elements/settings/gr-change-table-editor/gr-change-table-editor.html @@ -25,21 +25,19 @@ limitations under the License.