opendev/gerrit
Code Issues Proposed changes

CommitPredicate: Use static import for constants

Browse Source 
Instead of importing the whole package and then only using a
single constant from it.

Change-Id: I7c217334a9b70339af17ee5de32eae3073b37678
This commit is contained in:
David Pursehouse
2015-09-02 10:56:36 +09:00
parent 80702e40cb
commit 14cbd792f2
1 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
gerrit-server/src/main/java/com/google/gerrit/server/query/change/CommitPredicate.java
View File

@@ -14,25 +14,24 @@
package com.google.gerrit.server.query.change; package com.google.gerrit.server.query.change;
import static com.google.gerrit.server.index.ChangeField.COMMIT;
import static com.google.gerrit.server.index.ChangeField.EXACT_COMMIT; import static com.google.gerrit.server.index.ChangeField.EXACT_COMMIT;
import static org.eclipse.jgit.lib.Constants.OBJECT_ID_STRING_LENGTH;
import com.google.gerrit.reviewdb.client.PatchSet; import com.google.gerrit.reviewdb.client.PatchSet;
import com.google.gerrit.server.index.ChangeField;
import com.google.gerrit.server.index.FieldDef; import com.google.gerrit.server.index.FieldDef;
import com.google.gerrit.server.index.IndexPredicate; import com.google.gerrit.server.index.IndexPredicate;
import com.google.gerrit.server.index.Schema; import com.google.gerrit.server.index.Schema;
import com.google.gwtorm.server.OrmException; import com.google.gwtorm.server.OrmException;
import org.eclipse.jgit.lib.Constants;
class CommitPredicate extends IndexPredicate<ChangeData> { class CommitPredicate extends IndexPredicate<ChangeData> {
static FieldDef<ChangeData, ?> commitField(Schema<ChangeData> schema, static FieldDef<ChangeData, ?> commitField(Schema<ChangeData> schema,
String id) { String id) {
if (id.length() == Constants.OBJECT_ID_STRING_LENGTH if (id.length() == OBJECT_ID_STRING_LENGTH
&& schema.hasField(EXACT_COMMIT)) { && schema.hasField(EXACT_COMMIT)) {
return EXACT_COMMIT; return EXACT_COMMIT;
} }
return ChangeField.COMMIT; return COMMIT;
} }
CommitPredicate(Schema<ChangeData> schema, String id) { CommitPredicate(Schema<ChangeData> schema, String id) {