opendev/gerrit
Code Issues Proposed changes

cache.proto: Remove reference to ProtobufCodec in comments

Browse Source 
Change-Id: I6875181e743bd8a6eca491e4216a99db9cab612b
This commit is contained in:
Alice Kober-Sotzek
2018-12-14 16:06:41 +01:00
committed by Dave Borowitz
parent 9a2b06ed90
commit 14db531b94
1 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
proto/cache.proto
View File

@@ -61,10 +61,10 @@ message ChangeNotesKeyProto {
// were chosen ease of coding the initial implementation. In particular, where // were chosen ease of coding the initial implementation. In particular, where
// there already exists another serialization mechanism in Gerrit for // there already exists another serialization mechanism in Gerrit for
// serializing a particular field, we use that rather than defining a new proto // serializing a particular field, we use that rather than defining a new proto
// type. This includes ReviewDb types that can be serialized to proto using // type. This includes types that can be serialized to proto using
// ProtobufCodec as well as NoteDb and indexed types that are serialized using // ProtoConverters as well as NoteDb and indexed types that are serialized using
// JSON. We can always revisit this decision later, particularly when we // JSON. We can always revisit this decision later; it just requires bumping the
// eliminate the ReviewDb types; it just requires bumping the cache version. // cache version.
// //
// Note on nullability: there are a lot of nullable fields in ChangeNotesState // Note on nullability: there are a lot of nullable fields in ChangeNotesState
// and its dependencies. It's likely we could make some of them non-nullable, // and its dependencies. It's likely we could make some of them non-nullable,
@@ -134,10 +134,10 @@ message ChangeNotesStateProto {
repeated string hashtag = 5; repeated string hashtag = 5;
// Raw PatchSet proto as produced by ProtobufCodec. // Raw PatchSet proto as produced by PatchSetProtoConverter.
repeated bytes patch_set = 6; repeated bytes patch_set = 6;
// Raw PatchSetApproval proto as produced by ProtobufCodec. // Raw PatchSetApproval proto as produced by PatchSetApprovalProtoConverter.
repeated bytes approval = 7; repeated bytes approval = 7;
// Next ID: 4 // Next ID: 4
@@ -175,7 +175,7 @@ message ChangeNotesStateProto {
// com.google.gerrit.server.index.change.ChangeField.StoredSubmitRecord. // com.google.gerrit.server.index.change.ChangeField.StoredSubmitRecord.
repeated string submit_record = 14; repeated string submit_record = 14;
// Raw ChangeMessage proto as produced by ProtobufCodec. // Raw ChangeMessage proto as produced by ChangeMessageProtoConverter.
repeated bytes change_message = 15; repeated bytes change_message = 15;
// JSON produced from com.google.gerrit.reviewdb.client.Comment. // JSON produced from com.google.gerrit.reviewdb.client.Comment.